To enforce a valid coding style in the community!

[akanevsky]

But then a Quality Label can be seen as saying that some hacks are better than others, not that their code style is just more in-line with what a group of people think it should be...

If labels are important to you, then we can explicitly state "Validated Code", while having a link at an article explaining what this is all about.

Honestly - If a hack is that important to me as it is so good, and the code is poorly done, I re-code it myself - The only people I can see complaining about coding standards are standard fanatics... I'd say over half the people who visit vBulletin.org and install hacks from here rarely care if the code is sloppy - As long as it doesn't bring their site to a halt and does the job they want, they're happy...

It does bring sites to halt (due to a high server load that results in parsing of an unoptimized code), and I can give you some examples. I just don't think it is necessary. "A buck is made up of cents".

Honestly, all I can see this doing is creating bad feeling, a "division" between coders and eventually tearing a rift in the community...

Thay way no one would fell slighted or small or discouraged for not knowing the standard and having it pointed out

You are missing one: there is already a division: "Coder"/"Adv. Coder"/"Master Coder". And yet - there is no tearing of the community. There are, instead, coders who are struggling to get a higher status by making more useful hacks that will be installed by a larger amount of people.

As with my previous post, it creates a rift - Such a system would effectively be the same as slapping a 2nd-rate sticker onto non-QA approved hacks...

Ah.. I see. And the "Coder" and "Adv.Coder" are like slapping a 2nd-rate and 3rd-rate sticker on coders themselves (according to your point of view)?

My style, except for when I get lazy, was ingrained in me while working at software companies where maintainable, understandable code takes precedence over optimized code. So, while your one-line replacements for my code blocks are appropriate style, they aren't what I'm going for.

What I suggested in those posts was my personal preference, rather than a standard. From your perspective, one liners are harder to read, and I agree with you. This easiness-to-read, is, though, exactly what the vBulletin code standard intended for. No need for worries.

However, I'd like to point out that in one of those three posts I pointed out how to remove three (!!) unnecessary queries from the hack. These unnecessary queries are exactly what I'd like to try to avoid.

THEN, we can add features and code refinements.

There is no such thing as "THEN". "THEN" the hacks will be already installed by everyone, and there will be not point in refining the code. Besides, you usually lose interest in older hacks and do not feel like returning to those later on. Esspecially if they are large hacks. It will be just physically impossible to revise them.

--
P.S. Hellsatan, please do not quote whole posts, ok? You are making the thread cluttered and hard to read. Please edit your posts and remove the quotes. Thanks.