Registration Bug, Unsure of The Fix

[boxingscene]

Originally Posted by Paul M

The fix (as applied to vB4) requires two files to be edited.

Its a shame you didnt raise this a week ago, I could have fitted it into 3.8.11, too late now.

A simpler fix is the one listed in the Jira you linked to.
That fix does, however, mean you would always read userinfo from the master, somewhat defeating the purpose of a slave.

We also use a caching server as well.

How damaging would that fix be in terms of server load on the master? does threads/posts still get read from the slave?

--------------- Added [DATE]1494610398[/DATE] at [TIME]1494610398[/TIME] ---------------

Is there way to code it to where it would only query the master when the current script is the registration page, but uses the slave query for everything else. That way it should have no significant impact on the server.

--------------- Added [DATE]1494622018[/DATE] at [TIME]1494622018[/TIME] ---------------

Originally Posted by Paul M

The fix (as applied to vB4) requires two files to be edited.

Its a shame you didnt raise this a week ago, I could have fitted it into 3.8.11, too late now.

A simpler fix is the one listed in the Jira you linked to.
That fix does, however, mean you would always read userinfo from the master, somewhat defeating the purpose of a slave.

What this be sufficient?

if(THIS_SCRIPT == 'register'){
$user = $vbulletin->db->query_first($query);
}else{
$user = $vbulletin->db->query_first_slave($query);
}