Go Back   vb.org Archive > vBulletin 4 Discussion > vB4 Programming Discussions

Reply
 
Thread Tools Display Modes
  #21  
Old 03-15-2015, 04:44 AM
synseal's Avatar
synseal synseal is offline
 
Join Date: Apr 2009
Posts: 334
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by kapii View Post
Hmmm, I have had no issues with mods that have usergroup permissions set up like the developer has in the mod.

So it looks to me like you have two options.

1) Code the mod up yourself, how you want it to run.
2) If you are not capable of doing that, pay someone to code it to your specifications.
lol you clearly haven't read it.


Please only people that have a clue.

--------------- Added [DATE]1426398588[/DATE] at [TIME]1426398588[/TIME] ---------------

Lynne can you give me your honest opinion about this you answered my first post and the rest of the fanboys jumped in after DB.

What is you opinion on this on how the additional usergroups work for this modification.

Thanks.
Reply With Quote
  #22  
Old 03-15-2015, 04:51 AM
kapii kapii is offline
 
Join Date: Apr 2008
Posts: 95
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by synseal View Post
lol you clearly haven't read it.
Please only people that have a clue.
I think you misspelled that, it should be, "Please only people that will agree with me, not people that have different opinions".
Reply With Quote
Благодарность от:
synseal
  #23  
Old 03-15-2015, 05:21 AM
synseal's Avatar
synseal synseal is offline
 
Join Date: Apr 2009
Posts: 334
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by kapii View Post
I think you misspelled that, it should be, "Please only people that will agree with me, not people that have different opinions".
Well done...

Going back to the 1st post please.
Reply With Quote
  #24  
Old 03-15-2015, 11:47 AM
ForceHSS ForceHSS is offline
 
Join Date: Apr 2008
Posts: 6,357
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

You ask ones to read your first post but you don't seem to listen to what others are saying like my posts I have already got this to work but you don't seem to be interested in this so if you can't be bothered to go over the settings and take the time then I see no point in replying any more here
Reply With Quote
  #25  
Old 03-15-2015, 01:29 PM
ozzy47's Avatar
ozzy47 ozzy47 is offline
 
Join Date: Jul 2009
Location: USA
Posts: 10,929
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Just because it is not working like you want it to, does not mean it's wrong. This type of functionality is built into vBulletin, is_member_of and is working as intended by the vBulletin developers.

As far as I can tell it has been around at least for 11 years, http://www.vbulletin.com/forum/forum...94#post1310794

So before you go around telling people how things are supposed to work, or that they don't have a clue what they are talking about, I suggest you do your research.

You have two developers here, that have a total combined modification release of 315 +/- so I would think they know what they are talking about versus someone who has no modifications released.
Reply With Quote
  #26  
Old 03-15-2015, 01:48 PM
kh99 kh99 is offline
 
Join Date: Aug 2009
Location: Maine
Posts: 13,185
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

My opinion is that it's reasonable the way it is, and it probably works the way people would expect. And as Fillip pointed out, if you think about the option as "Yes, I want to exclude this group" then the inheritance works like you say it should.

However, you have a point. If the "sense" of the option were reversed so that you were choosing which groups were allowed links, then it would be useful for forums that wanted to sell that feature in a paid subscription. (Edit: yeah, it can still be done using primary groups, but I think the reason secondary groups exist is because it's easier to manage "add on" permissions). I had never thought about that myself, and I'm going to consider that in the future (well, if I ever develop another mod that is ). But that doesn't make it wrong, and it looks to me like you were given a reasonable reply.

You guys need to stop bickering. Don't post anything else that isn't related to the question.
Reply With Quote
3 благодарности(ей) от:
ForceHSS, ozzy47, synseal
  #27  
Old 03-15-2015, 04:11 PM
synseal's Avatar
synseal synseal is offline
 
Join Date: Apr 2009
Posts: 334
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by ForceHSS View Post
You ask ones to read your first post but you don't seem to listen to what others are saying like my posts I have already got this to work but you don't seem to be interested in this so if you can't be bothered to go over the settings and take the time then I see no point in replying any more here
I apologies about that but you edited your post before I got chance to see it. "Last edited by ForceHSS : Today at 02:35." Going back to your post now shows me they way you have set this up and I thank you for the input but I do not want to change the members user title which is what would happen if I did it that way.

Even with other modifications I have bought from DB the additional usergroup does work as it should for e.g

shoutbox

These examples are as followed.

When a TK veteran buys " forum supporter" they are given these extra permissions and it works as it should. It keeps the title and the primary usergroup the same but adds these extra features that are ticked in the image.



Thanks/like mod DBs.

Same as above, this allows forum supporters inline with TK veterans to unclick likes etc and works as it should with the additional user groups.



Perhaps I am wrong in thinking that when other modifications from the same site are made they would work the same as others. If I am incorrect then I apologies but that is what I expected.
Reply With Quote
  #28  
Old 03-15-2015, 04:19 PM
ozzy47's Avatar
ozzy47 ozzy47 is offline
 
Join Date: Jul 2009
Location: USA
Posts: 10,929
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by synseal View Post
Perhaps I am wrong in thinking that when other modifications from the same site are made they would work the same as others. If I am incorrect then I apologies but that is what I expected.
Those mods you mentioned work a bit different when checking permissions. They use something like:

PHP Code:
if (!($forumperms $vbulletin->bf_ugp_forumpermissions['canview'])) 
While the mod in the first post uses something like this:

PHP Code:
if (is_member_of($vbulletin->userinfoexplode(','$vbulletin->options['default_online_groups']))) 
Two totally different ways of checking, and both are legit, it just depends on how the coder who wrote the mod decided to do it.
Reply With Quote
  #29  
Old 03-15-2015, 04:22 PM
synseal's Avatar
synseal synseal is offline
 
Join Date: Apr 2009
Posts: 334
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by ozzy47 View Post
Those mods you mentioned work a bit different when checking permissions. They use something like:

PHP Code:
if (!($forumperms $vbulletin->bf_ugp_forumpermissions['canview'])) 
While the mod in the first post uses something like this:

PHP Code:
if (is_member_of($vbulletin->userinfoexplode(','$vbulletin->options['default_online_groups']))) 
Two totally different ways of checking, and both are legit, it just depends on how the coder who wrote the mod decided to do it.
Yes but WHY do they work different? they should work the same and take into account the additional usergroup by choosing YES out of the Yes No confliction to work as ALL other modifications do. This is my point or you should state in the selling page on your site that it does not work with additional users or change the modification so that Admins can add these features as an extra.

Im no expert by far but I know how mods work and this is the first mod I have used that does not take this into account with the additional usergroup.

Downloads II is the same.

on my site

Zero posters cannot download.
Zero posters + forum supporter can. It looks at the addtional usergroup and chooses yes out of the yes no conflict.
Reply With Quote
  #30  
Old 03-15-2015, 04:47 PM
Lynne's Avatar
Lynne Lynne is offline
 
Join Date: Sep 2004
Location: California/Idaho
Posts: 41,180
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

As far as I can tell, and I will say that I don't know this mod at all, but it looks like the permission checks are being done correctly for this modification. The Primary Usergroup has a Yes for not allowed. It's kinda like the default usergroup permission of "Follow Forum Moderation Rules" in which a Yes means no moderation and a No means there is moderation. That one always seemed 'backwards' to me, but it was done that way so the Yes overrides the No. I think you may be trying to use the mod a bit differently than the developer wrote it to be used. I've downloaded several mods that were close to what I wanted, but not exactly, and so I had to change them to work how I wanted them to work on my site. So, really, I think you could just change the permissions check line to how you want it on your site and things will be just fine for your site.
Reply With Quote
Благодарность от:
synseal
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 02:01 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.04712 seconds
  • Memory Usage 2,300KB
  • Queries Executed 14 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (4)bbcode_php
  • (6)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (10)post_thanks_box
  • (5)post_thanks_box_bit
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (3)post_thanks_postbit
  • (10)post_thanks_postbit_info
  • (10)postbit
  • (10)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete