4.2.2 Upgraders, Check your Advanced Search

[findingpeace]

Yesterday, we upgraded from 4.2.1 to 4.2.2 - we did this after extensive testing in a separate environment, to get all of our other plugins playing nice. The upgrade went smoothly, and we love the new version! Much faster on PHP 5.4, so we're really happy about that.

One quick thing I wanted to share, unrelated to plugins. Click the "Advanced Search" button on your site. (http://www.yoursite.com/search.php). Do you have errors at the top of the page?

I did, and it frustrated me because we had carefully followed all upgrade steps. It persisted, even with hooks off.

The solution? See below:

http://www.vbulletin.com/forum/forum...93#post4000793

1. - edit the files "socialgroupmessage.php" and "socialgroupdiscussion.php" found in "packages/vbforum/item/"

2. - The original function reads:

protected function getLoadQuery($required_query, $force_rebuild = false)

3. - Change the function to this:

protected function getLoadQuery($required_query = self::QUERY_BASIC, $force_rebuild = false)

I personally much prefer this method, since I don't think turning off error messages is a very good way of dealing with errors. Just wanted to share, in case anyone saw the same issue!

[Paul M]

This was something that didnt show up in our testing, nor was it reported by any alpha or beta testers. However, it is an issue, and you have posted the correct fix.

[findingpeace]

Cool Just wanted to make sure I was sharing accurate information for other OCD upgraders like me!

Great job on the release, Paul (and everyone on the vB team) - our server load is way down, and a lot of memory is freed up too.

[meaters]

Thanks. Fixed!

I agree with the above comment about speed, pages load noticeable faster on our forums too.

[Amaury]

Yeah, noticed this Sunday night after upgrading early Sunday morning (like, 12:50 AM - 2:00 AM early). I just have to wait for our technical administrator to get on again to fix it.

We had one on profiles, but that was due to DragonByte Tech's Username Change modification, which was fixed for 4.2.2 on Wednesday -- we just needed to update it.

[pityocamptes]

Originally Posted by findingpeace

Yesterday, we upgraded from 4.2.1 to 4.2.2 - we did this after extensive testing in a separate environment, to get all of our other plugins playing nice. The upgrade went smoothly, and we love the new version! Much faster on PHP 5.4, so we're really happy about that.

One quick thing I wanted to share, unrelated to plugins. Click the "Advanced Search" button on your site. (http://www.yoursite.com/search.php). Do you have errors at the top of the page?

I did, and it frustrated me because we had carefully followed all upgrade steps. It persisted, even with hooks off.

The solution? See below:

http://www.vbulletin.com/forum/forum...93#post4000793

1. - edit the files "socialgroupmessage.php" and "socialgroupdiscussion.php" found in "packages/vbforum/item/"

2. - The original function reads:

protected function getLoadQuery($required_query, $force_rebuild = false)

3. - Change the function to this:

protected function getLoadQuery($required_query = self::QUERY_BASIC, $force_rebuild = false)

I personally much prefer this method, since I don't think turning off error messages is a very good way of dealing with errors. Just wanted to share, in case anyone saw the same issue!

Will have to check this out. I had some errors in my admincp and on the Articles tab, and was told on here to turn off errors. Will check the search function, after turning on errors.

This is on my CMS page at top:

Warning: Declaration of vBCms_Item_Content::setItemId() should be compatible with that of vB_Model::setItemId() in ..../packages/vbcms/item/content.php on line 26

These are in admincp:

Warning: Declaration of vB_Database_Alter_MySQL::add_index() should be compatible with that of vB_Database_Alter::add_index() in ..../includes/class_dbalter.php on line 882

Warning: Declaration of vB_Database_Alter_MySQL::add_field() should be compatible with that of vB_Database_Alter::add_field() in ..../includes/class_dbalter.php on line 882

Warning: Declaration of vB_Database_Alter_MySQL::drop_field() should be compatible with that of vB_Database_Alter::drop_field() in ..../includes/class_dbalter.php on line 882

Warning: Declaration of vB_Database_Alter_MySQL::query() should be compatible with that of vB_Database_Alter::query() in ..../includes/class_dbalter.php on line 882


Was told by Ozzy that these were php 5.4 errors. Did you have the same ones, and if so, how did you fix them - besides turning off errors? Thanks.

[ForceHSS]

Originally Posted by pityocamptes

Will have to check this out. I had some errors in my admincp and on the Articles tab, and was told on here to turn off errors. Will check the search function, after turning on errors.

This is on my CMS page at top:

Warning: Declaration of vBCms_Item_Content::setItemId() should be compatible with that of vB_Model::setItemId() in ..../packages/vbcms/item/content.php on line 26

These are in admincp:

Warning: Declaration of vB_Database_Alter_MySQL::add_index() should be compatible with that of vB_Database_Alter::add_index() in ..../includes/class_dbalter.php on line 882

Warning: Declaration of vB_Database_Alter_MySQL::add_field() should be compatible with that of vB_Database_Alter::add_field() in ..../includes/class_dbalter.php on line 882

Warning: Declaration of vB_Database_Alter_MySQL::drop_field() should be compatible with that of vB_Database_Alter::drop_field() in ..../includes/class_dbalter.php on line 882

Warning: Declaration of vB_Database_Alter_MySQL::query() should be compatible with that of vB_Database_Alter::query() in ..../includes/class_dbalter.php on line 882


Was told by Ozzy that these were php 5.4 errors. Did you have the same ones, and if so, how did you fix them - besides turning off errors? Thanks.

They are only warnings not errors

[pityocamptes]

Originally Posted by ForceHSS

They are only warnings not errors

Oh, ok. Since I'm curious, warnings for what, and how do they get fixed? Will a newer php server version solve this? If it is a php warning, which version should be running for 4.2.2? Thanks.

[ForceHSS]

http://www.vbulletin.com/forum/forum...-been-released
https://vborg.vbsupport.ru/showthrea...SQL%3A%3Aquery
http://www.vbulletin.com/forum/forum...-install-error

[pityocamptes]

Ok, thanks. I thought OP had the same problem as me. Looks like my host may be having issues, contacted them. Thanks again.