Is this SQL query correct?

[powerful_rogue]

Originally Posted by Dismounted

Why not just use a join?

PHP Code:

$wtuser = $vbulletin->db->query_first("
    SELECT u.userid, u.username
    FROM useractivation AS ua
    LEFT JOIN user AS u USING (userid)
    WHERE ua.activationid = '" . $vbulletin->db->escape_string($vbulletin->GPC['i']) . "'
    AND ua.emailchange = 0
    LIMIT 1
"); 


Hi Dismounted,

Thanks for your reply. im still a bit confused regarding the joins so need to read up on them a bit more first. Its all the "u" and "ua" bits I dont quite get.

--------------- Added [DATE]1244305258[/DATE] at [TIME]1244305258[/TIME] ---------------

Ive been told the following but was wondering if anyone would be able to help. I feel im getting so close, but its driving me mad!

because $vbulletin->userinfo[] has an empty username as they are a guest. You need to run a check on $vbulletin->userinfo['username']. If it does not have a username than you would use the value from this query:

PHP Code:

$username = $db->query_first("
SELECT useractivation.userid, username 
FROM useractivation 
LEFT JOIN user ON (useractivation.userid = user.userid) 
WHERE activationid = '" . $db->escape_string($vbulletin->GPC['i']) . "'
AND emailchange=0;
    ");

$subjectname = $vbulletin->userinfo['username'] != '' ? $vbulletin->userinfo['username'] : $username['username']; 


However when I output $subjectname as user that is not logged in, its still coming up as "Unregistered"