vb 3.6.x - how to change welcome email sender?

[64North]

LOL
That's my whole point, I don't want to change the board name just to change the "FROM" line of the email, furthermore, I shouldn't have to.

The board name is what it is due to SEO considerations.
Clearly there must be code somewhere that determines what the FROM line of emails is supposed to be, whether that is part of a template or part of the actual vB code.

What I would like to find out where in the code there is a line that looks like
(pseudo) FROM = $vboptions[bbtitle], so that I can hardcode a different name in there.

Edit:
I looked at this myself, turns out that the relevant file is /includes/class_mail.php, will report back once I figured out how to change it. I found it by searching for "from" in all files and looking through those that look like they may have something to do with email.

Edit2: (automerge sucks, as this post is not flagged as new, even though there is now massivly new content )
Ok, in /includes/class_mail.php

FIND:

PHP Code:

$mailfromname = construct_phrase($this->fetch_first_line($vbphrase['x_mailer']), $vbulletin->options['bbtitle']); 


REPLACE WITH:

PHP Code:

$mailfromname = construct_phrase($this->fetch_first_line($vbphrase['x_mailer']), "Outdoor Photo Forum"); 


FIND:

PHP Code:

$mailfromname = $vbulletin->options['bbtitle']; 


REPLACE WITH:

PHP Code:

$mailfromname = "Outdoor Photo Forum"; 


FIND:

PHP Code:

$mailfromname = "$username @ " . $vbulletin->options['bbtitle']; 


REPLACE WITH:

PHP Code:

$mailfromname = "$username @ " . "Outdoor Photo Forum"; 


This will result your email header to change from:

Return-path: <email@domain.net>
Envelope-to: email@domain.net
Delivery-date: Mon, 26 Jun 2006 04:14:34 -0400
Received: from xxx by xxx.xxx.xxx with local (Exim 4.52)
        id 1FumEs-0003Hm-A1
        for email@domain.net; Mon, 26 Jun 2006 04:14:34 -0400
To: email@domain.net
Subject: Welcome to Outdoor Photo Net - Digital Photography and Digital Photo Online Resource!
From: "Outdoor Photo Net - Digital Photography and Digital Photo Online Resource" <email@domain.net>
Auto-Submitted: auto-generated
Message-ID: <200606260816.9a6b42347894@www.outdoor-photo.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8bit
X-Priority: 3
X-Mailer: vBulletin Mail via PHP
Date: Mon, 26 Jun 2006 04:14:34 -0400

to:

Return-path: <email@domain.net>
Envelope-to: email@domain.net
Delivery-date: Mon, 26 Jun 2006 05:17:01 -0400
Received: from xxx by xxx.xxx.xxx with local (Exim 4.52)
        id 1FunDJ-000326-2S
        for email@domain.net; Mon, 26 Jun 2006 05:17:01 -0400
To: email@domain.net
Subject: Welcome to Outdoor Photo Net - Digital Photography and Digital Photo Online Resource!
From: "Outdoor Photo Forum" <email@domain.net>
Auto-Submitted: auto-generated
Message-ID: <200606260957.45748e183842@www.outdoor-photo.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8bit
X-Priority: 3
X-Mailer: vBulletin Mail via PHP
Date: Mon, 26 Jun 2006 05:17:01 -0400

The curious part about the whole thing is that the FROM variable in class_mail.php line:

PHP Code:

function start($toemail, $subject, $message, $from = '', $uheaders = '', $username = '') 


is supposed to be used to do just that. Meaning if I were to assing a string to $from right in that line of code, it should work, but I couldn't get it to actually work, no matter what I tried.

I am not sure what the problem is. Assigning a variable to $from should eliminate the need to do any of the replace edits I showed above.

I am unable to properly debug the whole thing. This is part of the original class_mail.php code

PHP Code:

$from = $this->fetch_first_line($from);
        if (empty($from))
        {
            global $vbphrase;
            if (isset($vbphrase['x_mailer']))
            {
                $mailfromname = construct_phrase($this->fetch_first_line($vbphrase['x_mailer']), $vbulletin->options['bbtitle']);
            }
            else
            {
                $mailfromname = $vbulletin->options['bbtitle'];
            }

            if ($unicode_decode == true)
            {
                $mailfromname = utf8_encode($mailfromname);
            }
            $mailfromname = $this->encode_email_header(unhtmlspecialchars($mailfromname, $unicode_decode), $encoding);

            $fromemail = $vbulletin->options['webmasteremail'];
            $headers .= "From: $mailfromname <" . $vbulletin->options['webmasteremail'] . '>' . $delimiter;
            $headers .= 'Return-Path: ' . $vbulletin->options['webmasteremail'] . $delimiter;
            $headers .= 'Auto-Submitted: auto-generated' . $delimiter;
        }
        else
        {
            if ($username)
            {
                $mailfromname = "$username @ " . $vbulletin->options['bbtitle'];
            }
            else
            {
                $mailfromname = $from;
            }

            if ($unicode_decode == true)
            {
                $mailfromname = utf8_encode($mailfromname);
            }
            $mailfromname = $this->encode_email_header(unhtmlspecialchars($mailfromname, $unicode_decode), $encoding);

            $fromemail = $from;
            $headers .= "From: $mailfromname <$from>" . $delimiter;
            $headers .= 'Return-Path: ' . $from . $delimiter;
        } 


Makes me wonder whether the if (empty($from)) returns TRUE, even if a value is assigned to $from inline.

I just don't know enough about how this all works, but I tried both $from = 'Outdoor Photo Forum' and $from = "Outdoor Photo Forum", and both resulted in empty FROM lines in the email header, empty in such a sense that they looked like this "" <email@domain.net>

Well that's about it. It works the way I chose by replacing all the code as shown above. It would be nice to get it to work by just assigning a value to $from, but after I tried this for a while I grew tried and gave up since I do have a working solution.