The Arcive of Official vBulletin Modifications Site.

DirectPixel · #11 03-02-2006, 04:33 PM

Quote:

Originally Posted by princeton

here's one that shouldn't talk .. selling skins that do not validate
what's really bad is that most of the "problems" in his coding style is common sense -- anyone with coding knowledge could tell you this

regarding the thread: https://vborg.vbsupport.ru/showthread.php?t=108958
you ask for a "review" yet you feel hurt when something doesn't go your way ... why not cry somewhere else bud?

No, I didn't miss the point ... it's just that people like that usually do not do their homework. Hence, they cry foul when they cannot be bothered with STANDARDS. Standards are available for a reason ...
1)__ they can save you money
2)__ they can make your pages appear the same on many appliances

Sorry, that statement wasn't directed to you ... but, to the general public

There is a difference between STANDARDS and VALIDATION. I'm talking about validation. There's a difference.

Let me use the site listed in your signature as an example. http://www.gtwebhost.com -- I'm assuming that's your website, correct?

I put it into the W3C validator. It validates. Congratuations!

But that doesn't mean it's coded properly, nor does it guarantee it'll render properly in all browsers. Let's see... not commenting at your website's visual rendering but only at the source code itself, I found the following problems:

* Excessively nested <DIV> tags. You don't need 3 layers of <DIV> tags, 1 nested table, and another layer of <DIV> tags just to display your main navigation links.

* Tables not used for tabular data. The point of tables is to show tabular data. Not for layout. While your tables do validate because you've provided a summary attribute, you are using them improperly in a fashion not recommended by W3C (the organization and standards body behind your all-so-mighty XHTML Validator)

* Using ID's and Class names that are not descriptive of the content. Another recommendation made by W3C and adopted by designers worldwide.

* Inline tag-level stylesheet declarations. Again, not only bad coding, but also recommendations by the W3C. If you are going to be making tag-level stylesheet declarations, you're better off assigning either an ID and a Class (or both, and use the ID as a modifier of the class).

Code:

<div align="center">
		<div class="page" style="width:740px; text-align:left">
			<div style="padding:0px 10px 0px 10px">

<table summary="header area containing site logo/slogan and important links" cellpadding="0" cellspacing="0" border="0" width="100%" align="center">
<tr>
	<td>
<div class="nobgcolor"><h1><a href="index.php?"><img src="/images/misc/gtweblogo.gif" border="0" alt="gtwebhost - web hosting and web design, vineland nj" width="190" height="29" /></a></h1></div><div title="web hosting vineland nj, web design vineland nj">Web Hosting Solutions for Business Professionals.</div></td>

These are the first few lines of your <body>. Every single thing I just mentioned above applies.

These are just a few of the problems I found after taking a quick glance at the source code. I'm not trying to belittle your website or your skills--I am simply trying to point out that there is more to good web design and coding than simply validation.

There are many elements that contribute to "good coding", and proper validation is only one of them.

Quote:

Standards are available for a reason ...
1)__ they can save you money
2)__ they can make your pages appear the same on many appliances

Not necessarily true. For many corporations, converting all their legacy pages to become standards-compliant can be very costly. However, I do agree--in the long run and when coding pages from scratch, making them standards-compliant may save a considerable amount of money.

However, being standards-compliant definitively does NOT mean your page will look the same in all browsers. There are rendering bugs in just about every major browser out there, which will affect how your final page will look.

Also, it's important to remember that the W3C validator only checks up on your XHTML markup. It doesn't check your linked stylesheets. Depending on your CSS, even the best-coded XHTML page can be broken in all the major browsers.

And if you REALLY want to get nit-picky, your DOCTYPE is XHTML Transitional. It is recommended by the W3C as a solution for transitioning between old-school HTML and modern standards. Under XHTML Strict (which, in today's world, is a very suitable doctype to use), your site would not render properly at all, since attributes such as "align", "border", "width", etc. have all been deprecated.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.08888 seconds Memory Usage 3,674KB Queries Executed 12 (?)
More Information
Template Usage: (1)SHOWTHREAD (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)ad_showthread_beforeqr (1)bbcode_code (37)bbcode_quote (1)footer (1)forumjump (1)forumrules (1)gobutton (1)header (1)headinclude (1)navbar (3)navbar_link (120)option (41)post_thanks_box (41)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (41)post_thanks_postbit_info (41)postbit (41)postbit_onlinestatus (41)postbit_wrapper (1)showthread_list (1)spacer_close (1)spacer_open (1)tagbit_wrapper Phrase Groups Available: global inlinemod postbit posting reputationlevel showthread	Included Files: ./showthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_threadedmode.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_postinfo_query fetch_postinfo fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showthread_start showthread_getinfo forumjump showthread_post_start showthread_query_postids_threaded showthread_threaded_construct_link showthread_query bbcode_fetch_tags bbcode_create showthread_postbit_create postbit_factory postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start tag_fetchbit_complete forumrules navbits navbits_complete showthread_complete
Messages:

The Arcive of Official vBulletin Modifications Site.

It is not a VB3 engine, just a parsed copy!