Warning Messages in Advanced Search vB 422

[nerbert]

Using vB 4.2.2 in PHP 5.4.30

I recently upgraded to vB 422 and started getting these messages above the Advanced Search page (search.php)

Warning: Declaration of vBForum_Item_SocialGroupMessage::getLoadQuery() should be compatible with vB_Model::getLoadQuery($required_query = '', $force_rebuild = false) in ..../packages/vbforum/item/socialgroupmessage.php on line 261

Warning: Declaration of vBForum_Item_SocialGroupDiscussion::getLoadQuery() should be compatible with vB_Model::getLoadQuery($required_query = '', $force_rebuild = false) in ..../packages/vbforum/item/socialgroupdiscussion.php on line 337

There's an old thread on this from a year ago https://vborg.vbsupport.ru/showthrea...hlight=warning but I thought I would discuss a better fix than tinkering with error reporting

There are three files with the method getLoadQuery()

vb/model.php, line 481

packages/vbforum/item/socialgroupdiscussion.php line 129

packages/vbforum/item/socialgroupmessage.php line 113

In the last two files I changed the first line to read

protected function getLoadQuery($required_query = '', $force_rebuild = false)

This makes the line in the last two files identical to the first. That got rid of the warning messages but I don't use socal group messages or discussions so I don't know if these changes are messing anything up.

So, two questions:

Is anyone else getting these warnings?

Does my fix mess anything up ?