The Arcive of Official vBulletin Modifications Site.

Delphiprogrammi · #1 03-08-2006, 08:15 AM

hi people,

what the hell is wrong with this code ?

PHP Code:


			
if($_GET['act'] == "completeremove")

{

      $vbulletin->input->clean_array_gpc('g', array(

        'id' => TYPE_INT,

        'userid' => TYPE_INT,

        'uname' => TYPE_STR,        

        'wname' => TYPE_STR,

        'postid' => TYPE_INT,

        'ban' => TYPE_STR,

        'orderstring' => TYPE_STR,

        ));

}

problem

$vbullein->GPC['ban'] (doesn't work)
$_GET['ban'] (works but that's against the coding standards)

it's an $_GET so the first parameter should be g (short from get).The strange thing is that the same code works fine in another method(yes the verry same code)

why ohhh why :devious:

Marco van Herwaarden · #2 03-08-2006, 09:01 AM

Quote:

Originally Posted by Delphiprogrammi

$vbullein->GPC['ban'] (doesn't work)

Try using $vbulletin (missing t)

Delphiprogrammi · #3 03-08-2006, 09:15 AM

Quote:

Originally Posted by MarcoH64

Try using $vbulletin (missing t)

that's a typo from me :shamed: problem is all variables from type TYPE_INT are passed just fine but TYPE_STR seems to have a problem

PHP Code:


			
echo ($vbulletin->GPC['ban']);

that refuses to work

[high]* Delphiprogrammi is a shamed about the typo[/high]

hi people,

Look here you can see what i mean in the attach screengrabs.

i totally don't get it

Princeton · #4 03-08-2006, 01:02 PM

it works for me

?act=completeremove&ban=hello

displays : hello

Delphiprogrammi · #5 03-08-2006, 01:21 PM

Quote:

Originally Posted by princeton

it works for me

?act=completeremove&ban=hello

displays : hello

hmmmz i'm getting nuts here if it works for you it must be something i overlook :tired:

Marco van Herwaarden · #6 03-08-2006, 01:28 PM

Are you sure you are using GET vars?
How is this field passed/submitted to this scrips?

Delphiprogrammi · #7 03-08-2006, 02:00 PM

Quote:

Originally Posted by MarcoH64

Are you sure you are using GET vars?
How is this field passed/submitted to this scrips?

PHP Code:


			
if ($_GET['act'] == "remove") 

{

        $vbulletin->input->clean_array_gpc('g', array(

        'id' => TYPE_INT,

        'wname' => TYPE_STR,

        'userid' => TYPE_INT,

        'uname' => TYPE_STR,

        'postid' => TYPE_INT,

        'orderstring' => TYPE_STR,

        'ban' => TYPE_STR,

        ));

    

    $temp_wid=$vbulletin->GPC['id'];

    $temp_wname=$vbulletin->GPC['wname'];

    $temp_uid=$vbulletin->GPC['userid'];

    $temp_uname=$vbulletin->GPC['uname'];

    $temp_postid=$vbulletin->GPC['postid'];

    $temp_order=$vbulletin->GPC['orderstring'];

    $temp_ban=$vbulletin->GPC['ban'];

    

    echo " BAN: ";

    echo ($vbulletin->GPC['ban']);



    

    if ($temp_ban=='Y')

    {

        $string_ban="<br><b>This warning has caused a ban. The ban will not be removed from the user's account.<br>Use the Complete Removal, if you want to remove tha ban from the user's account.</b>";

    }

    else

    {

        $string_ban='';

    }

    

    print_cp_header("Advanced Warning System Version {$AWS_VERSION}");

    print_form_header('admin_warn', 'do_delete');

      print_table_header("Removal (manual maturing) of a Warning");

    construct_hidden_code('form','');

    construct_hidden_code('temp_wid',$temp_wid);

    construct_hidden_code('temp_uid',$temp_uid);

    construct_hidden_code('temp_postid',$temp_postid);

    construct_hidden_code('temp_order',$temp_order);

    construct_hidden_code('temp_ban',$temp_ban);

    print_yes_no_row("Are you sure you want to remove this warning?<p><table>

    <tr><td>Warned User ID</td><td>:</td><td>$temp_uid</td></tr>

    <tr><td>Warned User Name</td><td>:</td><td>$temp_uname</td></tr>

    <tr><td>Warning Type</td><td>:</td><td>$temp_wname</td></tr>

    <tr><td>PostID</td><td>:</td><td>$temp_postid</td></tr>

    <tr><td>Caused Ban</td><td>:</td><td>$temp_ban</td></tr>

    <tr><td colspan='3'>$string_ban</td></tr>

    </table><P><U><b>Caution:</b></U> This cannot be undone.", 'verify','');

        print_submit_row("Proceed", 0);

    }

    $vbulletin->input->clean_array_gpc('p', array(

        'temp_wid' => TYPE_INT,

        'temp_wname' => TYPE_STR,

        'temp_uid' => TYPE_INT,

        'temp_uname' => TYPE_STR,

        'temp_postid' => TYPE_INT,

        'temp_order' => TYPE_STR,

        'ban' => TYPE_STR,

        'verify' => TYPE_INT,

        ));

works

PHP Code:


			
if ($_GET['act'] == "completeremove") 

{

    $vbulletin->input->clean_array_gpc('g', array(

        'id' => TYPE_INT,

        'userid' => TYPE_INT,

        'uname' => TYPE_STR,        

        'wname' => TYPE_STR,

        'postid' => TYPE_INT,

        'ban' => TYPE_STR,

        'orderstring' => TYPE_STR,

        ));

    $temp_wid=$vbulletin->GPC['id'];

    $temp_uid=$vbulletin->GPC['userid'];

    $temp_uname=$vbulletin->GPC['uname'];

    $temp_wname=$vbulletin->GPC['wname'];

    $temp_postid=$vbulletin->GPC['postid'];

    $temp_ban=$vbulletin->GPC['ban'];

    $temp_order=$vbulletin->GPC['orderstring'];

    echo "BAN: ";

    echo ($vbulletin->GPC['ban']);

    

    if ($temp_ban=='Y')

    {

        $string_ban="<br><b>This warning has caused a ban. The ban will be removed from the user's account, but the user will not be unbanned, if he is currently banned.<br>Use the Unban User option, in the View Banned Users, in AWS Menu, to unban the user.</b>";

    }

    else

    {

        $string_ban='';

    }

    

    print_cp_header("Advanced Warning System Version {$AWS_VERSION}");

    print_form_header('admin_warn', 'do_completedelete');

      print_table_header("Complete Removal of a Warning");

    construct_hidden_code('form','');

    construct_hidden_code('temp_wid',$temp_wid);

    construct_hidden_code('temp_uid',$temp_uid);

    construct_hidden_code('temp_postid',$temp_postid);

    construct_hidden_code('temp_order',$temp_order);

    construct_hidden_code('temp_ban',$temp_ban);

    print_yes_no_row("Are you sure you want to completely remove this warning?<p><table>

    <tr><td>Warned User ID</td><td>:</td><td>$temp_uid</td></tr>

    <tr><td>Warned User Name</td><td>:</td><td>$temp_uname</td></tr>

    <tr><td>Warning Type</td><td>:</td><td>$temp_wname</td></tr>

    <tr><td>PostID</td><td>:</td><td>$temp_postid</td></tr>

    <tr><td>Caused Ban</td><td>:</td><td>$temp_ban</td></tr>

    <tr><td colspan='3'>$string_ban</td></tr>

    </table><P><U><b>Caution:</b></U> This cannot be undone.", 'verify','');

        print_submit_row("Proceed", 0);

    }

    $vbulletin->input->clean_array_gpc('p', array(

        'temp_wid' => TYPE_INT,

        'temp_wname' => TYPE_STR,

        'temp_uid' => TYPE_INT,

        'temp_uname' => TYPE_STR,

        'temp_postid' => TYPE_INT,

        'temp_order' => TYPE_STR,

        'ban' => TYPE_STR,

        'verify' => TYPE_INT,

        ));

doesn't work.The complete methods are to big to post

Marco van Herwaarden · #8 03-08-2006, 02:18 PM

Well that still don't answer my question.

What is the (HTML) source of the page that submits the act=completeremove.

Delphiprogrammi · #9 03-08-2006, 02:33 PM

Quote:

Originally Posted by MarcoH64

Well that still don't answer my question.

What is the (HTML) source of the page that submits the act=completeremove.

that hack is not mine actually just trying to help out my board is down at the moment can't look to post that html but i've seen before

HTML Code:

<input type="hidden" name="temp_ban" value="" /> (act=completeremove)
<input type="hidden" name="temp_ban" value="N" />(act remove)

that variable ban is staying empty in ?act=completeremove

Marco van Herwaarden · #10 03-08-2006, 02:47 PM

That is not the code for the "ban" variable (but temp_ban). Please post the whole <form> </form> block.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.06309 seconds Memory Usage 2,340KB Queries Executed 14 (?)
More Information
Template Usage: (1)SHOWTHREAD (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)ad_showthread_beforeqr (1)ad_showthread_firstpost (1)ad_showthread_firstpost_sig (1)ad_showthread_firstpost_start (1)bbcode_html (4)bbcode_php (5)bbcode_quote (1)footer (1)forumjump (1)forumrules (1)gobutton (1)header (1)headinclude (1)navbar (3)navbar_link (120)option (1)pagenav (1)pagenav_curpage (1)pagenav_pagelink (10)post_thanks_box (10)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (10)post_thanks_postbit_info (10)postbit (2)postbit_attachment (10)postbit_onlinestatus (10)postbit_wrapper (1)spacer_close (1)spacer_open (1)tagbit_wrapper Phrase Groups Available: global inlinemod postbit posting reputationlevel showthread	Included Files: ./showthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_postinfo_query fetch_postinfo fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showthread_start showthread_getinfo forumjump showthread_post_start showthread_query_postids showthread_query bbcode_fetch_tags bbcode_create showthread_postbit_create postbit_factory postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start postbit_attachment pagenav_page pagenav_complete tag_fetchbit_complete forumrules navbits navbits_complete showthread_complete
Messages:

The Arcive of Official vBulletin Modifications Site.

It is not a VB3 engine, just a parsed copy!