do you see anything wrong with this code?

[Guy G]

PHP Code:

//Rating clculation
$ratings = $DB_site->query("SELECT * FROM " . TABLE_PREFIX . "articlerating WHERE articleid=$articleid");
    $ratingcount = $DB_site->num_rows($ratings);
    while ($rating = $DB_site->fetch_array($ratings))
    {
        $totalrating = $totalrating + $rating['rating'];
    }
    
    if ($ratingcount > 0)
    {
        $totalrating = $totalrating/$ratingcount;
    }
    
    if ($ratingcount == 0)
    {
        $ratingstatus = 'No Rating';
    }
    else
    {
        $totalrating = round($totalrating);
        $ratingstatus = "<img src=\"./images/rating/rating_$totalrating.gif\" style=\"padding-top:4px;\" alt=\"Rating: $totalrating\" height=\"9\">";
    } 


for some reason its not always working... its echoing rating_10.gif for some reason... my home page is www.ex-zone.com, article modules is on the bottom, view source and see.

[Dean C]

Ok what exactly are you trying to do here ?

[cinq]

Hmm seems fine ...
If it is showing rating_10.gif, means the averaged rating for that particular articleid = 10.

a suggestion u might want to try

PHP Code:

//Rating calculation
$ratings = $DB_site->query("SELECT rating FROM " . TABLE_PREFIX . "articlerating WHERE articleid=$articleid");
    $ratingcount = $DB_site->num_rows($ratings);
    $totalrating = 0;
    
    while ($rating = $DB_site->fetch_array($ratings))
    {
          $ratevalue = $rating['rating'];
        $totalrating = $totalrating + $ratevalue;
    }
    
    if ($ratingcount == 0)
    {
        $ratingstatus = 'No Rating';
    }
    else
    {
            $totalrating = $totalrating/$ratingcount;
        $totalrating = round($totalrating);
        $ratingstatus = "<img src=\"./images/rating/rating_$totalrating.gif\" style=\"padding-top:4px;\" alt=\"Rating: $totalrating\" height=\"9\">";
    } 


Would help if you allowed guests to view your article section ..

[Guy G]

Originally Posted by Dean C

Ok what exactly are you trying to do here ?

im trying to show the newest article's rating on vBA home page.

thanks cinq, trying it now.

EDIT: Thanks m8! that did the trick!

[cinq]

You might want to cater

<span class="smallfont">

for the case when there is No Rating.

[Guy G]

Excellent, thanks for all m8.