Help with a query!

[N9ne]

I don't have that...nope...

if statements don't have anything to do with queries right? I have a lot of custom if statements in functions.php...

[NTLDR]

No, the only thinks that could be generating querys in it are queries ($DB_site->, mysql_query) or calls to other functions that may contain queries.

[N9ne]

Then maybe I should look in showthread.php for some sort of call to a function which could be generating loads of queries?

Query: SELECT usergroupid FROM user

But what I don't understand is, this is selecting the usergroupid from the user table, any ideas why?

[NTLDR]

I have that query once on a unhacked showthread, I would say that its getting your usergroupid to check your permissions for view the thread or the other functions on the that page.

[N9ne]

What's making it come up 10 times then?

[NTLDR]

How many times do you have: getpermissions in showthread.php? It should be there twice, once in showpost and once in showthread

[N9ne]

Well I searched functions.php once again and I found the query in the getpermissions area:

PHP Code:


/ ###################### Start getpermissions #######################
function getpermissions($forumid=0,$userid=-1,$usergroupid=-1,$parentlist="") {
  // gets permissions, depending on given userid and forumid
  global $DB_site, $usercache, $bbuserinfo, $enableaccess;

  static $permscache, $usergroupcache;

  $userid=intval($userid);
  if ($userid==-1) {
    $userid=$bbuserinfo['userid'];
    $usergroupid=$bbuserinfo['usergroupid'];
  }

  if ($usergroupid==-1 or $usergroupid==0) {
    if ($userid==0) {
      $usergroupid=1;
    } else {
      if (isset($usercache["$userid"])) {
        $usergroupid=$usercache["$userid"]['usergroupid'];
      } else {
        $getuser=$DB_site->query_first("SELECT usergroupid FROM user WHERE userid=$userid");
        $usergroupid=$getuser['usergroupid'];
      }
    }
  }

  if (!isset($permscache["$usergroupid"]["$forumid"])) {
    if (!$forumid) {
      if (!isset($usergroupcache["$usergroupid"])) {
        $usergroupcache["$usergroupid"] = $DB_site->query_first("SELECT * FROM usergroup WHERE usergroupid=$usergroupid");
        return $usergroupcache["$usergroupid"];
      } else {
        return $usergroupcache["$usergroupid"];
      }
    } else {
      if (!$parentlist) {
        $parentlist=getforumarray($forumid);
      }
      $forums=getforumlist($forumid,"forumid","OR",$parentlist);
      if ($enableaccess==1 AND $access=$DB_site->query_first("SELECT *,INSTR(',$parentlist,', CONCAT(',', forumid, ',') ) AS ordercontrol FROM access WHERE userid=$userid AND $forums ORDER BY ordercontrol LIMIT 1")) {
        if ($access['accessmask']==1) {
          if (!isset($usergroupcache["$usergroupid"])) {
            $getperms=$DB_site->query_first("SELECT * FROM usergroup WHERE usergroupid=$usergroupid");
            $usergroupcache["$usergroupid"] = $getperms;
           } else {
            $getperms = $usergroupcache["$usergroupid"];
          }
        } else {
          if (!isset($usergroupcache["$usergroupid"])) {
            $getperms2=$DB_site->query_first("SELECT * FROM usergroup WHERE usergroupid=$usergroupid");
            $usergroupcache["$usergroupid"] = $getperms2;
          } else {
            $getperms2 = $usergroupcache["$usergroupid"];
          }
          while ( list($gpkey,$gpval)=each($getperms2) ) {
            $getperms["$gpkey"] = 0;
          }
        }
      } else if (!$getperms=$DB_site->query_first("SELECT *,INSTR(',$parentlist,', CONCAT(',', forumid, ',') ) AS ordercontrol FROM forumpermission WHERE usergroupid=$usergroupid AND $forums ORDER BY ordercontrol LIMIT 1")) {
        if (!isset($usergroupcache["$usergroupid"])) {
          $getperms=$DB_site->query_first("SELECT * FROM usergroup WHERE usergroupid=$usergroupid");
          $usergroupcache["$usergroupid"] = $getperms;
        } else {
          $getperms = $usergroupcache["$usergroupid"];
        }
      }
    }
    $permscache["$usergroupid"]["$forumid"]=$getperms;
  } else {
    return $permscache["$usergroupid"]["$forumid"];
  }

  return $getperms;

} 


That's the only place that kind of query shows up in functions.php

[N9ne]

Originally posted by NTLDR
How many times do you have: getpermissions in showthread.php? It should be there twice, once in showpost and once in showthread

PHP Code:

// Logician Download Thread Hack
if ($action=="download") {

require("./global.php");

if (!$threadid OR $threadid<1) {show_nopermission();}

$thread_db=$DB_site->query_first("SELECT * from thread WHERE threadid=$threadid AND visible=1");
if (!$thread_db[threadid] OR $thread_db[threadid]<0) {show_nopermission();}
$forum=getforuminfo($thread_db['forumid']);
// Check Permissions so that a smartass wouldnt download a thread he doesnt allowed
$getperms=getpermissions($thread_db['forumid'],-1,-1,$forum['parentlist']);
if (!$getperms['canview']) {show_nopermission();}
if (!$getperms['canviewothers'] and ($thread['postuserid']!=$bbuserinfo['userid'] or $bbuserinfo['userid']==0)) {show_nopermission();} 


That code is near the top of showthread.php (there is a getpermissions call in there).

It's the download thread hack from logician...

[NTLDR]

That should only add one query at the most to the page.

[N9ne]

Could I PM you my showthread.php and functions.php?