Some help please?

[Chris M]

I keep getting a database error whenever I try to update a user...

Can someone tell me what is wrong with this line?

PHP Code:

    if ($exists=$DB_site->query_first("SELECT userid FROM user WHERE username=".addslashes(htmlspecialchars($ausername))." AND userid <> $userid")) {
        echo "There is already an ".makelinkcode('user',"user.php?do=edit&userid=$exists[userid]",1)." named <b>".htmlspecialchars($ausername)."</b>";
        exit;
    } 


It keeps causing an error, and I dont know why...

Also - Our member numbers jumped from "386" or thereabouts, to something like "12123134"...

Could that be the cause of the error, and if so, how can I change it?

Satan

[NTLDR]

Whats the database error you are getting?

[g-force2k2]

hellsatan try changing::

PHP Code:

userid <> $userid 


to

PHP Code:

userid != $userid 


regards... as for the member issue ouch

g-force2k2

[Chris M]

Thanks gforce...I shall try that

@NTLDR - If gforce hasnt fixed it, I shall post it

Satan

[g-force2k2]

Actually hellsatan the coding doesn't look right at all from my pov... replace your code ::

PHP Code:

    if ($exists=$DB_site->query_first("SELECT userid FROM user WHERE username=".addslashes(htmlspecialchars($ausername))." AND userid <> $userid")) {
        echo "There is already an ".makelinkcode('user',"user.php?do=edit&userid=$exists[userid]",1)." named <b>".htmlspecialchars($ausername)."</b>";
        exit;
    } 


with::

PHP Code:

$exists = $DB_site->query_first("SELECT username FROM user WHERE username='".addslashes(htmlspecialchars($ausername))."' AND userid != $userid");
  if($exists[username] == "$ausername") {
     echo "<p>[ error message here]</p>";
     exit;
  } 


regards... also you forgot the ' slashes around addslashes

g-force2k2

[Chris M]

It didnt fix it, even with gforce's attempt...

I now get this error :

Database error in vBulletin Control Panel 2.2.5:

Invalid SQL: SELECT username FROM user WHERE username='9Teen90Nine' AND userid != 
mysql error: You have an error in your SQL syntax near '' at line 1

mysql error number: 1064

Satan

[g-force2k2]

Hell satan its because you have an empty $userid... the userid variable doesn't seem like its being selected... regards...

edit: what coding do you have that uses the $userid variable?

g-force2k2

[Chris M]

How do you mean gforce?

It is supposed to work in the user.php from the admin file...It is just not working, and I cannot start again, because it is hacked, and I have forgotten which ones I added

Satan

[g-force2k2]

hellsatan i just looked at admin/user.php

find:

PHP Code:

$exists = $DB_site->query_first("SELECT username FROM user WHERE username='".addslashes(htmlspecialchars($ausername))."' AND userid != $userid"); 


replace with:

PHP Code:

$exists = $DB_site->query_first("SELECT username FROM user WHERE username='".addslashes(htmlspecialchars($ausername))."'"); 


see if that works hellsatan... regards...

g-force2k2

[Chris M]

Thanks...

It sorta works...

Now when I try to update someone, I get :

"There is already an [user] named 9Teen90Nine"

Satan