Go Back   vb.org Archive > Community Discussions > Modification Requests/Questions (Unpaid)
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #11  
Old 06-19-2002, 08:22 AM
Broekie's Avatar
Broekie Broekie is offline
 
Join Date: Dec 2001
Location: Netherlands
Posts: 68
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Found a bug: $forumid should be $foruminfo[forumid]
and some more in my code, a space to much (twice) and a ( missing

this is how it should be (for those interested in this):

PHP Code:
if (!ismoderator($foruminfo[forumid]) AND ($foruminfo[forumid]=OR $foruminfo[forumid]=Y)){
  eval(
"standarderror(\"".gettemplate("error_newthreadnotallowed")."\");");
  exit;

place it in newthread.php or newreply.php as Logician specified.
And make a template called error_newthreadnotallowed with something like "Sorry, but you can't post new threads in this subforum. " or whatever you want
Reply With Quote
  #12  
Old 06-19-2002, 09:13 AM
Logician's Avatar
Logician Logician is offline
 
Join Date: Nov 2001
Location: inside vb code
Posts: 4,449
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally posted by Broekie
Found a bug: $forumid should be $foruminfo[forumid]
and some more in my code, a space to much (twice) and a ( missing
nope not a bug.. You should be fine with "$forumid" as well..

you are correct on ( missing..(edited) and your sample of template driven error page is correct either..(nice work!)

BTW If you want to release it with your name, be my guest.. But I still think access permissions will be enough in many cases..

Enjoy..
Logician
Reply With Quote
  #13  
Old 06-19-2002, 12:58 PM
Broekie's Avatar
Broekie Broekie is offline
 
Join Date: Dec 2001
Location: Netherlands
Posts: 68
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally posted by Logician

nope not a bug.. You should be fine with "$forumid" as well..
that gave a parse error on that line

Quote:
Originally posted by Logician


BTW If you want to release it with your name, be my guest.. But I still think access permissions will be enough in many cases..

Enjoy..
Logician
is this release-worthy then?
I mean, it's just a very small hack...
Reply With Quote
  #14  
Old 06-19-2002, 01:39 PM
Logician's Avatar
Logician Logician is offline
 
Join Date: Nov 2001
Location: inside vb code
Posts: 4,449
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally posted by Broekie

that gave a parse error on that line
It was because of missing ) not $forumid..

PHP Code:
is this release-worthy then
IMO no, not release - worthy. As I said I wouldnt even use it because access permissions do the trick in most cases..

Cya,
Logician
Reply With Quote
  #15  
Old 06-19-2002, 01:51 PM
Broekie's Avatar
Broekie Broekie is offline
 
Join Date: Dec 2001
Location: Netherlands
Posts: 68
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally posted by Logician

It was because of missing ) not $forumid..
I'll have to disagree with you here
I got a parse error on line 30 - the line with if (!ismoderator($forumid)) AND ($forumid=Y OR $forumid=Z))
and after I replaced $forumid with $foruminfo[forumid] the parse error on that line was solved
The parse error I got after that was on line 31, and that was indeed due to the missing (
Reply With Quote
  #16  
Old 06-19-2002, 02:15 PM
Logician's Avatar
Logician Logician is offline
 
Join Date: Nov 2001
Location: inside vb code
Posts: 4,449
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally posted by Broekie

I got a parse error on line 30 - the line with if (!ismoderator($forumid)) AND ($forumid=Y OR $forumid=Z))
and after I replaced $forumid with $foruminfo[forumid] the parse error on that line was solved
The parse error I got after that was on line 31, and that was indeed due to the missing (
IMO this is because of ) problem..

Try to reapply:

PHP Code:
if (!ismoderator($forumid) AND ($forumid=OR $forumid=2)) 
Does this line give you a parse error? I think not..
Reply With Quote
  #17  
Old 06-19-2002, 02:44 PM
Broekie's Avatar
Broekie Broekie is offline
 
Join Date: Dec 2001
Location: Netherlands
Posts: 68
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

[high]* Broekie takes his eraser and erases his last post
[/high]

Did I say that didn't work?
I did not!

You're right, it works. I guess the parse error was due to a typo at my side. It must be

[edit]
I now see what ) you mean, and indeed, that must have been the missing character.
[/edit]
Reply With Quote
  #18  
Old 08-18-2002, 10:16 AM
Broekie's Avatar
Broekie Broekie is offline
 
Join Date: Dec 2001
Location: Netherlands
Posts: 68
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I just noticed a bug in the code

it should be $forumid==X (with dubble = )
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 06:30 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.04793 seconds
  • Memory Usage 2,246KB
  • Queries Executed 13 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (3)bbcode_php
  • (6)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (8)post_thanks_box
  • (8)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (8)post_thanks_postbit_info
  • (8)postbit
  • (8)postbit_onlinestatus
  • (8)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete