Error message after using advanced editor

[MistViper]

Hey guys, I'm curious as to how to fix this error I've been getting. I noticed that after I went to advanced editor, to test a new BB code I added to strikethrough words or phrases, it had this error. I know it wasn't caused by the BB code I added, because I removed it and I still received the error. Any ideas on how to find out the problem?

[ozzy47]

Disable plugins via the includes/config.php file.

To do that open your includes/config.php file and below <?php add the following.

PHP Code:

define('DISABLE_HOOKS', true); 


So it looks like this:

PHP Code:

<?php
define('DISABLE_HOOKS', true);
/*=================================================  =====================*\
|| ##################################################  ################## ||
|| # vBulletin 4.2.2

Use a editor like notepad++ to edit any files, don't use Notepad or Wordpad.

If that fixes the issue enable plugins again by adding // before the line you added, then navigate to ACP --> Plugins & Products --> Manage Products and disable one mod at a time until you find the one causing the issue.

Once you find the culprit, post in that mods thread what the issue is, and maybe someone in that thread can help.

[Lynne]

What version of vBulletin are you running and what version of PHP is on the server?

[nerbert]

Here's the offending code :

		if (!$vbulletin->GPC['advanced'])
		{
			if ($vbulletin->GPC_exists['emailupdate'])
			{
				$edit['emailupdate'] =& $vbulletin->GPC['emailupdate'];
			}
			else
			{
				$edit['emailupdate'] = array_pop($array = array_keys(fetch_emailchecked($threadinfo)));
			}
			if ($vbulletin->GPC_exists['htmlstate'] AND $foruminfo['allowhtml'])
			{
				$edit['htmlstate'] = array_pop($array = array_keys(fetch_htmlchecked($vbulletin->GPC['htmlstate'])));
			}
		}

It looks obvious to me that you should simply edit out "$array = ". Tried that but it didn't get rid of the warning. Does anyone know what the problem is with that line?

[MistViper]

Originally Posted by Lynne

What version of vBulletin are you running and what version of PHP is on the server?

4.2.2 and php is 5.3

[nerbert]

I think I got it.

editpost.php lines 315 to 328

		if (!$vbulletin->GPC['advanced'])
		{
			if ($vbulletin->GPC_exists['emailupdate'])
			{
				$edit['emailupdate'] =& $vbulletin->GPC['emailupdate'];
			}
			else
			{
				$array = array_keys(fetch_emailchecked($threadinfo)); $edit['emailupdate'] = array_pop($array);
			}
			if ($vbulletin->GPC_exists['htmlstate'] AND $foruminfo['allowhtml'])
			{
				$array = array_keys(fetch_htmlchecked($vbulletin->GPC['htmlstate'])); $edit['htmlstate'] = array_pop($array); 
			}
		}

This preserves the original line numbers. Anyone want to confirm this?

[Lynne]

Did you already add the below line to your config.php file?

***
As of vBulletin 4.2.2, notices and warnings are no longer suppressed by default like in previous versions of the software. This means that on some servers, you may see warnings that you never saw before. In order to stop them from showing, please add the following line to your config.php file under the <?php line:

PHP Code:

define('SKIP_DS_ERRORS', true); 


***

[nerbert]

Originally Posted by Lynne

As of vBulletin 4.2.2, notices and warnings are no longer suppressed by default like in previous versions of the software. This means that on some servers, you may see warnings that you never saw before. ......

I'm going to be upgrading to 4.2.3 soon and I want all errors, warnings, and notices enabled AND I want to fix any code that generates them. If I understand this correctly this line you recommend adding to config.php isn't missing in 4.2.2, it must be added because full error/warning in enabled elsewhere. Am I right? If so where is it enabled? Is it at the top of each file or is there some global setting that enables it?

The reason I want to do this is I want all these warnings enabled for developing addons. I remember not long ago in an earlier version all error reporting was suppressed and debugging was ridiculously difficult for new addons.

[ozzy47]

I think in includes/class_core.php in the function vb_error_handler

[nerbert]

That seems to affect what text is shown but it doesn't seem to affect whether error/warning text is shown.