help with PHP

[geniuscrew]

Hi

I'm trying to modify neo's 'admin avatar size' hack.

I'm changing it so that mods have different sizes to admins.

Could someone please tell me what is wrong this code (I'm gussing it's the wasy I structured it:

PHP Code:

 if ($bbuserinfo[usergroupid]==6 || $bbuserinfo[usergroupid]==7 || $bbuserinfo[usergroupid]==5) {
    $customtext = "Note: the maximum size of your custom image is $amw in width by $amh in height or $amfs bytes (whichever is smaller).";
  } else {
    $customtext = "Note: the maximum size of your custom image is $mmw in width by $mmh in height or $mmfs bytes (whichever is smaller).";
  } else {
    $customtext = "Note: the maximum size of your custom image is $avatarmaxdimension by $avatarmaxdimension pixels or $avatarmaxsize bytes (whichever is smaller).";
  } 


Thanx

[Xenon]

you cannot make a second else clause after one.
you must make it more specific like this:

PHP Code:

if ($bbuserinfo[usergroupid]==7) {
    $customtext = "Note: the maximum size of your custom image is $amw in width by $amh in height or $amfs bytes (whichever is smaller).";
} else {
  if ($bbuserinfo[usergroupid]==6 || $bbuserinfo[usergroupid]==5) {
    $customtext = "Note: the maximum size of your custom image is $mmw in width by $mmh in height or $mmfs bytes (whichever is smaller).";
  } else {
    $customtext = "Note: the maximum size of your custom image is $avatarmaxdimension by $avatarmaxdimension pixels or $avatarmaxsize bytes (whichever is smaller)."; 
  }
} 


this should work

[geniuscrew]

Thanx xenon, that works

Now i've applied the same format to a piece of code to get this :

PHP Code:

if ($bbuserinfo[usergroupid]==6) {
        if ($filesize>$amfs) {
          eval("standarderror(\"".gettemplate("error_avatartoobig")."\");");
          // file size too big
          exit;
        }
      } else {
    if ($bbuserinfo[usergroupid]==7 || $bbuserinfo[usergroupid]==5) {
         if ($filesize>$mmfs) {
          eval("standarderror(\"".gettemplate("error_avatartoobig")."\");");
          // file size too big
          exit;
    }
      } else {
        if ($filesize>$avatarmaxsize) {
          eval("standarderror(\"".gettemplate("error_avatartoobig")."\");");
          // file size too big
          exit;
        }
      } 


Is it correct?

Thanx again

[Xenon]

this code is correct, but you have forgotten an } at the end.

i cant see any other error

[geniuscrew]

Thanx that works too but one more error lol

towards the end at about line 1549

[PHP]
}

?>
[/PHP

There is another error.

Thankyou very much for your help

[Xenon]

what is the errormessage exactly?

errors in the last lines ar often } too much or too less

perhaps you haven't forgotten this } of my last post in your code, but have forgotten it in your post here

[geniuscrew]

it's not working still

The message i get is:

Parse error: parse error in /home/charmed/public_html/forums/member.php on line 1550

[geniuscrew]

Actually i got it working now

Vielen danken fur deine Hilfe Xenon!


Bye!

[Xenon]

fine

i'm glad i could help you

[Nutt]

PHP Code:

if ($bbuserinfo[usergroupid]==6) {

        if ($filesize>$amfs) {
          eval("standarderror(\"".gettemplate("error_avatartoobig")."\");");
          // file size too big
          exit;
        }

} elseif ($bbuserinfo[usergroupid]==7 || $bbuserinfo[usergroupid]==5) {

        if ($filesize>$mmfs) {
          eval("standarderror(\"".gettemplate("error_avatartoobig")."\");");
          // file size too big
          exit;

      } elseif ($filesize>$avatarmaxsize) {
          eval("standarderror(\"".gettemplate("error_avatartoobig")."\");");
          // file size too big
          exit;

      }
} 


You could have used a elseif statement