Go Back   vb.org Archive > Community Central > Community Lounge
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #71  
Old 06-22-2012, 12:40 AM
Zachery's Avatar
Zachery Zachery is offline
 
Join Date: Jul 2002
Location: Ontario, Canada
Posts: 11,440
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

So, maybe i'm confused, shouldn't you submit bugs?

I would argue you don't even want sensitive info like the AdminCP backend to have anything fancy done to it.

In an ideal world wouldn't they give you the ability to disable it for specific folders/files?
Reply With Quote
  #72  
Old 06-22-2012, 11:48 AM
final kaoss final kaoss is offline
 
Join Date: Apr 2006
Posts: 1,314
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Well like this guy stated... you can block it off from loading in certain area's... Trouble is that you only get 3 pagerules to start with from the free service. Of course the ckeditor alone loads in more than just one place:
Showthread
Member visitor message
Newreply
New Thread
Blog posting
CMS Article posting
Groups

Quote:
Originally Posted by damoncloudflare View Post
Probably best to let you do it (details here).

Note: I put a PageRule in for you (you can look for the option by going to settings->PageRules).
Reply With Quote
  #73  
Old 06-22-2012, 04:15 PM
Zachery's Avatar
Zachery Zachery is offline
 
Join Date: Jul 2002
Location: Ontario, Canada
Posts: 11,440
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Maybe you should request that they just exclude the ckeditor from ever using their service? Surely they can adapt to that.

It seems like you're kinda stuck between a rock and a hard place here.

At that point, you've excluded half the most viewed pages of your forum, whats the point of the service?
Reply With Quote
  #74  
Old 06-22-2012, 06:34 PM
final kaoss final kaoss is offline
 
Join Date: Apr 2006
Posts: 1,314
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Your response makes it seem that you think they only made this for vbulletin. Cloudflare can be used by ANY kind of software used to make a site with. They can't just exclude the ckeditor from ever using their service, because how would they?
Quote:
Originally Posted by Zachery View Post
Maybe you should request that they just exclude the ckeditor from ever using their service? Surely they can adapt to that.

It seems like you're kinda stuck between a rock and a hard place here.

At that point, you've excluded half the most viewed pages of your forum, whats the point of the service?
Reply With Quote
  #75  
Old 06-24-2012, 12:46 PM
Zachery's Avatar
Zachery Zachery is offline
 
Join Date: Jul 2002
Location: Ontario, Canada
Posts: 11,440
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I would imagine if ckeditor isn't working in vBulletin its not working anywhere else either.

And I would also argue that a large number of sites use vBulletin. It would be in their best intrests to develop rules that suite their customers.

So, my suggestions to submit bug reports/feature requests at their end sound valid.
Reply With Quote
  #76  
Old 06-25-2012, 03:56 AM
final kaoss final kaoss is offline
 
Join Date: Apr 2006
Posts: 1,314
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Yes I do submit the bugs that I happen upon, always have. The thing with vbulletin's ckeditor is that it is heavily modded & custom coded and god only knows what kind of unholy things were done to it's javascript to implement it into vbulletin

One thing seems for certain though, if it is deferred it doesn't load and my understanding is that the async attribute contributes to this. (which cloudflare appends to javascript that it finds).

From all I know though, you've seen how the ckeditor code looks before getting thrown into the coding blender & shoved into the vbulletin product. With that said, the only instance I've seen ckeditor in is in vbulletin & invision... which I don't have an invision board to see if the rocketloader breaks it or not. So for now I'll take your word for it & give the ckeditor script in a whole the blame & look to see if I can find any other cms websites that use ckeditor as an editor and attempt to test those via cloudflare's rocketloader.

Quote:
In order to load a page, the browser must parse the contents of all <script> tags, which adds additional time to the page load. By minimizing the amount of JavaScript needed to render the page, and deferring parsing of unneeded JavaScript until it needs to be executed, you can reduce the initial load time of your page.

Details from Google

There are several techniques that can be used to defer parsing of JavaScript. The simplest and preferred technique is to simply Defer loading of JavaScript until it is needed. A second technique is to use the <script async> attribute where appropriate, which prevents parsing from blocking the initial page load by deferring it until the browser's UI thread is not busy doing something else.
Reply With Quote
  #77  
Old 06-25-2012, 08:58 AM
Paul M's Avatar
Paul M Paul M is offline
 
Join Date: Sep 2004
Location: Nottingham, UK
Posts: 23,748
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by extreme-gaming View Post
The thing with vbulletin's ckeditor is that it is heavily modded & custom coded and god only knows what kind of unholy things were done to it's javascript to implement it into vbulletin
Very little was done to the Javascript (quite deleberately, since any changes would have to be made everytime it was updated to the latest CKE version).
Reply With Quote
  #78  
Old 06-25-2012, 11:03 AM
final kaoss final kaoss is offline
 
Join Date: Apr 2006
Posts: 1,314
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

So what about the extra javascript that the team had to add in? In particular the editing buttons. The ckeditor will load with the rocketloader enabled but the editing buttons will not.
Reply With Quote
  #79  
Old 08-14-2012, 05:38 PM
doctorsexy's Avatar
doctorsexy doctorsexy is offline
 
Join Date: Mar 2011
Location: earth
Posts: 383
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Paul M View Post
Basically they act like a giant proxy server, your dns [for your site] points to thier servers, so a connecting client connects to them, and they then connect to your site. Thats why you need to make the edits to class core, without them all traffic to your site would appear to originate from their servers, so they pass on the original ip as an http variable.
I know this is an old post but would this be for apply for vb4.2.0 as well... thanks
Reply With Quote
  #80  
Old 08-14-2012, 11:59 PM
Paul M's Avatar
Paul M Paul M is offline
 
Join Date: Sep 2004
Location: Nottingham, UK
Posts: 23,748
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

For cloudfare ? Yes.
Reply With Quote
Благодарность от:
doctorsexy
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 06:59 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.04771 seconds
  • Memory Usage 2,270KB
  • Queries Executed 13 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (5)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (3)pagenav_pagelink
  • (10)post_thanks_box
  • (1)post_thanks_box_bit
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit
  • (10)post_thanks_postbit_info
  • (10)postbit
  • (10)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete