Go Back   vb.org Archive > Community Central > vBulletin.org Site Feedback
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #1  
Old 01-05-2002, 08:06 PM
samtha25 samtha25 is offline
 
Join Date: Jan 2002
Posts: 37
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

One of the nice things about vBulletin is that showthread was designed so that each message is in a separate table, which keeps wide messages with code from making the entire thread go wide. When you wrap showthread in a table, though, you break that nice feature, since each message table will then go as wide as the outer table, which will be as wide as the widest message. Moreover, a message with code is breaking out to the left as well as the right, as the browsers struggle to make sense of the width specifications.

Pretty is nice, but not at the expense of functional. Since vbulletin.org is, by definition, a site where many posts may be expected to contain code, I suggest you sacrifice the neat look, if need be, and break showthread out of the wrapping table. You might be able to retain the thin silver border, but the drip thing would have to end before the first post in the thread, but it might be better to just accept a less elaborate look for showthread.

In sizing the columns in showthread, here's what I've found works best across browsers. Use a spacer gif in the author column (including the heading where it says "Author" "Thread"). Set the width to between 160-175, height to 1. Remove width attributes from _all_ the columns except for the thread column. Set the width on the thread column in showthread and postbit to 90%. That should force the thread column to butt up against the spacer gif in the author column, then resize out, when there is pre text in the message.
Reply With Quote
  #2  
Old 01-05-2002, 09:43 PM
Sinecure's Avatar
Sinecure Sinecure is offline
 
Join Date: Oct 2001
Location: Victoria, BC, Canada
Posts: 407
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I beleive this is one of the reasons we made the 2nd style available Plus certain people didn't like the colors .
Reply With Quote
  #3  
Old 01-06-2002, 05:04 AM
Mark Hensler's Avatar
Mark Hensler Mark Hensler is offline
 
Join Date: Oct 2001
Location: California
Posts: 205
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I'm still trying to grasp this concept of the end-user explaining to the author how to use the product. Opinions are one thing. But I highly doubt that these people require a lesson on tables.
Reply With Quote
  #4  
Old 01-06-2002, 10:51 AM
Admin's Avatar
Admin Admin is offline
Coder
 
Join Date: Oct 2023
Location: Server
Posts: 1
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I appreciate your input samtha25, I'll see what I can do about this problem.
I will probably create another header/footer without the outter border, and use them in showthread and newreply.
Reply With Quote
  #5  
Old 01-07-2002, 09:13 AM
Meta's Avatar
Meta Meta is offline
 
Join Date: Nov 2001
Location: Germany (north)
Posts: 65
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Yeah. Good idea!

(it's horrible to read here sometimes ... if you only have 800 x 600 pixels on a tv.)
Reply With Quote
  #6  
Old 01-07-2002, 09:16 AM
Meta's Avatar
Meta Meta is offline
 
Join Date: Nov 2001
Location: Germany (north)
Posts: 65
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Did i understand you well, Sinecure?

The other style don't has this problem?

(If yes ... i will use the other style instead.)
Reply With Quote
  #7  
Old 01-07-2002, 11:24 AM
Admin's Avatar
Admin Admin is offline
Coder
 
Join Date: Oct 2023
Location: Server
Posts: 1
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Problem should be fixed now... new header/footer was create for showthread and newreply pages, to keep this from happening again.
Reply With Quote
  #8  
Old 01-08-2002, 02:54 AM
samtha25 samtha25 is offline
 
Join Date: Jan 2002
Posts: 37
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

That solves the problem of the entire thread going wide, but messages with any long lines of PRE text in them are still breaking out to the left and right. You can probably get them to line up on the left if you do as Wayne suggested at vb.com and make the width of the thread column width="*", but I haven't looked at your source in any detail. If you want the author column to line up all the time, I think the only way is to throw in the spacer gif. I haven't found anything else that works.

BTW, I like these colors!
Reply With Quote
  #9  
Old 01-08-2002, 05:43 AM
Mark Hensler's Avatar
Mark Hensler Mark Hensler is offline
 
Join Date: Oct 2001
Location: California
Posts: 205
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I like the template changes. I actually didn't notice until I read in there that they changed.
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 12:35 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.09548 seconds
  • Memory Usage 2,241KB
  • Queries Executed 13 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (9)post_thanks_box
  • (9)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (9)post_thanks_postbit_info
  • (9)postbit
  • (9)postbit_onlinestatus
  • (9)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete