Javascript confirmation box

[Falcon Capt]

Originally Posted by Boofo

Where did you end up putting the js code?

At the very top of the navbar template.

No problem.

And Boofo is right, javascript should go in the headinclude template.

[Falcon Capt]

Originally Posted by Danny.VBT

No problem.

And Boofo is right, javascript should go in the headinclude template.

Ok, moved it to the header_includes template.

One other problem I am having with this script. Occasionally in certain browsers, I get a "Your Submission could not be processed due to an invalid security token" error when trying to Mark All Read. Doesn't happen in IE8, but happens on the browser on my Droid (Safari derivative I believe).

Any thoughts?

This occurred with the new version? Or has been happening?

[Falcon Capt]

Originally Posted by Danny.VBT

This occurred with the new version? Or has been happening?

Actually happened in 3.8.5 as well. Only seems to be certain browsers (mostly mobile browsers). Almost appears as though the browser isn't passing the security hash through the script (it is a java enabled browser).

[Boofo]

Is there anyway to check if the browser handles js and use the regular link for those occasions that it doesn't?

[Falcon Capt]

Originally Posted by Boofo

Is there anyway to check if the browser handles js and use the regular link for those occasions that it doesn't?

The browser does handle js. If I remove the following code from FORUMDISPLAY.PHP it works properly:

// Prevent CSRF. See #32785
$vbulletin->input->clean_array_gpc('r', array(
'markreadhash' => TYPE_STR,
));
if (!verify_security_token($vbulletin->GPC['markreadhash'], $vbulletin->userinfo['securitytoken_raw']))
{
eval(standard_error(fetch_error('security_token_invalid', $vbulletin->options['contactuslink'])));
}

So it is something with the CSRF protection (this issues started with vB 3.8.5 when they put CSFR protection on the Mark All Read function.)

Can you check the URL upon redirect? Is there a hash in the query string?

[Falcon Capt]

Originally Posted by Danny.VBT

Can you check the URL upon redirect? Is there a hash in the query string?

I really can't tell as there is no way to see the full link during the redirect on the mobile browser.

[omerfarukak]

I'm trying to use this method but when i add this function and hit the save button, it says

Fatal error: Maximum function nesting level of '100' reached, aborting! in /var/www/includes/vb_template.php on line 51

how can i resolve this problem?

--------------- Added [DATE]1314536746[/DATE] at [TIME]1314536746[/TIME] ---------------

Finally, i can include this function from external file...

But now it's not working with vb4.1.5

I've add

<script type="text/javascript" src="markread.js"></script>

this to headerinclude and it's contains

function markAsRead(session, markreadhash)
{
 var markRead = confirm("Butun mesajlar okundu kabul edilecek. Emin misiniz?");
 if (markRead == true)
 { window.location="forumdisplay.php?" + session + "do=markread&markreadhash=" + markreadhash;
 }
 else
 {    
  }
}

then i'have change mark as read link with this

<a href="javascript:markAsRead({vb:raw session.sessionurl},{vb:raw bbuserinfo.securitytoken});">{vb:rawphrase mark_forums_read}</a>

This doesn't work... What can we do?