Display issue

[Excalibur82]

I'm having an issue with a mod I'm creating for my site. Right now I have it saving screenshots to the database along with files. When you view the page, it lists the first file in the db twice and since it has 2 screenshots, the first duplicate shows one screenshot, then the second duplicate shows 2 screenshots.

Here is the code:

PHP Code:

$query = $db->query_read("SELECT * FROM " . TABLE_PREFIX . "download AS download 
                          LEFT JOIN " . TABLE_PREFIX . "download_screenshots AS screenshots ON (screenshots.file_id = download.id)");
    while ($dl = $db->fetch_array($query))
        {
            $id = $dl['id'];
            $version = $dl['version'];
            $name = $dl['name'];
            $size = $dl['size'];
            $description = $dl['description'];
            $username = $dl['username'];
            $userid = $dl['userid'];
            $sid = $dl['sid'];
            $screenshot = $dl['sdata'];

            eval('$display_shots .= "' . fetch_template('bfc_download_screenshot_display') . '";');
            eval('$display_bit .= "' . fetch_template('bfc_download_bit') . '";');

        }

$navbits = array();
$navbits[$parent] = 'Download :: Index';

$navbits = construct_navbits($navbits);

eval('$display = "' . fetch_template('bfc_download_main') . '";'); 


I have attached a screenshot for you to view.

As you can see from the screenshot, Your Linker.zip is the entry that shows up twice when I have checked the db and it is only in the db once.

[Lynne]

If you are only expecting one result, why aren't you using query_first ? Then you don't need to do your while loop.

[Excalibur82]

Its supposed to be all records from the database. There are screenshots in the database for each file record that need to be pulled and displayed with the file.

The screenshot only shows those 2 entries as thats where my problem is, there are a total of 3 files in the db. All 3 show though, but the first duplicates.

[Lynne]

Each time you go through the loop, you are adding to $display_shots. I assume $display_shots is then used in $display_bit? The first time you go through the loop, you will have one display shot, then the second time, two display shots, then the third time, three display shots, etc. Don't use ".=", use just "=" if you don't want that to happen.

[Excalibur82]

Ok, I tried it, did nothing but make it 1 screenshot per duplicate. So I still have duplicates, same issue with screenshots. Do you need to view any templates or anymore php code?

[Dismounted]

So what is the code you are using now?

[Excalibur82]

I'm using this, only changed what Lynne suggested above.

PHP Code:

$query = $db->query_read("SELECT * FROM " . TABLE_PREFIX . "download AS download 
                          LEFT JOIN " . TABLE_PREFIX . "download_screenshots AS screenshots ON (screenshots.file_id = download.id)");
    while ($dl = $db->fetch_array($query))
        {
            $id = $dl['id'];
            $version = $dl['version'];
            $name = $dl['name'];
            $size = $dl['size'];
            $description = $dl['description'];
            $username = $dl['username'];
            $userid = $dl['userid'];
            $sid = $dl['sid'];
            $screenshot = $dl['sdata'];

            eval('$display_shots = "' . fetch_template('bfc_download_screenshot_display') . '";');
            eval('$display_bit .= "' . fetch_template('bfc_download_bit') . '";');

        }

$navbits = array();
$navbits[$parent] = 'Download :: Index';

$navbits = construct_navbits($navbits);

eval('$display = "' . fetch_template('bfc_download_main') . '";'); 


[Dismounted]

What is being displayed? (i.e. provide screenshot)

I'm not really understanding what is duplicating.

[Excalibur82]

Oh guess that would help. lol

I took it down to only 2 entries.

First screenshot is the duplicate entries showing.

Second screenshot is the bottom of the record list showing the last entry that has no screenshot attached to it yet.

[Excalibur82]

Lynne, Dismounted, did you both give up me already? LOL