Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 General Discussions
  #1  
Old 01-25-2006, 07:30 PM
DannyITR DannyITR is offline
 
Join Date: Jan 2002
Posts: 325
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Is shoudl be absolutely mandatory to put which line to find the sought code

The most annoying thing when installing a hack is when the programmer neglects to say which line in a file the code that needs to be raplced is found. In a file with thousands of lines it could take 5-10 minutes of searching. It would take a mere 5 secs to put this info into the hack readme. Why don't they do this? The worst is when not only is there no line # but the code mods are not even in chronalogical order!!!

VB.org should make this a mandatory thing when posting a hack. Do you know how many hours you'd save people?
Reply With Quote
  #2  
Old 01-25-2006, 07:32 PM
vBintense's Avatar
vBintense vBintense is offline
 
Join Date: May 2005
Location: Omnipresent
Posts: 233
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

This is due to one thing, say if you have a highly hacked global.php and they do not, they could say line 89 and yours would be 230.

So most use a find this method which is very easy to do via a find option as it is with a line number.
Reply With Quote
  #3  
Old 01-25-2006, 07:42 PM
DannyITR DannyITR is offline
 
Join Date: Jan 2002
Posts: 325
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

You know all this time and I didn't even realize I coudl search a file for a line of code.

Anywyas I still think that more often than not it might help people. Most forums probbaly are not hacked too much.
Reply With Quote
  #4  
Old 01-25-2006, 07:49 PM
vBintense's Avatar
vBintense vBintense is offline
 
Join Date: May 2005
Location: Omnipresent
Posts: 233
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

You may be shocked, and thankfully with the new vBulletin many code hacks are no longer needed thanks to the hook system.

But I remember old threads in vB 2 where they would put line numbers and half the replys where people who could not find them.
Reply With Quote
  #5  
Old 01-29-2006, 04:35 PM
Guest210212002
Guest
 
Posts: n/a
Default

Quote:
Originally Posted by DannyITR
. Most forums probbaly are not hacked too much.
On here? This is a vB hacking site amigo, chances are if there's one place that would have the MOST admins of hacked forums, it's here.
Reply With Quote
  #6  
Old 01-29-2006, 07:17 PM
Brad Brad is offline
 
Join Date: Nov 2001
Posts: 4,765
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Even small hacks are enough to mess up the line numbers to the point that they become useless. Searching for the code itself is the best way.
Reply With Quote
  #7  
Old 01-29-2006, 10:36 PM
KTBleeding's Avatar
KTBleeding KTBleeding is offline
 
Join Date: Feb 2004
Location: Tooele, UT
Posts: 756
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by DannyITR
You know all this time and I didn't even realize I coudl search a file for a line of code.
It took me years to find that out. Seriously.. I used to hand search for lines of code when installing hacks.

How hilarious.
Reply With Quote
  #8  
Old 01-29-2006, 10:48 PM
kall's Avatar
kall kall is offline
 
Join Date: Apr 2004
Location: New Zealand
Posts: 2,608
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Brad
Even small hacks are enough to mess up the line numbers to the point that they become useless. Searching for the code itself is the best way.
An it IS mandatory to use unique lines, according to the rules.
Reply With Quote
  #9  
Old 01-31-2006, 04:56 AM
Brandon Sheley's Avatar
Brandon Sheley Brandon Sheley is offline
 
Join Date: Mar 2005
Location: Google Kansas
Posts: 4,678
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Ctrl+f is my friend
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 02:14 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.04080 seconds
  • Memory Usage 2,230KB
  • Queries Executed 13 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (3)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (9)post_thanks_box
  • (9)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (9)post_thanks_postbit_info
  • (9)postbit
  • (8)postbit_onlinestatus
  • (9)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete