CODERS PLEASE DISCUSS!!! Pre-Datastore modifications with XML-files (UPDATE 28-7)

[amykhar]

Look at the top of just about every vbulletin script. You'll see something like this:

// get special data templates from the datastore
$specialtemplates = array(
	'userstats',
	'birthdaycache',
	'maxloggedin',
	'iconcache',
	'eventcache',
	'mailqueue'
);

That pulls the datastore items into the code you are going to use. All you have to do after that is refer to them.

[Andreas]

@Marco (and of course also all others interested)
I've re-implemented both Suggestions to cut down File Edits.

Only 1 File Edit (2 Lines) to config.php is required, and it will even survive Upgrades.

What do you think?

For Alternative 2:
Maintaining the Table should be done by Product Install/Uninstall-Codes so we don't have to care for that, except disabling/enabling a Product (which is handled by a Plugin).

I think i'll also implement Revans Idea (var_dump).

[phlogiston]

Originally Posted by MarcoH64

I am a bit disappointed at the lack of feedback and discussion in this thread from most coders.

So far I've had to add two datastore items and one phrasegroup via edit to global.php On my site that doesn't bother me, but it will discourage me from sharing which is a shame

So you definitely have my full support trying to work this one out, but to be honest my knowledge is more patched together from hacking rather than being up to speed to follow the intricacies of trying to optimise how to do this.

Basically: sorry I ain't much practical help but folk are interested & keen to have a good solution to this (Y)

[Revan]

Originally Posted by amykhar

Look at the top of just about every vbulletin script. You'll see something like this:

// get special data templates from the datastore
$specialtemplates = array(
	'userstats',
	'birthdaycache',
	'maxloggedin',
	'iconcache',
	'eventcache',
	'mailqueue'
);

That pulls the datastore items into the code you are going to use. All you have to do after that is refer to them.

Thanks for the lesson, it worked like a charm
I even managed to code a workaround for having to prefix my custom datastore items with 'rpg_' (for ease of uninstall, identification etc) to stop my custom class calls to have to have this prefix as well

[Marco van Herwaarden]

Originally Posted by phlogiston

So far I've had to add two datastore items and one phrasegroup via edit to global.php

Putting them in global should only be done if they are used everywhere. If they are only used in a few scripts, they should be placed in those scripts, meaning maybe a lot of edits.

Will have a look at your solutions on monday kirby.

[Andreas]

Monday has almost passed ... at least in my Timezone

[Marco van Herwaarden]

Yeah i know, and i didn't hae time today.
And i even doubt i will have time tomorrow, but will look as fast as i can.

But this don't need to stop other coders to have a look and comment.

[Andreas]

*bump*

?

[merk]

I really think the solution to this problem could be very simple

Datastore class:

[sql]
$dataitems = $db->query_read("
SELECT title, data
FROM " . TABLE_PREFIX . "datastore
# LEFT JOIN " . TABLE_PREFIX . "_NEWTABLE_ ON(datastore.title = _NEWTABLE_.title AND \"" . THIS_SCRIPT . "\" IN(_NEWTABLE_.page)
# LEFT JOIN " . TABLE_PREFIX . "product ON (product.productid = _NEWTABLE_.productid)
WHERE title IN ($itemlist)
# OR ( NOT NULL(_NEWTABLE_.title) AND product.active = true )
");
[/sql]

[Andreas]

That's basically my idea

But it does only work for the default Datastore Class - and only for Datastore Items.