What Am I Doing Wrong?

[ManagerJosh]

Originally Posted by Live Wire

That error is due to one of two possiablities.
1) pm.userid is showing up as empty.
Or
2) pm.folderid is showing up as empty

i'm leaning towards pm.folderid being empty as if you look at the SQL error, a userid is specified.

Now to figure out why folderid isn't being generated...

[Logikos]

Well your default inbox is folderid 0. Do some debugging. Change this line:

PHP Code:

WHERE pm.userid=$userid AND pm.folderid=$folderid 


To

PHP Code:

WHERE pm.userid=$userid AND pm.folderid='0' 


If you do not get an error when you refresh the page then you need to make sure that the $folderid variable is holding some information. Look above your code and see if anything says $folderid = $var.

[ManagerJosh]

Originally Posted by Live Wire

Well your default inbox is folderid 0. Do some debugging. Change this line:

PHP Code:

WHERE pm.userid=$userid AND pm.folderid=$folderid 


To

PHP Code:

WHERE pm.userid=$userid AND pm.folderid='0' 


If you do not get an error when you refresh the page then you need to make sure that the $folderid variable is holding some information. Look above your code and see if anything says $folderid = $var.

or you could take a look at the hack yourself

I'm trying to port one of Scott's other hacks..

[Logikos]

As supected, $folderid was empty and not defined. vBulletin 3.5.0 no longer uses INT .
This:

PHP Code:

$vbulletin->input->clean_array_gpc($_REQUEST, array('folderid' => INT)); 


Should Be:

PHP Code:

$vbulletin->input->clean_array_gpc($_REQUEST, array('folderid' => TYPE_INT)); 


But for some reason that was not working, i'm not going to lose sleep over why that isn't working as it should so I just replaced it with

PHP Code:

$folderid = $_REQUEST['folderid']; 


Does the job for now.

[Marco van Herwaarden]

Then at least make that:

PHP Code:

$folderid = intval($_REQUEST['folderid']); 


[Dream]

Originally Posted by ManagerJosh

or you could take a look at the hack yourself

I'm trying to port one of Scott's other hacks..

what does this one do that mine doesnt?

[Logikos]

Opps, good point Marco, Thanks for that

[ManagerJosh]

Originally Posted by MarcoH64

Then at least make that:

PHP Code:

$folderid = intval($_REQUEST['folderid']); 


Okay, dealing with a small bug here....it appears to be only listing the number of PMs in the folder

ie: # (#) rather than Inbox (#)

[Logikos]

The inbox is also considered a folder.