max usersonline

[DeadGaze]

hey someone can help me to see if my code is wrong
because everyday the max users is changing but a day before there was more users online

Currently Active Users: 1 (1 members and 0 guests)
Most users ever online was 1, Today at 10:27 PM.

here is my code
thanxs

PHP Code:

// ### LOGGED IN USERS #################################################
$activeusers = '';
if ($vboptions['displayloggedin'])
{
    $datecut = TIMENOW - $vboptions['cookietimeout'];
    $numbervisible = 0;
    $numberregistered = 0;
    $numberguest = 0;

    $forumusers = $DB_site->query("
        SELECT
            user.username, (user.options & $_USEROPTIONS[invisible]) AS invisible, user.usergroupid,
            session.userid, session.inforum, session.lastactivity,
            IF(displaygroupid=0, user.usergroupid, displaygroupid) AS displaygroupid
        FROM " . TABLE_PREFIX . "session AS session
        LEFT JOIN " . TABLE_PREFIX . "user AS user ON(user.userid = session.userid)
        WHERE session.lastactivity > $datecut
        " . iif($vboptions['displayloggedin'] == 1, "ORDER BY username ASC") . "
    ");

    if ($bbuserinfo['userid'])
    {
        // fakes the user being online for an initial page view of index.php
        $bbuserinfo['joingroupid'] = iif($bbuserinfo['displaygroupid'], $bbuserinfo['displaygroupid'], $bbuserinfo['usergroupid']);
        $userinfos = array
        (
            $bbuserinfo['userid'] => array
            (
                'userid' => $bbuserinfo['userid'],
                'username' => $bbuserinfo['username'],
                'invisible' => $bbuserinfo['invisible'],
                'inforum' => 0,
                'lastactivity' => TIMENOW,
                'usergroupid' => $bbuserinfo['usergroupid'],
                'displaygroupid' => $bbuserinfo['displaygroupid'],
            )
        );
    }
    else
    {
        $userinfos = array();
    }
    $inforum = array();

    while ($loggedin = $DB_site->fetch_array($forumusers))
    {
        $userid = $loggedin['userid'];
        if (!$userid)
        {    // Guest
            $numberguest++;
            $inforum["$loggedin[inforum]"]++;
        }
        else if (empty($userinfos["$userid"]) OR ($userinfos["$userid"]['lastactivity'] < $loggedin['lastactivity']))
        {
            $userinfos["$userid"] = $loggedin;
        }
    }

    foreach($userinfos AS $userid => $loggedin)
    {
        $numberregistered++;
        if ($userid != $bbuserinfo['userid'])
        {
            $inforum["$loggedin[inforum]"]++;
        }
        $loggedin['musername'] = fetch_musername($loggedin);

        if (fetch_online_status($loggedin))
        {
            $numbervisible++;
            eval('$activeusers .= ", ' . fetch_template('forumhome_loggedinuser') . '";');
        }
    }

    // memory saving
    unset($userinfos, $loggedin);

    $activeusers = substr($activeusers , 2); // get rid of initial comma

    $DB_site->free_result($loggedins);

    $totalonline = $numberregistered + $numberguest;
    $numberinvisible = $numberregistered - $numbervisible;

    // ### MAX LOGGEDIN USERS ################################
    $maxusers = unserialize($datastore['maxloggedin']);
    if (intval($maxusers['maxonline']) <= $totalonline)
    {
        $maxusers['maxonline'] = $totalonline;
        $maxusers['maxonlinedate'] = TIMENOW;
        build_datastore('maxloggedin', serialize($maxusers));
    }

    $recordusers = $maxusers['maxonline'];
    $recorddate = vbdate($vboptions['dateformat'], $maxusers['maxonlinedate'], true);
    $recordtime = vbdate($vboptions['timeformat'], $maxusers['maxonlinedate']);

    $show['loggedinusers'] = true;
}
else
{
    $show['loggedinusers'] = false;
} 


thanxs

[Paul M]

Have you hacked it at all ?

[DeadGaze]

hmm no the code of online users is still the same as i started it

hmm maybe iam not sure
i have installed a who was online today an that code also seems to be screwed up
also not working most users ever online

[Paul M]

Perhaps you should restore index.php to it's original 3.0.7 supplied state and start again.