vb3 Journal hack (Yes, I'm working on it)

[FleaBag]

Originally Posted by spence2

I'd rant some more, but I've gotta get outside and take the tires off my car, because after all, I don't think Goodyear invented the wheel!

I hear you loud and clear mate.

[Wonko of Shinra]

Originally Posted by spence2

You know...between the endless betas of vB3 and the disarray about permissions over mods, IPB is looking better everyday!

And, I don't give a rat's behind which sycophant jumps in to defend vB...I'm annoyed, frustrated and I'm sure as hell not the only one!

As suggested in another post to me, I PM'd the original "owner" of this mod about his/her intentions to port this to vB3. "Yes," they replied, "but it won't be me doing it, it will be ______." So, I kept checking back for progress...and nothing, nada, zilch!

Since the code for the original mod is now obsolete for vB3 that means coding changes had to be made. At what point...and in whose judgment enough changes are ever made to designate it an original mod, I don't know. I'm not in favor, of course, of not giving credit where it is due, but isn't "credit" enough?

If someone does not "grant permission" for others...ever...which, I am assuming is their "right" (no matter how much the original code must be altered)...then I suppose some mods will not only never get ported to vB3...they will never get ported to 4, 5 or 6!

I'd rant some more, but I've gotta get outside and take the tires off my car, because after all, I don't think Goodyear invented the wheel!

I'm with you on this, it's pointless. I've hacked up that code so much. he had incomplete ideas, it was really a rough hack at the time and not designed for extensive use. I've made it so it's actually usable.

And of course, there's no license on these files, so I'm going to have to assume that it's protected by the GNU/GPL. If not, well fnord.

you now have 3 options if you want to run a journal on your forum.

A. you can wait for Kura Fire to release his version
B. you have to wait until whoever created the original hack to respond to my email.
C. wait for me to totally redesign it so I can take his name off of it.

[Reeve of shinra]

I understand that a lot of people would be ticked if some script kiddie with tons of free time came in, changed a line of code, then re-released a hack taking all the credit. Hell, I would be pissed too. If that's the reason for the rule, then lets add something where those folks can be given the credit they rightfully deserve.

There are tons of add-on's that don't come as standard with vbulletin 3 and as such alot of existing hacks will need to be updated. Alot of us (none of us?) are running our forums for profit - we have jobs, we have lives, we have tons of things that need to be done. Its a dis-service to OUR community here at vbulletin.org to not allow us to build off of each others work. If we port a hack (adding onto it no less), then why should everyone else have to waste thier valuable time trying to re-create the wheel? It isn't a popularity contest, at least it shouldn't be....

[spence2]

I think we are all agreed about protecting the rights of the hackers (bless 'em!).

The flaw is in the process in place here. Obviously, there are fundamental and complex changes in the coding from vB2 to vB3. Most hacks will not "port" without extensive re-designing. This being the case, there should be a standardized method for the vB2 hackers to grant or deny permission.

Would anyone else agree that a reasonable time period could be established for the "owners" of vB2 hacks to announce their intentions via this forum? Emails change. PM's assume the person still lingers. And, obviously, there are some people who are intensely interested in one piece of software for a limited amount of time...hack it...move on and honestly couldn't "give a rip!"

If we assume that a forum announcement could be posted in this community, then those who respond that they wish to port their own hacks could have those hacks placed in the Beta section. That way, everyone would know.

Those who failed to respond would remain the owners of their vB2 hacks. But, having been given fair notice and adequate time to respond, I think a logical conclusion would be that they are disinterested. And so, those hacks could then be opened for collaborative efforts. A standardized way of creditiing the original coder would not be that hard to implement.

All it takes is a little organization here to standardize and expedite the process in a fair manner to all.

I'm sure others could come up with a better system than what I have proposed...but, any system would be better than the current "no system at all."

[FleaBag]

I hear what you're saying and I think it's a great idea. But as you say, implementation is the key. This stuff does happen, and nobody is being blamed - but I can understand the upset here, especially from an admin such as myself. I was thrilled to see the hack here today, went to get some breakfast with the intention of returning to get it running at my site only to find it had been removed. I hope something can be worked out here, as I think everyone will benefit.

[JamesFrost]

Originally Posted by assassingod

It was removed because the original author didn't give permission for the hack to be ported.

Surely a 'modification of a mod' is allowed if released separately? For example, find code X, and replace with code Y (in the same way that we modify vbulletin, not by releasing new vb files)?

If the journal mod is currently based on the old journal hack, could it not be released as a 'change file'?

I think this is a hack that will beneifit a lot of people and it is sad to see it not being released.

I'm interested to know - did the original auther refuse to give permission, or has he just not bothered to reply?

[Reeve of shinra]

I sent an email to the address the author has listed on his main page and haven't heard back from him as of yet.

[Wonko of Shinra]

I've done a whole lot more to this hack than just, make it work with vb3
I've added Page support for both the comment (threaded system), as well as the entries.Which I'd like to point out, he had some code in there commented out that he wanted to use to expand upon his hack, but I never used that code.
I've added a goto system for the entries.
I've added bbcode parsing support (still ironing out some weird bugs).
I've made a journal buddy system.
I've added a quoting system for the comments that way you can reply to other people's comments.
I've added a titles for the comment threaded system that way you know what they're replying too.
I've made it backwards compatible with the old system so Kura Fire's hack will be able to upgrade from it.
I've changed his usage of the timestamp for the journal table in order to show the last time somebody made an entry, so after 4 weeks the user drops off the grand list not to make it overly huge and cumbersome.
I've had the templates totally reworked.
I've made it vb3 complient.
I've fixed all of his bugs (I hope by now).
I'm going to make the option to modify the post times of the entries, that way if you wanted it to line up with another existing journal, or port it from somewhere else, you can
I'm going to make the journal buddy system into something much more than it is currently.
I'm going to be added the ability to use attachments public and private on there, which will require you to have the PM attachment hack installed.

And magically he doesn't respond to our email, so all this work is for not?
Now I have to change this code by reworking it to my style of code that way I get all the credit? this is highly counter productive for an open source community.
I don't even care about the credit.

Reeve originally told me that many people wanted to have a journal hack for the VB3 system, and I'd already upgraded mine to vb3, so I thought I'd goto the effort to share what I've done.

I understand the implications this brings, but I'm glad I did this, because with VB3 soon to be released, and having no way to intergrate the older hacks, because of the fact the coders hacks which they originally wrote for vb2 is protected until consent given, and if that coder isn't around anymore, it slows us down. This is going to make this community lose it's edge of why vBulletin was the best, which was teamwork.

[spence2]

I started a thread addressed to the Admins regarding some of the issues discussed here.

https://vborg.vbsupport.ru/showthread.php?t=62110

Please help me get their attention by contributing you thoughts if you wish.
Thanks!

[Wonko of Shinra]

Spence2: I appreciate your concern, I'll voice my opinion when I have time tomorrow.