Help with a query!

[N9ne]

Query: SELECT usergroupid FROM user WHERE userid=1
Time before: 0.49647402763367
Time after: 0.49692595005035

EEK!

This SELECT usergroupid FROM user WHERE userid=1 query shows up on full page of a thread on showthread about 12 times!

I have 42 queries on the page, and I knew something was wrong, just haven't had time to check for a while, just did and it's this thing...maybe looping?

How could I solve this?

[NTLDR]

Check the buildpostbit function in admin/functions.php and see if you have any queries in the function.

[Xenon]

the function is called getpostbit

and yes, there shouldn't be a query in this function, because it will add an extra query PER POST.

if you need the usergroupid because of a hack, you should use a JOIN query in showthread instead..

[NTLDR]

I was thinking of the comment thats above it I guess thats what it used to be called.

[N9ne]

I just looked in the whole postbit part of functions.php and found no query that could be causing this...

Could you maybe give me ideas as to what the query is? How I could locate it?

And do all queries have DB_site before them?

[NTLDR]

It would either be in the postbit function in admin/functions.php or in showthread.php (do you get this query lots of times on other pages?)

It would look something like:

PHP Code:

$DB_site->query_first("SELECT usergroupid FROM user WHERE userid=$bbuserinfo[usergroupid]"); 


Perhaps something in global.php or the phpinclude template contains this in a loop? (If its on pages other than showthread too).

[N9ne]

It's not on forumhome or forumdisplay for sure, and I don't think it's anywhere else, I mean it appears around 10 times on showthread! It can't be on forumhome as forumhome is only 22 queries, and forumdisplay is only 25 (gotta optimize this actually)...

I'll have to look again for the query.

[N9ne]

PHP Code:


  if ($usergroupid==-1 or $usergroupid==0) {
    if ($userid==0) {
      $usergroupid=1;
    } else {
      if (isset($usercache["$userid"])) {
        $usergroupid=$usercache["$userid"]['usergroupid'];
      } else {
        $getuser=$DB_site->query_first("SELECT usergroupid FROM user WHERE userid=$userid");
        $usergroupid=$getuser['usergroupid'];
      }
    }
  } 


That's in functions.php, in the getpermissions part, it's the only part where there is a SELECT usergroupid query..

[NTLDR]

Thats probably supposed to be there, is the query on all showthread pages? If not is it threads in private forums or forums with specific usergroup permissions?

[NTLDR]

Yep, thats definatly suposed to be there. Do you have anything like:

PHP Code:

$permissions=getpermissions($forumid); 


In the getpostbit function? It may be repeatedly querying your permissions.