Code Optimisation - Anyone got anything that can optimise your vB files?

[Tigga]

Why the attitude? All I was trying to do was help you out. Why don't you post on vbulletin.com and ask their opinion? I'm sure if you're right they would want to know anyways since that could be considered a small error in the coding.
You're right... The code is displayed many times in the files, but how often is the no permission page actually displayed? If you go through and put that in every file, it is going to be calling the error_nopermission template from the database every time you load a page, which isn't necessary since 98% of the time your users won't be getting that page.

[Chris M]

There wasnt an attitude, I just remember being told that that saves a few queries...

I get about as many guests on at one time as users, so it helps

Well I did alot of adding templates that werent added to "$templatesused", and i reduced alot of queries...

Satan

[Tigga]

Whether it's there or not, I don't see it making that much of a difference. Save a query here, pull an unnecessary template there. It's a double-edge sword.
I should probably look through my files as well... I'm sure I missed a template or two when I was adding hacks many months ago and didn't know much about what I was doing.

[Chris M]

Indeed...

I found that quite a few hacks didnt have the templates in the $templatesused...

I posted a Site Feedback message a few mins ago asking that something be added to the rules about adding templates to the $templatesused if your hack requires new templates

Satan

[Tigga]

Hehe... I searched through my board and amazingly I only found one hack that needed the templates added (an IRC chat hack). I'm kinda surprised I didn't find more.
Good idea for the post in the feedback forum too.

[Brad]

Satan, plur's right. Adding templates that are barley used to the $templatesused can slow down preformance, it is a doubled edged sword .

[Chris M]

Yup...For most people maybe

But with the amount of guests I get, and Users (that do post) who try and do things they cant, its worth it

Satan

[NTLDR]

Removing the forum jump code aslo saves you at least 1 query if you don't use it

[Erwin]

For example, with vBPortal, the templates are not added to the $templateused by default - and they have many custom templates - imagine the waste in querying the database when they could all be cached. (Actually, the vBPortal code tries to include them, but it is written wrongly, and are not included).

[Dean C]

Erwin:

Is this the old PM code?

PHP Code:

$allpm=$DB_site->query_first("SELECT COUNT(*) AS messages FROM privatemessage WHERE userid=$bbuserinfo[userid] $ignoreusers");
  $newpm=$DB_site->query_first("SELECT COUNT(*) AS messages FROM privatemessage WHERE userid=$bbuserinfo[userid] AND dateline>$bbuserinfo[lastvisit] AND folderid=0 $ignoreusers");
  $unreadpm=$DB_site->query_first("SELECT COUNT(*) AS messages FROM privatemessage WHERE userid=$bbuserinfo[userid] AND messageread=0 AND folderid=0 $ignoreusers"); 


- miSt