Go Back   vb.org Archive > vBulletin 4 Discussion > vB4 General Discussions
  #1  
Old 02-21-2017, 12:22 AM
Bill Stuntz Bill Stuntz is offline
 
Join Date: Feb 2015
Location: Columbus, OH
Posts: 55
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Reply to Thread APPEARS to respond to the last poster, NOT the thread as a whole

This is the "Thread" people are responding to, created by me.

If, say, MarkFL replies to me, and another poster does a "Reply to Thread" maybe something like "That's a stupid idea." after Mark's post, THAT critical/insulting post will APPEAR to be directed at MARK, (RE:MarkFL), not to the thread as a whole, or to ME (which is MUCH more likely! ). It's misleading, and occasionally causes confusion and/or arguments due to the misunderstanding about WHOSE post is being responded to.

Is there a way to FIX this? Maybe by suppressing the (RE:...) in the header of a "Reply to Thread" since it may not be a response to ANY particular poster? It ACTS like "Reply to LAST POST" not "Reply to Thread"

We're running 4.2.2, preparing to go to 4.2.3
Attached Images
File Type: png misleading.png (74.8 KB, 0 views)
Reply With Quote
Благодарность от:
chloe101
  #2  
Old 02-21-2017, 01:43 AM
Paul M's Avatar
Paul M Paul M is offline
 
Join Date: Sep 2004
Location: Nottingham, UK
Posts: 23,748
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thats not part of standard vB, its a modification of some sort.
Reply With Quote
  #3  
Old 02-21-2017, 01:59 AM
Bill Stuntz Bill Stuntz is offline
 
Join Date: Feb 2015
Location: Columbus, OH
Posts: 55
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thank you. I wasn't aware of that. I've had nothing to do with actually setting up the system, so I don't know what's native, and what's a mod. I guess I need to look into the mods to try to find out which one is doing it.
Reply With Quote
  #4  
Old 02-23-2017, 03:52 AM
Bill Stuntz Bill Stuntz is offline
 
Join Date: Feb 2015
Location: Columbus, OH
Posts: 55
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I've found the plugin, but I don't know where it came from. It works properly when replying to a specific post by using the correct non-zero parentid, but "Reply to Thread" seems to pick an inappropriate parentid. The first post's parentid=0 so no link is shown in the first post's title.

I'm just guessing here: If it set the parentid to 0 instead of the incorrect postid that it picks now when invoked by "Reply to Thread" it shouldn't display ANY link in that new post title - which is what I want. I see too many "What's he shouting at ME for? Somebody ELSE said that!" complaints when somebody does a "Reply to Thread" that unintentionally points to the wrong post. It shouldn't point to ANY post instead of pointing to a wrong one.

Trouble is, I can't FIND "Reply to Thread" or "Reply" [to post] to figure out exactly how they work, and hopefully inhibit the incorrect link for a "Reply to Thread" while allowing the correct links to display when they're responding to a specific post.

P.S. The link is actually displayed in the post title by the following lines in a modified postbit_legacy:
Quote:
<vb:if condition="$post['parentid'] AND $post['parentusername']">
(RE: <a href="{vb:link thread, {vb:raw thread}, {vb:raw pageinfo_post}}#post{vb:raw post.parentid}">{vb:raw post.parentusername}</a>)
</vb:if>
If parentid=0, the condition fails, and no link is displayed.
Attached Images
File Type: png ShowPostReference.png (16.5 KB, 0 views)
Reply With Quote
  #5  
Old 02-23-2017, 08:10 PM
Lynne's Avatar
Lynne Lynne is offline
 
Join Date: Sep 2004
Location: California/Idaho
Posts: 41,180
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I would suggest seeing if that modification is uploaded here and then go read the thread to see if this issue has been brought up before.
Reply With Quote
  #6  
Old 02-23-2017, 09:42 PM
Bill Stuntz Bill Stuntz is offline
 
Join Date: Feb 2015
Location: Columbus, OH
Posts: 55
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

As I'm sure you can tell, I'm new at trying to mess with the guts of our forum.
I haven't done any real programming since pre-GUI CP/M & DOS3 days, but I think I remember enough to track this down & fix it - if I can find the code.

If there's anything about the plugin on the MB, I haven't been able to find it. My previous post shows the plugin itself, and the attachment in this post shows where I clicked to show the plugin. I don't see anything to indicate where it came from, when, or why. All I see is the code itself, that it's enabled, and that the section it's in is "Product : vBulletin"

Maybe I'm just being dumb, but I haven't figured out where the code for "Reply to Thread" vs "Reply" vs "Reply with Quote" lives - I can't even find where/how the buttons & their actions are defined. I've identified the plugin, and figured out how it causes the references to be displayed in the thread title by postbit_legacy, but unless I can figure out what calls them, and when, I'm stuck.

If I could find out what code runs when "Reply to Thread" is pressed vs "Reply" etc. I might be able to follow the code and inhibit the reference link when "Reply to Thread" is invoked by zero-ing out either parentid or parentusername.

Where are the buttons & their actions defined? If I can find THAT, I hope I'll see a trail of breadcrumbs that might lead me toward a solution.
Attached Images
File Type: jpg plugin system.jpg (21.9 KB, 0 views)
Reply With Quote
  #7  
Old 02-26-2017, 08:22 PM
tommythejoat's Avatar
tommythejoat tommythejoat is offline
 
Join Date: Apr 2008
Location: Boston
Posts: 155
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

This thread should probably be merged with mine on "is the thread structure broken." They are really the same topic that is troubling our NAWCC Message Board.

The feature Bill is describing is an add on which I found here, but in a discussion, not a formal add on since it only required one very small plugin. I have not been able to find the thread where I originally found it a few years ago.

However, I think the thread structure is broken in the sense that reply to post and reply to thread do not function logically.

Any message board that support threaded or hybrid thread viewing will demonstrate the behavior. The post graph for any thread will show a cascade of reply posts instead of references back to the first post when the user click on reply to thread.

The developer may have thought they were doing it the right way, but back in the old days of threaded message boards, it was clearly understood that subtopics of a thread would display in an alternate branch while responses to the main topic would reference it in the graph.

This board only supports linear view, so it is not possible to show the problem clearly here.
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 01:46 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.10897 seconds
  • Memory Usage 2,250KB
  • Queries Executed 14 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (7)post_thanks_box
  • (1)post_thanks_box_bit
  • (7)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit
  • (7)post_thanks_postbit_info
  • (7)postbit
  • (3)postbit_attachment
  • (7)postbit_onlinestatus
  • (7)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_attachment
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete