Unregistered user post

[DemOnstar]

Could someone tell me if this is a bug?

As an admin, I am unable to edit the post of a guest.
All permissions have been made but still not able. . .

Thanks. . .

[BugOutGirl]

It's been going on a long time and I am getting quite frustrated with it.

Here is the bug report: http://tracker.vbulletin.com/browse/VBV-12765

I don't get the feeling they are doing anything about it, anytime soon.

--------------- Added [DATE]1455227399[/DATE] at [TIME]1455227399[/TIME] ---------------

Oh, and please be sure to vote as well for this issue! http://tracker.vbulletin.com/browse/VBV-12765

[Replicant]

Originally Posted by DemOnstar

Could someone tell me if this is a bug?

As an admin, I am unable to edit the post of a guest.
All permissions have been made but still not able. . .

Thanks. . .

I edited node.php per the post in the JIRA and it works.

The file:
/core/vb/api/node.php

From the JIRA posted by Igor Arkadia

The file:
/core/vb/api/node.php

The method:
getCreatepermissionsForEdit()

You check there if nodeid, channelid, userid etc are not defined and do "return array('createpermissions' => false);" if it's like this. The problem is how you do it:

if ... OR empty($node['userid']) OR ...

Posts of guests have userid = 0, the function empty() in PHP returns true if its argument is equal to 0. I agree it could be unexpected behavior of the function but it is how it works.
I guess it could be patched changing this code to something like:

... OR (empty($node['userid']) && ($node['userid'] != 0)) OR ...

This guy already seems to have found the issue, it just hasn't been fixed yet.

Whether or not it has unexpected results is yet to be discovered.

[DemOnstar]

Originally Posted by BugOutGirl

It's been going on a long time and I am getting quite frustrated with it.

Here is the bug report: http://tracker.vbulletin.com/browse/VBV-12765

I don't get the feeling they are doing anything about it, anytime soon.

Now this is typical. This is what pisses me off.
A user provides a solution and nobody does anything about it for months on end. . .
There are many problems with un-registered and not logged on users.

1. Permissions don't work.
2. Attachments don't show up in quotes.
3. The option to change title from 'Guest' doesn't work.
4. When a guest makes a post, there is no acknowledgement shown. The screen just goes to the page not showing the post that has just been made. .

When one relies on unregistered or not logged on guests, it renders the site useless basically.
And then it becomes a recorded bug which lies there forever. . .

Originally Posted by Replicant

This guy already seems to have found the issue, it just hasn't been fixed yet.

As above . . .

By the way. . .

Originally Posted by Replicant

There is on the other hand a way to do it via SQL queries. I know you like to tinker, so if you want to investigate that, I'll point you in the right direction.

https://vborg.vbsupport.ru/showpost....95&postcount=4

Cheers. . .

--------------- Added [DATE]1455274599[/DATE] at [TIME]1455274599[/TIME] ---------------

Originally Posted by Replicant

I edited node.php per the post in the JIRA and it works.

The file:
/core/vb/api/node.php

From the JIRA posted by Igor Arkadia

The file:
/core/vb/api/node.php

The method:
getCreatepermissionsForEdit()

You check there if nodeid, channelid, userid etc are not defined and do "return array('createpermissions' => false);" if it's like this. The problem is how you do it:

if ... OR empty($node['userid']) OR ...

Posts of guests have userid = 0, the function empty() in PHP returns true if its argument is equal to 0. I agree it could be unexpected behavior of the function but it is how it works.
I guess it could be patched changing this code to something like:

... OR (empty($node['userid']) && ($node['userid'] != 0)) OR ...

This guy already seems to have found the issue, it just hasn't been fixed yet.

Whether or not it has unexpected results is yet to be discovered.

I have looked at node.php but as usual, can't make head nor tail of it. . .

	// This function is only meant to be called from the createcontent controller's actionLoadEditor()
		// It's not meant to be very versatile.
		if (!is_array($node)
			OR empty($node['nodeid']) OR empty($node['starter'])
			OR empty($node['channelid']) OR empty($node['userid'])
			OR empty($node['contenttypeid'])
		)
		{
			return array('createpermissions' => false);
		}

		// if the user can't edit this node, then we're out.
		if (!vB_Library_Content::getContentLib($node['contenttypeid'])->getCanEdit($node))
		{
			return array('createpermissions' => false);
		}

Should something be changed in this area?

[Replicant]

Change this line,

OR empty($node['channelid']) OR empty($node['userid'])

to,

OR empty($node['channelid']) OR (empty($node['userid']) && ($node['userid'] != 0))

[DemOnstar]

Originally Posted by Replicant

Change this line,

OR empty($node['channelid']) OR empty($node['userid'])

to,

OR empty($node['channelid']) OR (empty($node['userid']) && ($node['userid'] != 0))

Ah, okay . . .Thanks. .
Very good for all concerned. . . .:up:

[BugOutGirl]

Originally Posted by Replicant

I edited node.php per the post in the JIRA and it works.

The file:
/core/vb/api/node.php

From the JIRA posted by Igor Arkadia

The file:
/core/vb/api/node.php

The method:
getCreatepermissionsForEdit()

You check there if nodeid, channelid, userid etc are not defined and do "return array('createpermissions' => false);" if it's like this. The problem is how you do it:

if ... OR empty($node['userid']) OR ...

Posts of guests have userid = 0, the function empty() in PHP returns true if its argument is equal to 0. I agree it could be unexpected behavior of the function but it is how it works.
I guess it could be patched changing this code to something like:

... OR (empty($node['userid']) && ($node['userid'] != 0)) OR ...

This guy already seems to have found the issue, it just hasn't been fixed yet.

Whether or not it has unexpected results is yet to be discovered.

Thank you. I saw your post at .com as well.

Working in the code makes my head spin. I'll play around with this later.

Thanks again!

[Replicant]

This change will not survive an upgrade. It will have to be reapplied every upgrade until they fix it.

[DemOnstar]

Originally Posted by Replicant

This change will not survive an upgrade. It will have to be reapplied every upgrade until they fix it.

Great system they have going there . . .

Thanks for the reminder . . .