Bug when quoting members with "[" or "]" in their nicknames

[chefy]

We will use for this example a random member: [Dx]. So imagine that you're quoting a post from [Dx] then the quote code should look like this:

PHP Code:

[QUOTE=[Dx];123456]something posted by [Dx][/QUOTE] 


However it's being parsed as this:



Breaking the quote tag.

Please fix this at vB.org and also share with us the instructions so we all the users of vB 3.x will be able to apply the fix in our own forums.

[chefy]

I can confirm that this bug is also present in vB 4.2

[Ziki]

Nice catch

Also install quote notifications on vb.org!

[Paul M]

The fix is not to allow [ or ] in usernames.

Its bound to clash with any BB code, not just quote, and would be very difficult to do anything about.

[Simon Lloyd]

If you must allow daft characters in the usernames you'll have to work out a way of encapsulating it in [noparse]

[DivisionByZero]

i got sick of names like |< () R |\| and other crap a LONG time ago and disabled all but letters, numbers, underscores and dashes.

[Sarteck]

I don't think it's too unreasonable to consider utilizing a method where square brackets would be acceptable in a BB Code's option, myself.

For example, enclosing the option in quotes or double-quotes to represent literal brackets rather than to-be-parsed brackets.

[QUOTE="[Sarteck]"]Lorem Ispum[/QUOTE]

This actually works, btw, already, when quote does not have a second parameter delimited by a semi-colon.

Originally Posted by [Sarteck]

Lorem Ispum

The problem only exists when the second parameter exists. E.G.



[QUOTE="[Paul M]";2353120]The fix is not to allow [ or ] in usernames.[/QUOTE][/noparse][/B]

yields
[QUOTE="[Paul M]";2353120]The fix is not to allow [ or ] in usernames.[/QUOTE]






[/QUOTE][/QUOTE][/QUOTE]Anyways, to sum it up.... I disagree with the statement that the "fix" is to not allow brackets in usernames. I think the "fix" would be to fix the problem. ;)




[SIZE=1][COLOR="Silver"]--------------- Added [DATE]1343906114[/DATE] at [TIME]1343906114[/TIME] ---------------[/COLOR][/SIZE]





[QUOTE=Sarteck;2353596]My Rambling[/QUOTE]

Ah. Seems that if the [B]entire option[/B] is enclosed with quotes, everything goes smoothly.

E.G.:
[B][noparse][QUOTE="[Sarteck];2353596"]My Rambling[/QUOTE]

Originally Posted by [Sarteck]

My Rambling

:3


So, just have the Quote thingamabob enclose the stuff in quotes, yeah?

--------------- Added [DATE]1343910448[/DATE] at [TIME]1343910448[/TIME] ---------------

---------------

Aaaaaand, problem solved on vB4 if you change the newpost_quote template.

[QUOTE={vb:raw originalposter}]{vb:raw pagetext}[/QUOTE]

to

[QUOTE="{vb:raw originalposter}"]{vb:raw pagetext}[/QUOTE]

I don't know if vB3 (for vB.org) would have the same solution or not.

[Paul M]

vb.org doesnt allow such usernames, so its not an issue.

[chefy]

But could you share a fix like the one posted by Starteck for vB 3.8 users please?

[BirdOPrey5]

vBulletin 3.x has a newpost_quote template too.

You could try changing it from:

[QUOTE=$originalposter]{$pagetext}[/QUOTE]

to

[QUOTE="{$originalposter}"]{$pagetext}[/QUOTE]

No idea if it will work.

I agree with Paul the better option is not to allow such usernames- unable to predict what else they may break in the future.