The Arcive of Official vBulletin Modifications Site.It is not a VB3 engine, just a parsed copy! |
|
#41
|
|||
|
|||
Yes I saw that unsubscribe auth link while going through the phrases for email body text. I also saw a couple of links that led to the usercp being used as unsubscribe links.
Either way, what you've done works awesome as far as my host is concerned, and I've already gone though all of the email body text phrases adding the link to your mod and removing any others I found. I suppose I could have done it the other way around, but I didn't look at what the unsubscribe links did and felt my way was just ... easier No problem at all with the release not being tonight I'll do some more sleuthing when it cools off here in regards to the smilie page issue and get back to you. --------------- Added [DATE]1342060732[/DATE] at [TIME]1342060732[/TIME] --------------- Ok the message that pops up is - could not find phrase unsubscrib_done and then sends me to the index page You are correct, turning off "receive admin emails" does not stop thread subscriptions (and I'm going to assume group and others as well), and I think I figured that out yesterday which is why I added the condition to set thread subscriptions to "do no subscribe". I figured doing that and adding the unsubscribe link would be enough to cover my butt ... and the host agrees. In fact they wonder why I bothered adding all of that other stuff ... but screw them they suck |
#42
|
|||
|
|||
You should post this as a plugin once all bugs are worked out
|
#43
|
|||
|
|||
I believe he (Kevin) intends to do just that
--------------- Added [DATE]1342065400[/DATE] at [TIME]1342065400[/TIME] --------------- I figured out why this was happening. During my sleep deprived state last night comparing the new version and the old version I accidentally copied over a snipet of code from the old version and imported the contaminated version to my live site Once I removed the code everyone works properly now |
#44
|
|||
|
|||
OK, I'm glad you got the error message worked out. Sounds like you've pretty much got yourself straightened out. As fo rthe thread subscription unsubscribe links, I had a look and it's actually pretty much the same thing we're doing. The auth code is a hash of the user id and subscription id, and it's used to unsubscribe without needing to log in, the same as we're using the email address. I think in general it might still be useful to expand the page on our mod to let the user choose what they want to unsubscribe from, and have an "I don't want any more email" box.
When you said your host "wonders why you bothered adding all of that other stuff", what do you mean exactly - that you added another unsubscribe link to the subscription emails? In any case, do you need anything else? If you're all set with your host I'll just take my time (...and probably never get it released ). |
#45
|
||||
|
||||
That would be a crying shame as that should be built in to vb!
|
#46
|
|||
|
|||
Yeah, I was just joking because that's happened to me with a few other mods - that I have them virtually complete then never actually get around to releasing them. I'll make sure I get this one done.
|
#47
|
|||
|
|||
I want to run a couple of tests today with regards to the thread subscriptions. Mainly I want to know if setting the default to 'do not subscribe' will prevent existing subscriptions from sending emails. If it does not, then I'd test to see if setting the default to 'control panel' stops sending emails for existing subscriptions. That way we don't have to delete existing subscriptions I'll actually be doing that after this post
If either one of those works, then you do not need to incorporate anything different as I have already done so in the modified version of the old mod. In regards to the host, I told them exactly what I tweaked the old mod to do (ie turn off pms, turn off vcard, deselect the 3 email settings, and change the thread description. Personally I'd rather do all of that vs just the 'receive admin emails'. --------------- Added [DATE]1342113466[/DATE] at [TIME]1342113466[/TIME] --------------- Ok simply changing the default subscription mode does not prevent emails from being sent on existing subscriptions If you would be so kind as to include the ability to unsubscribe from existing subscriptions that would be awesome. Personally I don't have the blog system on, but I'm sure others do, and I can wait until you get it all sorted out since my host turned on my emails |
#48
|
|||
|
|||
Quote:
|
#49
|
|||
|
|||
I guess you read my first reply but missed the second before logging off Changing the option does not affect existing subscriptions. I absolutely love the idea of setting the existing subscriptions to "do not subscribe" instead of unsubscribing them. That is awesome!
So are you done yet? ;p ;p --------------- Added [DATE]1342115148[/DATE] at [TIME]1342115148[/TIME] --------------- I have finished placing the unsubscribe link in all of the email body text phrases. I haven't tested EVERY possible scenario but I feel confident enough that adding a couple of lines in each phrase will cover any outgoing email with the exception of the admin sending mass emails. I'll look into that a little later today. For those interested this is what I added to all of my "email body text" phrases. Quote:
|
#50
|
|||
|
|||
Quote:
I'm not done - I have to confess I haven't made any progress on it today, and I have to go out for a while this afternoon. Maybe tonight. Edit: ...and if you have any other changes you want me to look at and possibly include, go ahead and post them. |
Thread Tools | |
Display Modes | |
|
|
X vBulletin 3.8.12 by vBS Debug Information | |
---|---|
|
|
More Information | |
Template Usage:
Phrase Groups Available:
|
Included Files:
Hooks Called:
|