SQL synax problem

[killa seven]

PHP Code:

$vbulletin->db->query_write("CREATE TABLE IF NOT EXISTS ".TABLE_PREFIX."`dbh_victims` (
`id` INT( 4 ) NOT NULL AUTO_INCREMENT ,
`username` VARCHAR( 45 ) NOT NULL ,
`beat` VARCHAR( 45 ) NOT NULL ,
`cscore` INT( 1 ) NOT NULL DEFAULT '0' ,
`oscore` INT( 1 ) NOT NULL DEFAULT '0'
UNIQUE (
`id`
"); 


MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '(
'id'' at line 7
Error Number : 1064


im thinking that theres an extra comma some where near id

[Lynne]

look at your last three lines.... now tell me where the ending ") is for the first line.

[killa seven]

what do you mean ending? i put an ending parentheses at the end of ") but still no go

[Lynne]

Yeah, so where is the ending paren to the UNIQUE ( that you have?

[killa seven]

oh ok

PHP Code:

$vbulletin->db->query_write("CREATE TABLE IF NOT EXISTS ".TABLE_PREFIX."`dbhVictims` (
`id` INT( 4 ) NOT NULL AUTO_INCREMENT ,
`username` VARCHAR( 45 ) NOT NULL ,
`beat` VARCHAR( 45 ) NOT NULL ,
`cscore` INT( 1 ) NOT NULL DEFAULT '0' ,
`oscore` INT( 1 ) NOT NULL DEFAULT '0'
UNIQUE (`id`)
"); 


i put the paren after id no syntax errors but it isn't created in the database

[TigerC10]

You're still missing a closing parenthesis (from right after the dbhVictims), and you may also want to get rid of the ` symbol. In Perl the `operator performs a system command and PHP is supposed to be Perl embedded in HTML (but I'm unclear as to the status of the ` operator in PHP).

Try this instead...

PHP Code:

$vbulletin->db->query_write(
    "CREATE TABLE IF NOT EXISTS ".TABLE_PREFIX."dbhVictims (
        id       INT( 4 )      NOT NULL AUTO_INCREMENT,
        username VARCHAR( 45 ) NOT NULL,
        beat     VARCHAR( 45 ) NOT NULL,
        cscore   INT( 1 )      NOT NULL DEFAULT 0,
        oscore   INT( 1 )      NOT NULL DEFAULT 0,
        PRIMARY KEY(id)
    )"
); 


Doing it this way (with the staggered indents) makes errors more obvious to see in the future.

[killa seven]

yeagh i thought those tick marks looked weird...

edits..

its not going into the database for some reason

[TigerC10]

There's nothing wrong with the backticks in a MySQL command. I know of many .SQL files that use them. Using the ` operator can be confusing in Perl though. It's not required, so why put them in?

[killa seven]

yeagh... its still not going into the database tho

there is actually no syntax errors now its just not going in when i upload the product

[TigerC10]

Well it might have to do with the IF NOT EXISTS that you gave it. If you ran this code with the wrong syntax then it may have created an empty table. Then when you ran it a second time the empty table was there and it didn't issue the create statement again.

Whatever method you're using to view your database, you may be missing the table. Sometimes viewers sort based on the capital letters and the lower case letters. If it's a web-based viewer then you may need to close it down and open it again (browser cache could mess you up).