Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 General Discussions

Reply
 
Thread Tools Display Modes
  #1  
Old 02-13-2009, 05:10 AM
kpmedia's Avatar
kpmedia kpmedia is offline
 
Join Date: Jan 2008
Posts: 136
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default How to change FROM name on contact form e-mails?

Right now I get lengthy
  • "Thomas Q. Snuffleluffagus @ Your Whole Forum Name Here"

as the e-mail from name. I want the incoming form mails to look more like "normal" e-mails. I want it to simply be
  • "Thomas Q. Snuffleluffagus"

I've looked in code and vB admin panel options so long that I'm going cross-eyed. How can this be changed?
Reply With Quote
  #2  
Old 02-13-2009, 08:25 AM
Dismounted's Avatar
Dismounted Dismounted is offline
 
Join Date: Jun 2005
Location: Melbourne, Australia
Posts: 15,047
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Look at line 304 of sendmessage.php (vB 3.8.1):
PHP Code:
eval(fetch_email_phrases('contactus'$languageid)); 
Reply With Quote
  #3  
Old 02-13-2009, 03:50 PM
kpmedia's Avatar
kpmedia kpmedia is offline
 
Join Date: Jan 2008
Posts: 136
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thanks for that code piece. I looked at it, however I'm still not quite understanding.

'contactus' and $languageid appear to be variables of some kind. If I could see how they are created, I'm sure I could edit the text. I searched for both "contactus" and "languageid" in the "Search for Phrases" in the admin panel, as well as manually went through the list of phrases. I didn't see anything. Maybe that's not where these can be edited? I see nothing in the sendmail.php itself.

Previously, I tried to search for the @ symbol, I thought surely that would be easy to find. However, I appear to be wrong, I couldn't even find an @ symbol.

What part of this needs to be changed?
Code:
eval(fetch_email_phrases('contactus', $languageid));
Reply With Quote
  #4  
Old 02-13-2009, 04:30 PM
snakes1100 snakes1100 is offline
 
Join Date: Dec 2001
Location: Michigan
Posts: 3,733
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

It doesn't, you should modify the phrase.
Reply With Quote
  #5  
Old 02-13-2009, 05:44 PM
kpmedia's Avatar
kpmedia kpmedia is offline
 
Join Date: Jan 2008
Posts: 136
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I don't understand the PHP code usage here, so I don't have any idea how to modify it. Where is the code that says "use an @ symbol" between the e-mail name and the forum name? I don't see see anything that makes any kind of sense to anybody outside of the vB writers. That's why I'm posting here. I'm not dumb, I'm just not an advanced PHP writer/editor.

What is happening is "Name @ ForumName" on incoming e-mails. I don't want the "@ ForumName" part to be used, just the "Name" part as the From name on e-mails. Does this make sense?
Reply With Quote
  #6  
Old 02-14-2009, 11:31 AM
Dismounted's Avatar
Dismounted Dismounted is offline
 
Join Date: Jun 2005
Location: Melbourne, Australia
Posts: 15,047
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Look at the fetch_email_phrases() function in functions.php. It fetches two phrases, one for the subject, one for the body.
Reply With Quote
  #7  
Old 02-14-2009, 05:58 PM
kpmedia's Avatar
kpmedia kpmedia is offline
 
Join Date: Jan 2008
Posts: 136
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

this is the fetch_email_phrases() function in functions.php

PHP Code:
function fetch_email_phrases($email_phrase$languageid = -1$emailsub_phrase ''$varprefix '')
{
    if (empty(
$emailsub_phrase))
    {
        
$emailsub_phrase $email_phrase;
    }

    if (!
function_exists('fetch_phrase'))
    {
        require_once(
DIR '/includes/functions_misc.php');
    }

    return
        
'$' $varprefix 'message = "' fetch_phrase($email_phrase'emailbody''email_'trueiif($languageid >= 0true''), $languageidfalse) . '";' .
        
'$' $varprefix 'subject = "' fetch_phrase($emailsub_phrase'emailsubject''emailsubject_'trueiif($languageid >= 0true''), $languageidfalse) . '";';

That appears to be the subject line and the message body.
Where is the FROM name coming from? That's not part of the subject or the message body.

--------------- Added [DATE]1234641914[/DATE] at [TIME]1234641914[/TIME] ---------------

Just as a clarification for what I want to do:

Code:
Received: my.domain ([0.0.0.0]) by my.server with MailSoftware ESMTP
Date: Fri, 13 Feb 2009 06:49:33 +0000
To: forummail@domain.com
From: "Person's Name @ Forum Name" <person@hotmail.com>
Return-Path: <forummail@domain.com>
Message-ID: <20090213xxxxxxx.xxxxx-domain.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8bit
X-Priority: 3
X-Mailer: vBulletin Mail via PHP
Subject: Subject Name As Set in vB Admin Panel
That's the header (altered, of course) from an e-mail sent to myself from my forum.

I want to change this information:
From: "Person's Name @ Forum Name" <person@hotmail.com>

It should instead be
From: "Person's Name" <person@hotmail.com>

I can't find where this is being generated from within vB. There is nothing that says "$enteredname @-symbol $forumname" (variables made up, yes, just for purpose of my example of code)

I would have thought this as something simple to alter. Most of the PHP code I've seen so far is just jibber-jabber to me, there's nothing remotely related to the from-name that I can see.
Reply With Quote
  #8  
Old 02-14-2009, 06:08 PM
snakes1100 snakes1100 is offline
 
Join Date: Dec 2001
Location: Michigan
Posts: 3,733
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

change the PHRASE, i dont think we can express that in any other way, do NOT change the php coding.

admincp --> Languages & Phrases --> Phrase Manager --> click the button search in phrase
Reply With Quote
  #9  
Old 02-14-2009, 08:05 PM
kpmedia's Avatar
kpmedia kpmedia is offline
 
Join Date: Jan 2008
Posts: 136
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

As an ASP code writer, that doesn't even make sense to me. How can the user-supplied variable name (John Smith), combined with the system-supplied variable data (My Cool Nifty Forum Name), be stored as a static piece of data in the phrase manager?

Are you telling me that the FROM name -- the name a person types into the Contact Us form (sendmail.php) -- which is then combined with an "@", followed by the name of the forum -- is somehow stored in the phrase manager? This is neither in the subject, nor in the body of the message. It's the "from" name used in the e-mail header (and displayed as the from name in e-mail software or webmail).

If so, fine, I won't worry about figuring it out -- but please let me know where that location is. I'm not seeing which phrase needs to be edited, nor what syntax to edit.

I didn't write vBulletin, so I don't know how some of this thing operates. It's foreign technology to me. It's why I'm asking for help on the forum. I've been using it for less than a year now.

In the world of ASP, I'd be editing the ASP file, to change how the data is being used between the HTML form and the sent-to-SMTP e-mail.

--------------- Added [DATE]1234650059[/DATE] at [TIME]1234650059[/TIME] ---------------

Come to think of it ....

If you know the phrase that I need to change -- which it appears you do -- why am I being treated like an idiot, being told to "go search", instead of being given some friendly help? Would it be the end of the world to know WHICH PHRASE is the one that needs to be edited, maybe even what that new syntax should be?

Am I expected to get on my knees and bow down to the awesome knowledge of long-time vB users, like a medieval peasant looking for a bread scrap as well-to-do citizens of the kingdom travel by my hovel? Do egos have to be stroked first?

Seriously.
Reply With Quote
  #10  
Old 02-15-2009, 03:42 AM
Dismounted's Avatar
Dismounted Dismounted is offline
 
Join Date: Jun 2005
Location: Melbourne, Australia
Posts: 15,047
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by kpmedia View Post
As an ASP code writer, that doesn't even make sense to me. How can the user-supplied variable name (John Smith), combined with the system-supplied variable data (My Cool Nifty Forum Name), be stored as a static piece of data in the phrase manager?
It isn't. Think of the phrase as a piece of text with placeholders. As this phrase is fetched, the placeholders are replaced with the actual data. You need to edit the phrase and remove the appropriate placeholders.

Follow the breadcrumbs inside that function. You see that the subject is derived from a phrase with a prefix of "emailsubject_". The ending is $emailsub_phrase, which is $email_phrase in this specific case. Lastly, what is $email_phrase?
Quote:
Originally Posted by kpmedia View Post
Am I expected to get on my knees and bow down to the awesome knowledge of long-time vB users, like a medieval peasant looking for a bread scrap as well-to-do citizens of the kingdom travel by my hovel? Do egos have to be stroked first?
Am I expected to get on my knees and hand everything on a silver platter to the un-knowledgeable first-time vBulletin administrators, like a servant serving their king?

Seriously.

Look, the point is that if we gave everything to you as you asked for it, you wouldn't be learning anything, would you? If we can guide someone to the goal, they would take away with them the knowledge that, yes, they can do it themselves. In fact, all of us come here on fully voluntary grounds. Yes, even the staff are volunteers (except Marco, he is a Jelsoft employee).
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 03:06 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.04758 seconds
  • Memory Usage 2,272KB
  • Queries Executed 13 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (2)bbcode_code
  • (2)bbcode_php
  • (2)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (10)post_thanks_box
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (10)post_thanks_postbit_info
  • (10)postbit
  • (10)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete