Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 General Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #1  
Old 06-07-2009, 09:48 AM
ralle89 ralle89 is offline
 
Join Date: Oct 2005
Location: Denmark
Posts: 63
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default vBulletin doesn't check my string properly

I have this product installed: https://vborg.vbsupport.ru/showthread.php?t=94836

When I go to the admincp to give an award to a user, I wanted to give an award to a guy whose name contains a single quote '.
This is the source:
PHP Code:
if ($_POST['do'] == 'dogiveaward')
{
    
$vbulletin->input->clean_array_gpc('p', array(
        
'award_id' => TYPE_INT,
        
'award_name' => TYPE_STR,
        
'award_img_url' => TYPE_STR,
        
'awarduserid' => TYPE_INT,
        
'awardusername' => TYPE_STR,
        
'issue_reason' => TYPE_STR,
        
'award_sendpm' => TYPE_INT,
    ));

    
/*if (!empty($vbulletin->GPC['awarduserid']))
    {
        $user = $db->query_first("
            SELECT userid, username
            FROM " . TABLE_PREFIX . "user
            WHERE userid = ". $vbulletin->GPC['awarduserid'] ."
        ");
    }
    else if (!empty($vbulletin->GPC['awardusername']))
    {*/
        
$user $db->query_first("
            SELECT userid, username
            FROM " 
TABLE_PREFIX "user
            WHERE username = '"
$vbulletin->GPC['awardusername'] ."'
        "
);
    
//} 
You see, it does fix the string before it inserts it, but I still get this error:
Code:
Database error in vBulletin 3.8.2:

Invalid SQL:

                       SELECT userid, username
                       FROM user
                       WHERE username = 'bob's';
Isn't vBulletin supposed to fix the awardusername when I tell it to? or is there something I missed?
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 08:40 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03375 seconds
  • Memory Usage 2,205KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)bbcode_code
  • (1)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)showthread_list
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_threadedmode.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids_threaded
  • showthread_threaded_construct_link
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete