javascript popup with php

[mr e]

ok basically the popup just doesn't come up, i copied most of the javascript from beta.vbulletin.com/vb3 (sad huh) and changed the variables and stuff to work for my site, but all i get when i click the link is a javascript error, the ! in a yellow triangle in the bottom left corner of IE, so here is my code...

PHP Code:

echo '<script type="text/javascript">'
             .'<!--'
             .'function ip(id) {'
             .'window.open("index.php?action=ippopup&id="+id,"toolbar=no,location=no,menubar=no,scrollbars=no,width=100,height=50,resizeable=no,status=no");'
             .'}'
             .'// -->'
             .'</script>'; 


and here is what i call it with

PHP Code:

<a href=\"javascript:ip($id)\">[IP]</a> 


so any ideas on why it wont work? thanks

edit: there IS a \ in front of the "javascript:ip($id) but for some reason it isn't there in the post