New vbcode.js - vBcode and smilie user interface improvement

Hello vB Troopers,

With special permission from the Dev Team I am proud to release an improved version of vbcode.js. Any usage of this script other than in licensed vBulletin driven Boards is a direct violation of Jelsoft copyrights. Any violators will be prosecuted to the full extent of the law!

One MAJOR Improvement(note: only works with IE, NS users are out o luck! But who uses NS anyway?)

vBcode and smilies will be inserted wherever the cursor is instead of at the end of the text.

Installation
Copy the new vbcode.js file over your old one(see "Another small note" below). If you'd like to keep the old file just rename it before copying the new one.

You need to add the following text to the "message" textarea tag:

onChange=getActiveText(this) onclick=getActiveText(this)

It should basically look similiar to this:

<textarea name="message" rows="20" cols="$textareacols" wrap="virtual" tabindex="2" 
onChange=getActiveText(this) onclick=getActiveText(this) >$message</textarea>

Please note: The variable($message) may be different in some templates, editpost for example, so make sure to keep the original variable in the textarea attribute "name =". Otherwise the text may be missing in some instances.

This textarea can be found in the following templates:

Calendar Templates

calendar_enterevent

New Posting Templates

newreply

newthread

Private Messaging Templates

priv_forwardmultiple

priv_sendprivmsg

priv_sendtobuddies

and the editpost template

additional template changes

In the vbcode_popup_smilies template you must delete the following code:

<script language="JavaScript">
function smilie(smilietext) {
        opener.document.vbform.message.value += smilietext+" ";
        //opener.vbform.message.focus();
}
</script>

In the vbcode__popup_smiliebits template you must change:

<a href="javascript:smilie('$smilie[text]')">

to:

<a href="javascript:opener.smilie('$smilie[text]')">

small note:If you use the above code pleas omit the space between java and script.


If these changes aren't made the new script WILL NOT WORK!

I hope to hear from those who use it, and please let me know if you find a bug.


vB.org is using this hack. Try it out!

Scott

Latest release date: 20.04.2002
Any version older than this should be updated.

[s.molinari]

Hello all,

Has anyone had javascript errors when the vbcode/smilies are turned off? I had a user on our board who had a problem but up till now I haven't heard any more complaints. Can somebody who's installed this hack test it? It works fine here when I turn off vB code/smilies. And I can't seem to replicate the problem.

Scott

[Brian Cruz]

Originally posted by s.molinari
Hello all,

Has anyone had javascript errors when the vbcode/smilies are turned off? I had a user on our board who had a problem but up till now I haven't heard any more complaints. Can somebody who's installed this hack test it? It works fine here when I turn off vB code/smilies. And I can't seem to replicate the problem.

Scott

I had a member e-mail me recently saying that she got an error whenever she clicked on a text input box, preventing her from posting at all. She said she gets this error:

LINE : 182 (less often, it's 183)
CHAR : 1
ERROR : object expected
CODE : 0

With private messages she gets this error:

LINE : 275
CHAR : 1
ERROR : objected expected
CODE : 0

I'll ask her if she has the vbcode buttons turned off and get back to you.

[FWC]

Originally posted by s.molinari
Hello all,

Has anyone had javascript errors when the vbcode/smilies are turned off? I had a user on our board who had a problem but up till now I haven't heard any more complaints. Can somebody who's installed this hack test it? It works fine here when I turn off vB code/smilies. And I can't seem to replicate the problem.

Scott

Wow, I just got home from work and got this message:

When I try to post anything, it
says "an error occurred in the script" and it won't let me type anything in
the message box. The error is on line 256 and it says "object is expected."
I'm using AOL 7.O. Is there some incompatibility?

He had vB code turned off. I tried and had no problem. I turned it on for him and sent him an email and told him to try posting again. He's not a regular, so I don't know when I'll hear back.

[s.molinari]

@FWC and Brain Cruz

Thanks for the info. I think I'll have to post a fix for this. The problem is, when the user doesn't wish to use the vB buttons or smilies we have calls to functions that don't exist. The actual vbcode.js isn't the problem but rather the calling of the functions.

Keep me posted if you here some more news and I'll try to see about adding the fix.

I was also thinking of trying to add the functionality that when a text string is highlighted and a button is pressed, then the code is added to both sides of the highlighted text. I think that would be even better, don't you?

Scott

[Brian Cruz]

Just wanted to say that the user I mentioned does indeed have vB code turned off.

[FWC]

Originally posted by s.molinari
I was also thinking of trying to add the functionality that when a text string is highlighted and a button is pressed, then the code is added to both sides of the highlighted text. I think that would be even better, don't you?

Scott

That does sound good.

[FWC]

Originally posted by s.molinari
@FWC and Brain Cruz

Thanks for the info. I think I'll have to post a fix for this. The problem is, when the user doesn't wish to use the vB buttons or smilies we have calls to functions that don't exist. The actual vbcode.js isn't the problem but rather the calling of the functions.

Keep me posted if you here some more news and I'll try to see about adding the fix.Scott

Scott, my user came back after I toggled his smilies and vBcodes back on and was able to post with no problem.

[Stretchr]

When I click inside the text box I immediately get an Object Expected Line 290 of newreply.php etc, etc, etc. I've been through all the posts here twice and didn't see a solution. I believe I've done everything correctly, including using the txt file to edit vbcode.js. I'm sure I saw something about this but I can't find where. Any ideas? I really want this hack. Thanks!
BTW I'm using IE 6

[Stretchr]

When I use the vbcode.js you provided it works but if I edit the one that comes with 2.2.1 it didn't. Is there any problem with using the file you provided with 2.2.1 or did I misunderstand the previous threads? Thanks for an EXCELLENT hack!

[LuBi]

Originally posted by Stretchr
When I use the vbcode.js you provided it works but if I edit the one that comes with 2.2.1 it didn't. Is there any problem with using the file you provided with 2.2.1 or did I misunderstand the previous threads? Thanks for an EXCELLENT hack!

No it should work, I had some trouble setting it up myself but it works on 2.2.1 wonderfully leased: