Allow Limited Usergroup Changes Through ModCP

09 July 2005 UPDATE: Changegroup.php reworked for security

Thanks to boy genius KirbyDE this file has been reworked to secure that users who aren't already in your selected groups cannot be changed by your mods (with a check on attempted overrides).

To update, simply upload the new changegroup.php file in the zip to your /modcp/ directory. No other changes/modifications need to be made.

Please post if there are any problems!

######################################

08 May 2004 UPDATE: Modified file for error reported in post #16

Please download the new file and replace the old one with it. Post if there are any problems!

######################################

Hi all!

Here is the deal with this hack. We have usergroups set up with various permissions, mostly based on limiting their functions if they abuse their rights as a member (limiting them from certain forums, putting them under moderation, etc...).

Our mods need to be able to move our members into (and out of) these restricted groups rather than banning them, but at the same time, they should not be able to move members into (or out of) the mod, admin, waiting for confirmation groups, etc...

NOTE: Banned Groups are NOT touched in this hack -- this is for all groups OTHER than those addressed by the banning function as I wanted to keep that seperate!


What this hack does:

• Add a token to each usergroup that the admin can set to say 'yes' or 'no' that the mods can move users into and out of the group.
• Adds a token on the mod permissions level -- super mods can change allowable groups by default, and regular mods can only make these changes if you assign it on a mod by mod basis.
• Adds the functionality to the ModCP for the mods to make the changes.

Changes that need to be made:

Phrases to add: 5

PHP file edits:

• admincp/usergroup.php (1 change)
• admincp/moderator.php (1 change)
• includes/init.php (2 changes)
• modcp/user.php (4 changes)

New PHP file:

• changegroup.php (attached in this zip -- upload to your modcp folder)

Included in this zip:

• Modification .txt file
• changegroup.php
• Screenies!

The screen shots below are of the ACP -- adding the tokens to the Usergroup and giving permissions to the mods.

Enjoy, and as always, if anyone has any constructive feedback, or needs any help, post away.

[Dark_Konoko]

Christine are you sure that you have added the updated Changegroup.php to the zip? Any user with access to the ModCP is still able to change usergroup levels like so:

modcp/changegroup.php?do=changeuser&u=*usernumberhere*

[Andreas]

Hmmm, all Files in the ZIP are dated 2004, and cahngegroup.php doesn't seem to be the current Version, at least it differs from the File I have.

[Christine]

Dark_Konoko,

It didn't overwrite the zip. Likely a problem between the seat and the keyboard.

It is there now -- please verify that this is working for you.

Thanks!

[Dark_Konoko]

Confirmed. Works great now Thank you to both you and KirbyDE.

[Christine]

All credit to KirbyDE for figuring this out.

I am just responsible for PEBSAK (problem exists between seat and keyboard) upload errors.

Thank you muchly for catching this so quickly.

[Christine]

Apologies for missing earlier questions -- I have updated my subscription on this thread for email notification. :redface:

@Watson
You give mod access by editing the mods rights -- Smods and Admins have by default

@mustang_lex
That is up to you. The hack allows you to choose via usergroup permissions which groups can be changed and which can't.

[Acedeal]

Christine

your say to search for;

PHP Code:

$cell[] = iif($canbanusers, construct_link_code($vbphrase['ban_user'], "banning.php?$session[sessionurl]do=banuser&userid=$user[userid]")); 


but mine is

PHP Code:

$cell[] = iif($canbanusers, '<span class="smallfont">' . construct_link_code($vbphrase['ban_user'], "banning.php?$session[sessionurl]do=banuser&amp;userid=$user[userid]") . '</span>'); 


big difference on the lines, and what prob's is it going to cause?

also,
where do i find the screen you posted that shows the users permissions?
https://vborg.vbsupport.ru/attachmen...chmentid=17010

Found it, but the words are blank, must have something to do with the code above being a bit different

Can Restore Banned Users  	Yes No 	
	                                    Yes No
Can Edit User Signatures         Yes No

words are missing for that cell.

[UPDATE]
FIXED-

only problem I have is that it moves them from one group to another-
any way to make it add them to groups instead of removing them from group-

Hench the name group moderator
I need my group moderators to be able to add people / take people away from groups, just not shuffle from one group to another-

Other then that- nice mod.

[Christine]

Hi Acedeal,

The difference was in the addition of a span class for a font declaration.

Do you have this working as you need it to for your team?

[Acedeal]

Thanks Christine.
It's working as intended.
(looking at code to see how to make it Add users, instead of moving them to a new group)

Nice mod

[MThornback]

My super mods can't edit user groups but they can do everything else i've selected them to be able to....like sigs, avatars etc....

They get the no permission message even though they should be allowed given they are super mods....

Error is: "You can't change user groups for users who are not considered normal, registered users"

No SQL errors at all...I have no idea what if anything I might have done to make it ALMOST work 100%....help please