Chat Modifications - Fix vbShout Timezone problem

This vbShout plugin: http://www.vbhackers.com/f76/ajax-fl...ut-2-1-a-4536/

Has a serious bug with Time Zone changing to that of the last person to post in the shout box.

Here is a fix so that each user will see the time in their local timezone correctly.

1. Open template forumhome_vbshout_shout
Find this (should be at the very beginning):

<tr>

After it add:

                                <td nowrap align="left" valign="top">
                                <font size="1">
                                    <date>{$Shout['time']}</date>
                                    
                                </font>
                                </td>

Make sure that the "date" and "/date" tags are on the same line, and with no spaces between them and the $Shout variable, just as above. These are not valid html tags, and we are going to write code to replace them ourselves.



2. Open template forumhome_vbshout
Find:

Shouts.innerHTML = '<table cellpadding="1" cellspacing="3" border="0" width="95%" align="left">' + ShoutRequest.handler.responseText + '</table>'

Replace it with:

                        var formatMe = ShoutRequest.handler.responseText
			formatMe = replaceDates(formatMe);
                        Shouts.innerHTML = '<table cellpadding="1" cellspacing="0" border="0" width="100%" align="left">' + formatMe + '</table>'

In the same template
Find this:

function sb_CollectHV(sbForm)

Before it add:

// replaces <date> tags
function replaceDates(s) {
            var ret = "";
            var matches = s.match(/<date>\d+<\/date>/g);
            for(var i = 0; matches != null && i < matches.length; i++) {
                var utc = matches[i].match(/\d+/);
                var date = new Date(utc * 1000);
                ret = ret + s.substr(0, s.indexOf(matches[i]));
                ret = ret + (date.getMonth()+1) + "/" +
                            date.getDate() + "/" +
                            date.getFullYear() + " " +
                            date.getHours() + ":" +
                            ((date.getMinutes() < 10) ? "0" : "") +
                            date.getMinutes() + ":" +
                            ((date.getSeconds() < 10) ? "0" : "") +
                            date.getSeconds() + " ";


                s = s.substr(s.indexOf(matches[i]) + matches[i].length);
            }
            ret = ret + s;
            return ret;
}

3. Open file vbshout.php
FInd this (There are similar code blocks, this should be in the function rewrite_shoutbox_flatfile() around line 226):

        $Shout['time']     = buildTime($Shout['s_time']);
        $Shout['s_shout']  = bbcodeparser($Shout['s_shout']);
        $Shout['style']    = '';
        $Shout['data']     = unserialize($Shout['s_data']);
        $Shout['username'] = fetch_musername($Shout, 'usergroupid');

        if (preg_match("#(\#)?0099FF#i", $Shout['data']['color']) && $Shout['s_by'] != 1)
        {
            $Shout['data']['color'] = '';
        }

Replace it with:

        // $Shout['time']     = buildTime($Shout['s_time']);
        $Shout['time']     = $Shout['s_time'];
        $Shout['s_shout']  = bbcodeparser($Shout['s_shout']);
        $Shout['style']    = '';
        $Shout['data']     = unserialize($Shout['s_data']);
        $Shout['username'] = fetch_musername($Shout, 'usergroupid');
        
        if (preg_match("#(\#)?0099FF#i", $Shout['data']['color']) && $Shout['s_by'] != 1)
        {
            $Shout['data']['color'] = '';
        }

This should now pass the date as UTC and JavaScript will convert it on the client side to the appropriate date.

[dbirosel]

Np, i'll be on this thread frequently, so if u need anything, ill help you provide information.

[dbirosel]

Btw, here are the codes:

The codes are:

/*me bla bla bla->without the * the irc like command that says "nick bla bla bla"
/prune -> deletes all the shouts
/prune nick -> deletes all that nick's shouts
/prunshout bla bla -> deletes the latest shout which is the words "bla bla"
be careful: if you want to delete a shout that contains a smilie you have to type the smilie code also

[newhere]

Originally Posted by dbirosel

Btw, here are the codes:

The codes are:

/*me bla bla bla->without the * the irc like command that says "nick bla bla bla"
/prune -> deletes all the shouts
/prune nick -> deletes all that nick's shouts
/prunshout bla bla -> deletes the latest shout which is the words "bla bla"
be careful: if you want to delete a shout that contains a smilie you have to type the smilie code also

I've just tried this and /prune is still working for me. So I cannot recreate this on my server. Do you know if you have the latest version of the vbShout plugin installed? Or if this was a known issue with the vbShout plugin?

[dbirosel]

The /prune is working, but it displays a "Loading..." text. It suppose to say that the shoutbox has been cleared.

[newhere]

Originally Posted by dbirosel

The /prune is working, but it displays a "Loading..." text. It suppose to say that the shoutbox has been cleared.

Good bug.
This:

            for(var i = 0; i < matches.length; i++) {

Should be replaced with:

            for(var i = 0; matches != null && i < matches.length; i++) {

Though this introduces a new bug, as I believe the "system response" date needs to be fixed so it's Timestamp has the correct timezone.

That I will try to work on tomorrow... or tonight, maybe.. hm.

I'll go edit my original post to reflect this.

[ssslippy]

Ive installed this with a fresh version of shoutbox and it still switches the the to the currently users time zone.

[Hornstar]

Yeah this is something that was missed big time by my members at first, but now im not sure if i want it back lol.

[newhere]

Originally Posted by ssslippy

Ive installed this with a fresh version of shoutbox and it still switches the the to the currently users time zone.

Can you try to debug this by removnig the "date" tags from:

<date>{$Shout['time']}</date>

so you have just:

{$Shout['time']}

And then see if users in different time zones receive the same UTC value? (They should)

Are your users' local clocks set correctly?

[dbirosel]

Originally Posted by ssslippy

Ive installed this with a fresh version of shoutbox and it still switches the the to the currently users time zone.

If they are using Windows, make sure they update there computers. Windows have a special patch, to correct the effect of the daylight savings.

[Tulsa]

Originally Posted by dbirosel

Here's a bug...


When pruning (/prune) it doesn't ajax the original message when pruning. So we would need to refresh the page. So instead it would say "Loading....."

Yes, I gave this one a run and it didn't appear to do anything. I just typed in a new shout and everything was cleared out just fine. So the only thing it's not doing is bringing up the old message the shoutbox had been cleared.