Go Back   vb.org Archive > Community Central > vBulletin.org Site Feedback
FAQ Community Calendar Today's Posts Search

Closed Thread
 
Thread Tools Display Modes
  #31  
Old 08-02-2005, 02:53 AM
Chris M's Avatar
Chris M Chris M is offline
 
Join Date: Dec 2001
Location: Northampton, England
Posts: 6,186
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Dark Visor
Are there any reasons for me not respecting you?
Of course, if you suspect me of not respecting you, there are probably some reasons which I don't know about. And you know better


It creates higher server load, and this only fact is enough to try and make it less sloppy. Esspecially in those cases when you run three large queries instead of getting data from a variable that was already created.



I am not saying that. I am saying that Jelsoft's guidelines should be on the same level as W3C, with some minor fixes and additions, of course. There should be some standards for every language. There are standards for HTML/CSS/RSS, and I don't see why not standartize rules for PHP?



You are right... But, I am sure there is an expression that would not create any misconception... For example, there would be an icon instead the text. The icon would be wrappen into an URL that would lead to a detailed explanation, describing concisely what the icon means. With an extended explanation like that, it is possible to make sure that there are no misconceptions.

I already said that there would be no enforcement:

"Based on above + plus KirbyDE's post, I am rethinking the effectiveness of the above method... However, I'd like to propose another plan, which I am sure can act as a compromisse between the two sides:

On vBulletin.org, hacks have many custom fields ("Installer Included", "Support Provided", etc). It should be no problem for the forum administrators to add a field "QA Verified", editable only by the QA team and the administrators. Once the field is created, make the board display only the Verified hacks by default, with an option to display a complete list of hacks (both verified and non-verified). The option should be visualized as a link in every forum, and it should create a session variable (not a cookie), that would keep the setting as is until the user leaves the forum. Once he\she comes back, it will once again set to only display Verified hacks.

This way, it will feel like that the Verified hacks are positioned above non-verified hacks. While the coding style will not be enforced, vB hackers will be encouraged to code properly in order to rate higher and display their hacks better. The best part is, this system is easy to implement (I could help making it), and it would not require immediate validation, which is a plus from the QA team's point of view."


In other words, the QA guys would help the coder to perfect the code, after which the hack would be marked as "validated"...



You are still missing one: I'd rather not install your hack than to waste time for recoding it...
Then quite simply do not install the hack and shut up about standards then

What you are muttering about respect, I'm unsure - The message I am getting disrespects me - It disrespects my standpoint which is shared by others and it is at some points almost offensive...

It does not always create high server load - With multiple queries its not a case of a standard - Simply tell the user the information is already loaded and that their queries are not needed...

Jelsoft's guidelines should not be - PHP is not exclusive for Jelsoft - You are treating it as if it is or should be...

Whatever happens, it will cause more problems than it's worth - The only ones who are going to moan about standards are those who can already sort the problem out themselves, but cannot be bothered, but expect others to do it for them when they may not know how...

Satan
  #32  
Old 08-02-2005, 05:21 AM
Logikos Logikos is offline
 
Join Date: Jan 2003
Posts: 2,924
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Brad
We already tried this (in a way) with the QA team and it failed. There just aren't enough experanced people with the time to do something like this.

BTW we can't enforce people to code to standard anyway. Take a look at some of the 'experanced' coder's early hacks and you'll see what I mean, everyones ability to code develops over time with the help of others. Enforcing people to code to standard would deny people that option.
I have to agree with Brad 110%.
  #33  
Old 08-02-2005, 05:22 AM
Erwin's Avatar
Erwin Erwin is offline
 
Join Date: Jan 2002
Posts: 7,604
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Let's get one thing straight - there's a huge difference between:

1. Badly written code

AND

2. Well-written code that looks bad

In case 1, the code is badly written so that there are more queries, it is inefficient etc.

In case 2, the code works well, but just looks bad - ie. it's not formatted nicely in separate lines with comments.

If we are talking about case 1, I say, go for it, try to optimize badly written code.

If we are talking about case 2, then I would say that is up to individual preference - for example, if and when I release a hack, it's because I've usually written it for my own site, so I'm not going to waste too much time formatting it "to look nice".

So let's decide - are we talking about function or about "looks".
  #34  
Old 08-02-2005, 05:24 AM
Boofo's Avatar
Boofo Boofo is offline
 
Join Date: Mar 2002
Location: Des Moines, IA (USA)
Posts: 15,776
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

But even functionally bad code shouldn't be a hinderance to a newbie. Teaching him how to do it right is altogether different than chastising him in public with some sort of label. That will turn some otherwise good coders off from trying to learn and make it better.
  #35  
Old 08-02-2005, 06:17 AM
Marco van Herwaarden Marco van Herwaarden is offline
 
Join Date: Jul 2004
Posts: 25,415
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

You are forgetting possibility 3 (or 1b): Badly written code that cause either security holes or make your board disfunction to some degree.
  #36  
Old 08-02-2005, 06:22 AM
sketch42's Avatar
sketch42 sketch42 is offline
 
Join Date: May 2004
Location: Brooklyn, NY
Posts: 361
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Boofo
But even functionally bad code shouldn't be a hinderance to a newbie. Teaching him how to do it right is altogether different than chastising him in public with some sort of label. That will turn some otherwise good coders off from trying to learn and make it better.
interesting discussion... now i know that i Cant code my way ot of a paper bag.. and if i release a hack (not a template mod :lick: ) i would never expect to pass QA or any other standard... as im not even a begginer , im just struggling to learn enough to understand a quarter of this stuff ... and i dont think that anyone who releases one or two small hacks in their lifetime here would ever think that they would pass QA either... but say by some oddball chance i made a hack and it passed QA.. illtell you that i most likely still cant code my way out of a paper bag.. my point being... who does this benefit.. the coder? the community?

i honestly dont see it benefiting either... as someone who is just beggining to learn all this doesnt really care about neat code.. they want to learn how to code.. and so with time theyll learn, hopefully.

i cant see it benefitting the community because like Satan, Amy and Boofo have previously stated this will more likely create a rift in the community between coders.


so i say No to QA

just my 1/2 a cent
  #37  
Old 08-02-2005, 06:36 AM
Andrew111888's Avatar
Andrew111888 Andrew111888 is offline
 
Join Date: Mar 2003
Posts: 208
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

As a member who's only released a couple of hacks and is still a "beginner" in terms of coding for the uses of others, I know that if someone were to come along and either label my hack "inefficient", "poorly written", or "not quality assured" I probably wouldn't bother to even consider releasing hacks later down the line.

If you come across a hack that is so poor that it would harm the function of the forum, I think you should simply try and help the user who released it. Instead of "This hack is not quality assured and therefore is garbage", say "Well, around [this block], you could minimize the number of queries by doing [this]..." and the response you would receieve would most likely a thank-you.

This idea comes across as egotistical and sounds to me like a way to rub skill in the face of somebody who's still learning.
  #38  
Old 08-02-2005, 06:44 AM
Boofo's Avatar
Boofo Boofo is offline
 
Join Date: Mar 2002
Location: Des Moines, IA (USA)
Posts: 15,776
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by sketch42
i cant see it benefitting the community because like Satan, Amy and Boofo have previously stated this will more likely create a rift in the community between coders.
2 things ... first, you are one of the first to spell my name right. LOL

Second, grouping me with Satan defiantely makes me never want to release another hack/mod.
  #39  
Old 08-02-2005, 06:48 AM
Marco van Herwaarden Marco van Herwaarden is offline
 
Join Date: Jul 2004
Posts: 25,415
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Boofo
2 things ... first, you are one of the first to spell my name right. LOL
Common Beefy, don't make a fuzz about that.
  #40  
Old 08-02-2005, 06:54 AM
Boofo's Avatar
Boofo Boofo is offline
 
Join Date: Mar 2002
Location: Des Moines, IA (USA)
Posts: 15,776
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

See what I mean, sketch42? LOL
Closed Thread


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 08:16 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.04242 seconds
  • Memory Usage 2,267KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (5)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (1)pagenav_pagelinkrel
  • (10)post_thanks_box
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (10)post_thanks_postbit_info
  • (10)postbit
  • (10)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete