To enforce a valid coding style in the community!

[Boofo]

Originally Posted by KirbyDE

No they don't, and I never said they do.
Just wanted to point out that it is possible, although I guess nobody would ever even think of proofing their Code.
This is only being done for really important software like some parts or Aircraft Firmware.

Kirby, relax. I was just trying to get your goat since you got as late start in here.

Read a few posts down.

[The Geek]

The point is that only mod authors look at the code to modify.

jelsoft encourages people to modify and create macks - therefore the importance of a standard for them. Mod authors (free ones especially) have the right to not give a toss if others want to modify their modifications thereby making the coding style argument moot.

As for enforcing a code style so its easy to debug your own code... who cares as by the time it hits the proverbial shelf, it shouldnt need debugging anymore anyway.

Im not overly bothered to spend an extra day respacing, tabbing and tweaking my code so someone can give me a 'good boy' sticker. I would rather move on to something else that would benefit my users or the vb community.

If it works as intended then who cares where the freaking curley braces are?

[akanevsky]

I was only kidding Kirby in that remark. Kirby does excellent work and his stuff always works.

I know Esspecially the HowTo's

But to say that every hack/mod you do ALWAYS works the first time, is not only arrogant, but false. If it hasn't happened yet, it will, you can be sure.

I did not say that it ALWAYS works. Show me where I said "ALWAYS"... Thanks.

[The Geek]

ooo better idea!!!!

Have the 'QA' team simply reformat the code to the correct style!

That accomplishes everyones needs:
1- The QA people have macks that are standardized
2- The authors can move on to far more important issues like making more macks.

Whoot!

[yoyoyoyo]

Originally Posted by Dark Visor

Come on, what kind of language is that... You are a moderator. Set a good example...

Originally Posted by Dark Visor

Shut the f*ck up and stop trying to say that I said what I didn't say. Thanks.

Pot <--> kettle

[akanevsky]

f it works as intended then who cares where the freaking curley braces are?

I do... When the "freaking curley braces" are where they shouldn't be, I cannot read the code and therefore I cannot be sure that you did not put any spyware or viruses into it.

Pot <--> kettle

lol yea. If a moderator may, then so may I ...

ooo better idea!!!!

Have the 'QA' team simply reformat the code to the correct style!

That accomplishes everyones needs:
1- The QA people have macks that are standardized
2- The authors can move on to far more important issues like making more macks.

Whoot!

That'd be a no, because QA does not have that much time..

[Andreas]

Originally Posted by Dark Visor

The coders will. I'd like you to recall the coding style of vBulletin 2 and compare it with vBulletin 3. Which one is easier to modify? This:

PHP Code:

        if ($a) {
            while ($b = $c)
                {
            echo "!!!!!";    }
    }
                else { print "yo";
    } 


or this

PHP Code:

if ($a) 
 {
     while ($b = $c)
     {
         echo "!!!!!";
     }
 }
 else
 {
     print "yo";
 } 


Obviously the 2nd one, as it is easier to read.
However, as already said, you could just use a prettyprinter to transform Code #1.

[calorie]

Originally Posted by KirbyDE

The 2nd one complies with vBulletin coding standards.

Yep, it does, but if error reporting is E_ALL only...

The point being that X's standards may not be Y's standards may not be Z's standards. If a hack doesn't pose a security risk, let style be as it may. If a hack does pose a security risk, see this.

[yoyoyoyo]

Originally Posted by Dark Visor

I do... When the "freaking curley braces" are where they shouldn't be, I cannot read the code and therefore I cannot be sure that you did not put any spyware or viruses into it.

better notify symantec about the curley brace virus!

[sabret00the]

Originally Posted by yoyoyoyo

Pot <--> kettle

echo'd thoughts.