To enforce a valid coding style in the community!

[yoyoyoyo]

I think it would be great to have a specific forum "hacks that are looking for help" where people can voluntarily post their hacks, and people who feel like helping out can help. It would be like a "beta, but looking for assistance" forum. Then after the hack has all of the bugs worked out of it it can be moved to a release forum. Posting in the forum would be voluntary, as I mentioned- people could post in the regular beta forum if they are working it out themselves, and in the "beta, but looking for assistance" forum if they have done all they can do, but need help. Then there would be no stigma, or labels, and people would get the help they need (hopefully).

[calorie]

Originally Posted by used as an example

1. Valid - The hack complies with the vB Coding Standards both in terms of PHP and Source Code Formatting.
2. Cleared - The hack's PHP is optimised, but it has obvious flaws in Coding Style
3. Warning - Neither the hack's PHP or the hack's Coding Style complies
4. Pending - Pending evaluation (default for new hacks)

... opt-in, and people who choose never to opt-in just have to face having their hacks marked as "Unvalidated" ...

Assuming this example, the best to hope for using...

if (isset($a)) {
	echo "A";
}

Is "Unvalidated" or "Cleared" even though...

[Boofo]

Originally Posted by Revan

Still you are saying "putting down". You seem to be unable to understand how it's gonna be done, in spite of my best attempts at showing you a nice, friendly way of doing it. That is highly annoying.

And I think that such a position should be awarded based on skill and actual familiarisation with the things they would be working with, rather than how much time they have spent in the help forums.

I think the problem everyone seems to be having is that there are a few coders here (and I won't mention your name Marco) who have an attitude and think they are beyond helping newbies and would rather sit on a pedistal and preach than get down in the trenches where the real dirty work is. Helping someone learn and showing them the way is one thing, but labeling them because they don't meet the standards you are setting, is another. Labels suck! And anyone that uses them ... well ... you know the rest.

[sabret00the]

Originally Posted by Revan

Still you are saying "putting down". You seem to be unable to understand how it's gonna be done, in spite of my best attempts at showing you a nice, friendly way of doing it. That is highly annoying.

And I think that such a position should be awarded based on skill and actual familiarisation with the things they would be working with, rather than how much time they have spent in the help forums.

let's not get into semantics, when you're saying "not validated" that's a put down. we can play on words all day but to say that someone's code is not as good as another's so publically is a 'put down' by all standards i know.

the word standards is a great one for this thread don't you think?

[Revan]

Originally Posted by Boofo

I think the problem everyone seems to be having is that there are a few coders here (and I won't mention your name Marco) who have an attitude and think they are beyond helping newbies and would rather sit on a pedistal and preach than get down in the trenches where the real dirty work is. Helping someone learn and showing them the way is one thing, but labeling them because they don't meet the standards you are setting, is another. Labels suck! And anyone that uses them ... well ... you know the rest.

It's not nice to call your boss (Xenon) a stinker, you know...
I took a hella long time getting my Advanced Coder status because close to all the good hack ideas was taken by everyone else, and I devote my time to managing the RPG more than anything. Who's to say I was not as good of a coder as hellsatan? LW? Even now, who's to say Im not as good of a coder as ZT?
OH NOES! I r teh labelled! I must now go kill myself.

[akanevsky]

But it has to be a voluntary thing - maybe hackers who choose to go through this process can opt in.

It is voluntary. Would you please pay more attention to what's written in the first post? Thanks.

We can't really force every hack author to go through this.

I agree.. There could be an opt-in/opt-out option in usercp.

But really, a lot of badly written hacks, through the process of others downloading it and upgrading it, do get a lot of kinks fixed up. I can see the value of formalizing this - but like I said, it takes a LOT of time.

It does take a lot of time.. But who is in a rush for this?

Besides Dark Visor, who else would have time to review the potentially thousands of hacks that will get released?

Once there is a team, more volunteers will join...

If you clean the code for them, they'll never learn.

Eventually, they will learn. They will probably read the suggestions, and if they are interested, they will pay attention to the changes. As Revan said, "If this discourages the coder, then that coder is a carebear and really should toughen up if he wants to survive in life. Constructive critisism is the core of all learning."...

As for the labels, I think a newbie hack installer has a right to know if this hack has been coded as per a set of standards. This will make the user feel more secure about installing the hack, because he can be certain the odds of this hack destroying something on this board are minute.

Exactly what I am trying to say.. Any care about the end-users, or is this only about the process of releasing the code?

As per labels, I agree except I would change "Valid" to "Optimized".

Me.

Thanks, really appreciate that.

Guy comes in and makes a hack that alot of people love using, but he also sees that the hack has been up for a while and was not marked as perfect. Does this not discourage the coder? It does discourage me.

Taking into account that suggestions are offered, the guy of yours would have a perfect opportunity to learn from the suggestion and improve his code. If he is not happy, see two paragraphs above.

cause it seems you are so set on making money I see

This is irrelevant to the discussion. I never said QA would charge anything for the suggestions or qualifications...

no theirs no posts that say is this valid, but their are posts that ask how do you do this? why not show them with valid code?

An example of such post, please? I rarely see any of those.

I dont know about DV but I don't venture there much because I can rarely code off the top of my head, so it would be too much testing and hassle.

It is not always necessary to test a code. In fact, I can write a properly working hack without ever testing it...

Two people, TYVM!

4, TYVM

if ($a) echo "A";

if ($a) print("A");

if (isset($a)) echo "A";

if(!empty($a)) { echo "A"; }

if (isset($a)) {
echo "A";
}

if (isset($a)) {
echo "A";
}

if ($a)
{
echo "A";
}

// la la la

This is actually a good example of how a coding style affect the code's readability...

1. https://vborg.vbsupport.ru/show...30&postcount=10 (first paragraph under the second quote)

Don't try to use obsolete information... The newest info is in the first post, as was already mentioned.

P.S. Also, don't try to use thread title or whatever against me... I am not in position to change the thread's title, and if I was I assure you that I would remove the word "enforce"...

Assuming this example, the best to hope for using...

Code:

if (isset($a)) {
echo "A";
}

Is "Unvalidated" or "Cleared" even though...

Umm... Why use isset(), if it an additional 7 bytes? By optimizing even this small piece of code, you save a lot of traffic and disc space in the long run.

OH NOES! I r teh labelled! I must now go kill myself.

LOL

it's his thread, i assumed he was the idea leader.

You assumed wrong. There is no such thing as "idea leader", it would be a team effort...

[sabret00the]

Originally Posted by Dark Visor

An example of such post, please? I rarely see any of those.

you don't venture down their much do you? 9/10 posts are asking how do you do this or why don't this work.

Originally Posted by Dark Visor

You assumed wrong. There is no such thing as "idea leader", it would be a team effort...

come on take responsibility, it was your idea, you put it forward, i wasn't referring about implementation, i was referring to the act of the idea being put forward.

ps. people skills DV remember cleavage, cleavage

[calorie]

Originally Posted by Dark Visor

This is actually a good example of how a coding style affect the code's readability...

if (isset($a)) {
	echo "A";
}

if (isset($a))
{
	echo "A";
}

The latter isn't an more readable that the former IMHO, but the former is, erm, marked as...

[Boofo]

Originally Posted by Revan

It's not nice to call your boss (Xenon) a stinker, you know...
I took a hella long time getting my Advanced Coder status because close to all the good hack ideas was taken by everyone else, and I devote my time to managing the RPG more than anything. Who's to say I was not as good of a coder as hellsatan? LW? Even now, who's to say Im not as good of a coder as ZT?
OH NOES! I r teh labelled! I must now go kill myself.

How did Xenon get brought into this? He doesn't label anyone.

I think the idea is good, really. I just think labeling is wrong. And almost everyone here is a better coder than I will ever be. I won't be "labeled" by anyone. I'm too old for that stuff.

The newbies deserve the chance to learn, just like you got and the rest of us. And no matter what you say now, if someone had tried to label you when you first started out, you might not have ever gotten to where you are now.

[Paul M]

Originally Posted by Dark Visor

It is not always necessary to test a code. In fact, I can write a properly working hack without ever testing it...

What an arrogant statement, I don't care if a hack is one line, you should still test it. No one is that perfect, allthough it's obvious some think they are.