To enforce a valid coding style in the community!

[akanevsky]

"SELECT * FROM " . TABLE_PREFIX . "user WHERE userid = '$bbuserinfo[userid]'"
"SELECT * FROM " . TABLE_PREFIX . "user WHERE userid = $bbuserinfo[userid]"
"SELECT * FROM " . TABLE_PREFIX . "user WHERE userid = ".$bbuserinfo['userid']

I'd say, the one that takes the least space.
However, every one of these would do, even though I personally prefer the first and second ways of doing it. They are neater than the third one. The third way of doing it often ends up in parse error because you accidentally forgot to put a closing ' " ', or because you put an extra concatenation symbol...

It doesn't have to be so sophisticated... All the three ways would count as the right ways to do it.

you shouldn't encapulate numbers but at the same time
SQL Query: (how to run queries)


"SELECT * FROM " . TABLE_PREFIX . "user WHERE userid = " . intval($bbuserinfo[userid]) . ""

would probably be the stardard set for a gold-star according to this thread

This is an intended exaggeration... Why do you imply that I would intval() something that is already an integer???

my bad you just said you weren't the idea leader thus that really held no weight, unless i decided so, ok bu

Shut the f*ck up and stop trying to say that I said what I didn't say. Thanks.

[Andreas]

Originally Posted by Boofo

And we all know Kirby's hacks work right the first time, huh, buddy?

No they don't, and I never said they do.
Just wanted to point out that it is possible, although I guess nobody would ever even think of proofing their Code.
This is only being done for really important software like some parts or Aircraft Firmware.

[Christine]

Originally Posted by sabret00the

i do wonder though, for all the people looking to take those elevated positions, how often are you found in the PHP forum helping out the coders who are begging for help?

Given the tone of how some of these suggestions are being presented, I would recommend that *IF* anything like this is ever implemented, nomination to the "QA" team be based on their activities/helpfulness in the Help Me Finish forum (assuming one is opened for 3.5).

As a new coder (who is not afraid to ask for help), I can assure you that I will gladly take the assistance/advice of someone posting to help me LONG before someone cutting my head off so that their ego is satisfied (again, reference TONE).

Carry on.

[sabret00the]

Originally Posted by Dark Visor

Shut the f*ck up and stop trying to say that I said what I didn't say. Thanks.

Wow you seem to be getting a bit stressed there, you might wanna reel in that temper just a little bit, i mean after all asking to judge peoples hacks and you can't even muster up the people skills to last a debate on the concept, ouch, this site would really be going down hill.

[Andreas]

Originally Posted by calorie

"SELECT * FROM " . TABLE_PREFIX . "user WHERE userid = '$bbuserinfo[userid]'"
"SELECT * FROM " . TABLE_PREFIX . "user WHERE userid = $bbuserinfo[userid]"
"SELECT * FROM " . TABLE_PREFIX . "user WHERE userid = ".$bbuserinfo['userid']

So which of those is, erm, best?

The 2nd one complies with vBulletin coding standards.

[The Geek]

This is getting seriously moronic.

If there is a security fault... Mark it.
If there are ways to improve the efficiency... suggest it.
If you dont like the code style...go make your own.

Who really cares if the style isnt standard? Who is really going to open the code up and say 'damn, I wish I would have known this didnt use the coding standards before I installed it!'.

If the validators are so hot at writing code their time would be better spent writing it and not grading others.

I would opt out of the system just to spite - but thats the kind of lame coder I am

[Boofo]

Originally Posted by Dark Visor

Come on, what kind of language is that... You are a moderator. Set a good example...

I just wanted to see if I could bypass the censorship for that word. And crapola sounded too kiddie-like.

[Andreas]

I think "Coding Style" (eg. indention etc.) isn't thaaat important.
Of course it makes reading/debugging the code easier if it is "clean", however you could always prettyprint it?

[akanevsky]

No they don't, and I never said they do.
Just wanted to point out that it is possible, although I guess nobody would ever even think of proofing their Code.
This is only being done for really important software like some parts or Aircraft Firmware.

Good point. Less important software we can always debug later... If there is a need for it.

As a new coder (who is not afraid to ask for help), I can assure you that I will gladly take the assistance/advice of someone posting to help me LONG before someone cutting my head off so that their ego is satisfied (again, reference TONE).

Hey, where'd you get head cutting part from? :P

Wow you seem to be getting a bit stressed there, you might wanna reel in that temper just a little bit, i mean after all asking to judge peoples hacks and you can't even muster up the people skills to last a debate on the concept, ouch, this site would really be going down hill.

You see, anybody would get annoyed when someone "glues" irrelevant pieces of text together and waves them in front of your nose. You are wrong though, I am not getting stressed out. Now as I said, shut the f*ck up. Thanks.

The 2nd one complies with vBulletin coding standards.

Good, the we use the 2nd one.

Who is really going to open the code up and say 'damn, I wish I would have known this didnt use the coding standards before I installed it!'.

The coders will. I'd like you to recall the coding style of vBulletin 2 and compare it with vBulletin 3. Which one is easier to modify? This:

PHP Code:

        if ($a) {
            while ($b = $c)
                {
            echo "!!!!!";    }
    }
                else { print "yo";
    } 


or this

PHP Code:

if ($a) 
 {
     while ($b = $c)
     {
         echo "!!!!!";
     }
 }
 else
 {
     print "yo";
 } 


There you go.

[Boofo]

Originally Posted by Dark Visor

I didn't test much of Kirby's hacks, but if you see some of mine you will see that they work right from the first install... Unless there are some addons on requests that I implement...

I was only kidding Kirby in that remark. Kirby does excellent work and his stuff always works. But to say that every hack/mod you do ALWAYS works the first time, is not only arrogant, but false. If it hasn't happened yet, it will, you can be sure.

Exactly. As I stated in that same post you just quoted, there would be no stickers on the non-passed posts... You just skipped over it, huh? Way to go, buddy.

Putting stickers (labels) on passed ones is the same as putting a fail sticker on one that doesn't pass. You are still labeling, no matter how you look at it.