Board Optimization - Plugin Based Template Cache

Removed on author's request.

[orban]

1) As I said if you are interested in maximizing performance take a look at the one I marked as experimental, I will actually clean that up a bit soon and upload here. Just did a quick and dirty benchmark with microtime, you save about 4*10^-6 seconds if you remove the double eval.

2) Good idea, thanks. Clearing the cache in the shell is the best idea anyway.

[Andreas]

The experimental Version is quite nice

However if breaks

Template foobarcheck

<if condition="$foo = 'bar'">
</if>

PHP Code:

$foo = 'foo';
eval('$devnull = "' . fetch_template('foobarcheck') . '";');
// $foo = ? 


Without this Plugin, $foo is bar. With this plugin it is still foo.

Also, you don't need to pass superglobals like $GLOBALS

[orban]

Do vB default templates have <if> conditions? Because all the default templates work fine for me. Feel free to filter out $GLOBALS, but what does it matter anyway? This level of detail is absolutely unnecessary you won't gain any performance by spending your time on that. The step from eval(very long string) to eval(function call cached by opcode cacher) is the important one.

[Andreas]

Do vB default templates have <if> conditions?

Yes, they do - kind of.

Template memberlist_resultsbit for example:

<if condition="$show['emailcol'] AND exec_switch_bg()"><td class="$bgclass">

Without your plugin, you will get alternating column backgrounds.
With your Plugin, you won't

By using references, you could fix that; would also save some memory/processing.
For example, $vbphrase is used in almost all templates.
With the current code, this array is always being copied when a template is eval'ed.

Nevermid, I just wanted to make suggestion to improve this further. Sorry.

[orban]

Alright I see where you are coming from. Yeah references will solve the problem, vB's code is more messed up than you'd ever think. Well I updated functions_template_cache.php.

[RS_Jelle]

Originally Posted by orban

Alright I see where you are coming from. Yeah references will solve the problem, vB's code is more messed up than you'd ever think. Well I updated functions_template_cache.php.

So we just need to upload the new functions_template_cache.php to our FTP to have the everything actual on our forum for this mod?

It would be easier if you gave it a new version number (and eventually send an update mail to all users). Now it's a bit confusing as there's no concrete information about the changes (or we need to read the full thread) and the mod is marked as updated ...

[orban]

It would be easier if you read the first line.

[RS_Jelle]

Originally Posted by orban

It would be easier if you read the first line.

I'm sorry, I missed that line