Go Back   vb.org Archive > vBulletin Modifications > Archive > vB.org Archives > vBulletin 2.x > vBulletin 2.x Full Releases
FAQ Community Calendar Today's Posts Search

Closed Thread
 
Thread Tools
Details »»

Version: , by (Guest)
Developer Last Online: Jan 1970 Show Printable Version Email this Page

Version: Unknown Rating:
Released: 01-21-2001 Last Update: Never Installs: 3
 
No support by the author.

THIS THREAD IS CLOSED!
Posts in here will NOT be answered

This hack has undergone many major changes since this thread was started. Consequently, most of the posts have become dated and of little use. To coincide with the latest major release (20010712), a new one has been started.

See this thread for the latest version and discussion

Show Your Support

  • This modification may not be copied, reproduced or published elsewhere without author's permission.

Comments
  #332  
Old 05-02-2001, 12:34 PM
Mark Hewitt Mark Hewitt is offline
 
Join Date: Oct 2001
Posts: 174
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally posted by fastforward
What code changes did you make?
I implemented all the code changes you specified.

Quote:
Did you go through and re-check the tables to make sure all columns and indexes are as specified in the new versions.
Yes, I deleted all my current usenet forums and removed the usenet_ tables. I then made sure the extra feilds matched up. Think it was only regpost I needed to add. I then created and populated the new usenet tables.

Quote:
Also, did you make sure you removed any existing code changes you may have made?
I implemented it from a clean copy of RC2 which I was previously running the last version of the hack on.

Hate to heap more problems on you but the NNTP posting time option doesn't seem to work, still uses local time.

Apart from that it works a treat
  #333  
Old 05-02-2001, 01:02 PM
fastforward fastforward is offline
 
Join Date: Oct 2001
Location: NC, USA
Posts: 399
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I'm working on it. I'll get back to you.

If only there were no users. life would be so much easier for developers
  #334  
Old 05-02-2001, 01:05 PM
Mark Hewitt Mark Hewitt is offline
 
Join Date: Oct 2001
Posts: 174
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
If only there were no users. life would be so much easier for developers
I hear ya. Especially ones that don't know how to run a Java class (long story)
  #335  
Old 05-02-2001, 01:23 PM
fastforward fastforward is offline
 
Join Date: Oct 2001
Location: NC, USA
Posts: 399
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

OK...

The parse errors may have been because it was the first time the script was run. The way it works now is it appends any usenet variables that need to be referenced by vB to the 'options' template. This means they can be accessible through layout templates without code changes. The variables causing problems are the post counts which were not quoted. If these are NULL, then it will generate a parse error as the resulting code would like this: ' $usenettotalthreads= ' instead of ' $usenettotalthreads="" '. That's easy to fix.

I can not reproduce your time problem. When I set NNTP in the options all my times show up correctly as the original posting date. Can you reconfirm that this is happening by comparing it against your newsreader? Or have you already done that?
  #336  
Old 05-02-2001, 01:28 PM
Mark Hewitt Mark Hewitt is offline
 
Join Date: Oct 2001
Posts: 174
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
The parse errors may have been because it was the first time the script was run. The way it works now is it appends any usenet variables that need to be referenced by vB to the 'options' template.
This sounds about right, especially as everything was restored when I resubmitted the options. However I did run the script twice and the same problem happend both times.

Quote:
I can not reproduce your time problem. When I set NNTP in the options all my times show up correctly as the original posting date. Can you reconfirm that this is happening by comparing it against your newsreader? Or have you already done that? [/B]
Looking back on it, it's possible the option wasn't set on the second time I ran it. As half the posts seem to be okay. So ignore that part
  #337  
Old 05-03-2001, 02:15 AM
fastforward fastforward is offline
 
Join Date: Oct 2001
Location: NC, USA
Posts: 399
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

A few bugfixes and the addition of the 'exclude usenet posts from new post search' option.

Take note of item number 4. If you have already installed the last version, you MUST change this column type to SIGNED for correct handling of outgoing posts.
  1. Added option to exclude usenet posts from 'Get New Posts' search.
  2. Fixed bug causing parse errors during first run.
  3. Fixed bug causing newnews.pl errors 'e.field invalid column' error if custom profile field for outgoing email isn't added.
  4. Fixed incorrect column type for isusenetpost in post and thread tables. They should be TINYINT(2) SIGNED.
This should be one step closer to a bugfree version. Time is running out, vB 2.0 will be out any day

I'll delay the move to vbulletin.org until the final release.

Download latest version
  #338  
Old 05-03-2001, 09:05 AM
Mark Hewitt Mark Hewitt is offline
 
Join Date: Oct 2001
Posts: 174
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally posted by fastforward
[B][*]Fixed bug causing parse errors during first run.
I'm still getting the same errors after a run that I detailed above
  #339  
Old 05-03-2001, 11:25 AM
Mark Hewitt Mark Hewitt is offline
 
Join Date: Oct 2001
Posts: 174
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I've looked at the options template and after it has just run it has

$totalusenetposts=5902;
$totalusenetthreads=18;

After I go back and resumit the vB options page is changes to

$totalusenetposts="5902";
$totalusenetthreads="18";

i.e. it now has quotes

For temporary fix I've commented out generateoptions(); as I don't use total threads/posts anyway, and now all seems well.

(another edit). The NNTP post time seems to work for the first few posts then gives up and goes back to local time.
  #340  
Old 05-03-2001, 12:43 PM
fastforward fastforward is offline
 
Join Date: Oct 2001
Location: NC, USA
Posts: 399
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I think caching causes problems for this template update function aswell. I think the best solution will be if I remove it for the threadcounts and you will have to make a code edit to use them. It's only a one liner anyway.

I still can't reproduce your posting date problem. It's actually only 1 little line in the script that decides the date. When the script starts up, it reads all the config from the tables and then when it gets to the load forums bit it checks to see whether it should replace the nntp date with the local date. So the default is actually NNTP date. I'll keep trying to reproduce it though.
  #341  
Old 05-03-2001, 12:49 PM
fastforward fastforward is offline
 
Join Date: Oct 2001
Location: NC, USA
Posts: 399
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I've just looked at the code and the quotes are gone again! I think this because I started making the the edits on my test board while at work and then not transfer them to the distribution copy when I got home. All the other fixes I mentioned were still there, it's just the quuote issue around the post counts (which I'm removing anyway).
Closed Thread


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 05:49 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.06312 seconds
  • Memory Usage 2,313KB
  • Queries Executed 25 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (7)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)modsystem_post
  • (1)navbar
  • (6)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (4)pagenav_pagelink
  • (2)pagenav_pagelinkrel
  • (11)post_thanks_box
  • (11)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (11)post_thanks_postbit_info
  • (10)postbit
  • (10)postbit_onlinestatus
  • (11)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • postbit_imicons
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete