Usenet gateway

THIS THREAD IS CLOSED!
Posts in here will NOT be answered

This hack has undergone many major changes since this thread was started. Consequently, most of the posts have become dated and of little use. To coincide with the latest major release (20010712), a new one has been started.

See this thread for the latest version and discussion

Looks like I forgot the addslashes() to that. That will have to be a manual edit to the code I'm afraid. I'll have to update the instructions. I don't know why I missed that. It's in my setup but not in the instructions.

There is one occurance in admin/functions.php that you'll need to change.

It's on or around line 869 and reads:

$DB_site->query("UPDATE forum SET lastactivethread = LEFT('".$threadinfo[title]."',$lastactivethread_length) WHERE forumid = ".$threadinfo[forumid]);

Change it to:

$DB_site->query("UPDATE forum SET lastactivethread = LEFT('".addslashes(htmlspecialchars($threadinfo[title]))."',$lastactivethread_length) WHERE forumid = ".$threadinfo[forumid]);

Sorry about that.

If you're updating the docs. there's a minor change that may need to be added. In regards to removing the "Registered: " from postbit, I think the Location needs removing as well? It appeared in duplicates after I installed the latest 2.3 usenet hack. Just FYI.

I can't stop saying how great this hack is!

Several errors in the documentation have been corrected.

There was on instance where the 'OLD CODE' was, in fact, the 'NEW CODE'.

Another ommission led to the word 'location:' being displayed twice for registered users.

And finally a serious error in admin/functions.php that caused posts to fail if the thread title contained a quote.

Any idea on how long the install script will take? If it will more then a week I will just install it manually.

Thanks for any info.....

Michael

Originally posted by mkilty
Any idea on how long the install script will take? If it will more then a week I will just install it manually.

I haven't actually started it yet... sorry. I've been busy doing a new CV ( that's resume for you yanks ). Time for a new job change

I'd install it by hand if I were you. It's quite straight forward. It's just replacement of code in about 3 or 4 files.

Maybe Jelsoft will let me put ready hacked files in the members area. That would make it easier. Trouble is, if they do it for one they'll have to do it for everybody.

Originally posted by fastforward


There was on instance where the 'OLD CODE' was, in fact, the 'NEW CODE'.

Which one's that? Not sure if I cought that, or it's screwd up, I installed the 2.3 version of the hack.

The NEW CODE part was still OK. So if you managed to find the correct bit to replace you'll be fine. It was actually the same section as the missing addslashes() problem.

I am having the problem where some replies are not being inserted into the threads that they correspond to and they just stay in the usenet_article table. While a few of them do not have the parent post to be inserted into, the majority do have the thread started and post that it's a reply to is in there, but it fails to insert them into it. These messages end up being about 10% of the total posts from the rec.sport.unicycling newsgroup.

I also tried it with some other newgroups on a server that was not a usenet server and had the same problems with those ones too. Here is the test newsgroup that I tried on that server: news://news.webdiscuss.com/webdiscuss.test

It's not just the thread starter that prevents an article being inserted. Each usenet article has references to every post that was posted before it. An article will only be placed in to the forum when the post immediately before it is available. If it didn't work like this you would get posts appearing as replies to a message that doesn't exist. Very confusing! When you first start pulling news this occurs a lot due to the fact that many of the articles will have expired but replies are still there. As time goes on the surplus will expire from the usenet_article table and the number will reduce. Provided your news provider gets all posts, you will get them too. I am confident this part of the script is working as it is the part I spent longest on to ensure all articles were collected and inserted when appropriate. An example is my dbforums site. It has been running long enough for the orphan messages to fall through the system and I now have about 800 articles in the usenet_article table. This is from 70 usenet groups. So that is the number you can expect after about a week of running (provided your expire is set to 5-7 days) in the control panel.

Let me know if this would explain the numbers you are seeing.

And you are you using the latest version right?

Originally posted by fastforward
It's not just the thread starter that prevents an article being inserted. Each usenet article has references to every post that was posted before it. An article will only be placed in to the forum when the post immediately before it is available.

The post that the message is a direct reply to is there and inserted into the forum already. If you try that test forum that I mentioned, there are three threads and no missing or expired posts yet it happens in there. The posts not appearing in the forum is happening in the real newsgroups as well even though the entire thread exists on the news server with the post that is is a reply to.