MultiQuote

Introduction
This multiquote hack allows your members to select multiple posts to quote from. These posts can be on a different page, in a different thread, or on an entirely different forum. Don't worry, the hack checks to make sure the user has read permissions on the post so no sneaky members can insert random post ID's in hopes to find what's going on in your secret staff forums.

What's new in this "version 2"?

• Better programmed!
• "Go Advanced" works with Quick Reply
• Fixed the bug with IE not "turning on" the MQ icons when re-viewing a thread with MQ'd posts.
• Included vB3-styled icons (I just resized the images posted by Hoffi -- thanks Hoffi!)

Overview

• vB files to modify: 1 (newreply.php)
• Templates to modify: 2 (SHOWTHREAD, postbit)
• Phrases to create: 1 (multiquote)
• Files to upload: 3 (2 images, 1 Javascript file)

(Included missing Javascript file from post #75. Sorry for the delays, I don't come around often!)

[Chroder]

Originally Posted by mtellin

I already un-installed it without thinking, but I got a SQL error when I clicked the quote button, then unclick it and hit the post reply button...anyone else get this?

Your fast I was right in the middle of fixing it when you posted Anyway, see first post and you can download the new file. Only the code in newreply.php was updated. (You'll see an 'updated' text next to it in the HTML instructions).

[mtellin]

Originally Posted by Chroder

Your fast I was right in the middle of fixing it when you posted Anyway, see first post and you can download the new file. Only the code in newreply.php was updated. (You'll see an 'updated' text next to it in the HTML instructions).

thanks, did the trick

[NuclioN]

When quoting (after the updated file) and reply with quick reply another mysql error:

Database error in vBulletin 3.0.0 Release Candidate 1:

Invalid SQL: SELECT postid, username, pagetext FROM vb3_post WHERE postid IN(6566,6568) AND postid <> ORDER BY postid ASC
mysql error: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'ORDER BY postid ASC' at line 1

mysql error number: 1064

[Chroder]

Another update that deals with these things more cleanly. I'm working on an addition that'll allow the "go advance" in the QR to also have all the quotes.

Change the newreply.php code to the following:

PHP Code:

//############################################################################
 //# START MULTI QUOTE                                                     #
  //############################################################################
  if(isset($_COOKIE[COOKIE_PREFIX . 'mq']))
  {
      $pids = $_COOKIE[COOKIE_PREFIX . 'mq'];
      $pids = urldecode($pids);
  
      if(!empty($pids) && preg_match("/^[0-9,]+$/", $pids))
      {
         $mq_postid = (empty($_REQUEST['noquote']) ? "AND postid <> {$postinfo['postid']}" : '');
          
         $q = $DB_site->query("SELECT postid, username, pagetext FROM ".TABLE_PREFIX."post WHERE postid IN($pids) $mq_postid ORDER BY postid ASC LIMIT 20");
          while($row = $DB_site->fetch_array($q))
          {
             $originalposter = fetch_quote_username($row['username']);
              $pagetext = htmlspecialchars_uni($row['pagetext']);
              $pagetext = trim(strip_quotes($pagetext));
          eval('$newpost[\'message\'] .= "' . fetch_template('newpost_quote', 1, 0) . '\n";');
          }
      }
  
     setcookie(COOKIE_PREFIX . 'mq', '', time() - 3600, $vboptions['cookiepath'], $vboptions['cookiedomain']);
  }
  //############################################################################
 //# END MULTI QUOTE                                                         #
  //############################################################################ 


This should fix all mysql errors recieved above, on my test board it seemed to do fine It also now checks that the $pids is only numbers/commas so there are no tricky users trying to screw up the board.

[Updated file uploaded in first post]

[mtellin]

I still get one error with this, when I click the multi quote button and then click go advanced I get this:

Database error in vBulletin 3.0.0 Release Candidate 1:

Invalid SQL: SELECT postid, username, pagetext FROM post WHERE postid IN(19123) AND postid <> ORDER BY postid ASC LIMIT 20
mysql error: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'ORDER BY postid ASC LIMIT 20' at line 1

mysql error number: 1064

EDIT: looks like NuclioN already posted this

[Chroder]

I can't recreate this problem on my localhost, so I asume this was prior to the Jan05-2 update? So its fixed -- correct?

[mtellin]

Originally Posted by Chroder

I can't recreate this problem on my localhost, so I asume this was prior to the Jan05-2 update? So its fixed -- correct?

in my case it wasnt, thats with your latest version that you have

[BillaBongUSA]

Yeah, I just updated everything with the new code that you just posted, and I'm getting the same error when I click on the "Go Advanced" button.

[NuclioN]

The go advanced button is producing this error but after your last update the quick reply gives that error again. I hope you can fix it because this is a great addition.

[Chroder]

Ok, clicking MQ button followed by a "Go Advanced" in the QR gives an error? I think I've found it, forgot a '!' on a line. But before I make an 'update' would someone please try it?

PHP Code:

//############################################################################
 //# START MULTI QUOTE                                                     #
  //############################################################################
  if(isset($_COOKIE[COOKIE_PREFIX . 'mq']))
  {
      $pids = $_COOKIE[COOKIE_PREFIX . 'mq'];
      $pids = urldecode($pids);
  
      if(!empty($pids) && preg_match("/^[0-9,]+$/", $pids))
      {
         $mq_postid = (!empty($_REQUEST['noquote']) ? "AND postid <> {$postinfo['postid']}" : '');
          
         $q = $DB_site->query("SELECT postid, username, pagetext FROM ".TABLE_PREFIX."post WHERE postid IN($pids) $mq_postid ORDER BY postid ASC LIMIT 20");
          while($row = $DB_site->fetch_array($q))
          {
             $originalposter = fetch_quote_username($row['username']);
              $pagetext = htmlspecialchars_uni($row['pagetext']);
              $pagetext = trim(strip_quotes($pagetext));
          eval('$newpost[\'message\'] .= "' . fetch_template('newpost_quote', 1, 0) . '\n";');
          }
      }
  
     setcookie(COOKIE_PREFIX . 'mq', '', time() - 3600, $vboptions['cookiepath'], $vboptions['cookiedomain']);
  }
  //############################################################################
 //# END MULTI QUOTE                                                         #
  //############################################################################ 


Sorry if even this doesn't work. Not thinking clearly today. :tired:

// edit. yep, the correct code..