Add-On Releases - Rewrite eBay Links

Rewrite eBay Links

Description:
This mod rewrites eBay links so they link to an affiliate.

Request:
Requested in a paid deal by brookelyn, this modification's idea can also be accredited to brookelyn. Also requested by various other members.

Installation:
All the installation information is in the package.

Changes:
2 Plugins
1 File

[LanciaStratos]

So, version 1.2 isn't working on vB 3.7.2, right? I'm also anxiously awaiting an update.

[dknelson]

I just ran across another small problem. One of my members was trying to send a link to another member via a PM. The link is http://www.limestonebay.com which is a website for a hotel. This mod rewrites that link though and sends you to Ebay.

[siliconfinance]

any time now...I hope...still patiently waiting.

[siliconfinance]

anybody have a sure fire way to make this work in 3.7.x?

[creativepart]

It already does work in 3.7.X. I and many others are using it without problem.

What problems are you having?

[siliconfinance]

My above post and dismounted's reply:

Originally Posted by siliconfinance

Dismounted,

I know you are probably busy with other projects, but do you know whether you intend to update the script any time soon. The proposed changes that I made to my file do not seem to work. Thank you for this great mod.

Originally Posted by Dismounted

Soon .

[creativepart]

I'm running it on 4 websites all running 3.7.3 and all are earning money and showing clicks. I don't know what you are doing wrong.

I thought the programmer was responding to when he was going to fix the script from inadvertently rewriting non-ebay links that happen to have the letters ebay in the link. And to that question he answered... "soon." He was not answering your question of when he was going to fix the script to work with 3.7 -- because he already answered that one -- it was rewritten to work with ePN and it has always worked with 3.7

[siliconfinance]

Originally Posted by creativepart

I'm running it on 4 websites all running 3.7.3 and all are earning money and showing clicks. I don't know what you are doing wrong.

I thought the programmer was responding to when he was going to fix the script from inadvertently rewriting non-ebay links that happen to have the letters ebay in the link. And to that question he answered... "soon." He was not answering your question of when he was going to fix the script to work with 3.7 -- because he already answered that one -- it was rewritten to work with ePN and it has always worked with 3.7

Well, I am not sure where your impression came from since his reply was posted immediately after my post. Maybe I am wrong...who knows.

Nonetheless, I followed the modification steps layed out in his post and now this product doesn't seem to work for me so I have been waiting patiently.

[creativepart]

Then you have some problem with your installation. The mod works great.

Your first comment back on page 16 or 17 was that you had the same problem as another poster... which was that malformed URL (typos basically) were causing problems. He was asking for regex routines to be added to the mod to keep it from trying to parse malformed URLs.

Is that what you are waiting for? Or do you think the mod doesn't work with 3.7.3 and are waiting for it to be fixed for this version?

The MOD works as designed in 3.7.3 without problem and does not need fixing or updating.

[siliconfinance]

This didn't work:

Originally Posted by Dismounted

It generated a parse_url() error, correct? The cause of the error is that it isn't a valid URL. I'll need to do a loop to suppress errors, instead of using array_map().

In the meantime, just do this edit to the plugin "Rewrite Function". Find:

PHP Code:

$parsed = array_map('parse_url', array_map('strtolower', $links)); 


Replace With:

PHP Code:

// convert all links to lowercase
$links = array_map('strtolower', $links);
 
// parse links
$parsed = array();
foreach ($links AS $link)
{
    $parsed[] = @parse_url($link);
} 


But replacing the original phrase with this did:

Originally Posted by Dismounted

Try this instead:

PHP Code:

// convert all links to lowercase
$lower_links = array_map('strtolower', $links);
 
// parse links
$parsed = array();
foreach ($lower_links AS $link)
{
    $parsed[] = @parse_url($link);
}