Major Additions - Yet Another Awards System

*** CREATE A BACKUP OF YOUR FORUM AND DATABASE BEFORE INSTALLING ***

DESCRIPTION:
This is a Medals/Awards system. Admin can give members awards, and award icons will be displayed in member's profile, posts, as well as in a award list.

FEATURES:
In AdminCP
- Can Create/Edit/Delete/Reorder categories/sub-categories in ACP (with category name and description)
- Can Create/Edit/Delete awards in ACP (with Award Name, Description, Icon URL, Image URL)
- Can Move one (or all) award(s) from one category to another
- Can set some awards un-classified (not displayed for public)
- Can re-order awards in awards showcase
- Issue awards to members, based on username or userid, with Issue Reason
- Remove awards from members
+ Writes granting/removing awards to the log

In ModCP
- Issue awards to members, based on username or userid, with Issue Reason
- Remove awards from members
+ Writes granting/removing award to the log

Front page
- Display awards list in with: Award Name, Description, Icon, Image, and Members who get each award.
- Display awards showcase in profile, with Award information, Issue time and reason
- Display award icons in postbit (showthread, showpost, announcement, private)

New Features/Additions since 3.8
- Points System
- Separate Award Request/Recommendation Forms
- CSS Customizable

Current Release Version 4.0.9

• Added - Handling of user merges
• Added - Handling of user deletes
• Added - Manage awards on per user basis
• Added - Extra info to the logs for mass removal and editing of issued awards
• Added - Ability to collapse categories on awards.php
• Added - Checksum file for checking for suspect file versions
• Added - Various missing phrases
• Fixed - Memberlist not showing awards when option is active
• Fixed - Navtab not being selected (vb version < 4.2)
• Fixed - Category title not being displayed on awards.php
• Fixed - Logging not working in modcp
• Fixed - A few other minor bugs

[zeroality]

New post in an existing thread for award issue doesn't seem to be working.

Is it something on my end or is it YaAS?

Edit: It's not letting me change the PM userid either. I changed from user 10 to user 1, but it's still sending from user 10.

[squidsk]

Originally Posted by Capt C Ray

I am just about finished adding all our medals into our test site. Is there an easy way to transfer all the medals I have entered to our live site? Such as copying the table in the data base?

Export from the test site and import to the live site, you'll probably want to make sure you only export the table data, and only data that isn't present on the live site.

Originally Posted by zeroality

New post in an existing thread for award issue doesn't seem to be working.

Is it something on my end or is it YaAS?

See my last post as I mention this, posting a new post to a thread works just fine with an unaltered YaAS on a vanilla vb, so the problem is almost certainly on your end. You most likely have an anti-spam measure in place that's screwing things up.

Edit: It's not letting me change the PM userid either. I changed from user 10 to user 1, but it's still sending from user 10.

A bug in the code, I've added to my list of things to fix.

[Capt C Ray]

Originally Posted by squidsk

Export from the test site and import to the live site, you'll probably want to make sure you only export the table data, and only data that isn't present on the live site.

Thanks. Makes my life a whole lot easier. :up:

[MaxLiao]

I get the following error when recommending an award.

Fatal error: Existing data passed is not an array
Called set_existing in [path]/recommend_award.php on line 188
in [path]/includes/class_dm.php on line 265
#0 vb_error_handler(256, Existing data passed is not an array
Called set_existing in /*****/*****/*****/*****/*****/*****/recommend_award.php on line 188
, //*****/*****/*****/*****/*****/*****/includes/class_dm.php, 265, Array ([existing] => 0,[line] =>
Called set_existing in /*****/*****/*****/*****/*****/*****/recommend_award.php on line 188
,[trace] => Array ([0] => Array ([file] => /*****/*****/*****/*****/*****/*****/recommend_award.php,[line] => 188,[function] =>

Oh, and it just goes on and on and on from there ...

Using 4.0.6 on vB 4.2 PL3.

I tried researching this error, but even Google only came up with one hit, and it was on the 3.8 version.

As a side note, when recommending a rank (Yet Another Ranks System), it works just fine. It's only in the Awards mod that I get this error.

[squidsk]

Originally Posted by MaxLiao

I get the following error when recommending an award.

Oh, and it just goes on and on and on from there ...

Using 4.0.6 on vB 4.2 PL3.

I tried researching this error, but even Google only came up with one hit, and it was on the 3.8 version.

As a side note, when recommending a rank (Yet Another Ranks System), it works just fine. It's only in the Awards mod that I get this error.

There are a couple things to check, first that the forumid you're using to create the new threads actually exists and second that the user making the request actually has permission to post in that forum. The error is being caused because the threadid is not able to be verified and does not return the thread object (which should be an array).

[MaxLiao]

Thanks for the response.

Strangely enough, it's working now. I made no changes - seriously - other than to verify the forumid, my Admin user permissions, and the mod settings, all of which were good and none of which were changed.

I don't know what to say ... /shrug

Thanks.

[Edit / Update]: Okay, so I don't know if I accidentally used the Ranks mod instead of the Awards mod earlier, or if there's something else going on. However, the Ranks mod works fine but the Awards mod is not working ... still/again(?). Both mods have the exact same configs, including forum and usergroup posting permissions. I have uninstalled and re-installed the Awards mod.

From the AdminCP, it's all good. In fact, while it fails to post in the forums I see the request in the AdminCP.

Fatal error: Existing data passed is not an array
Called set_existing in [path]/recommend_award.php on line 188
in [path]/includes/class_dm.php on line 265

[squidsk]

Originally Posted by MaxLiao

Thanks for the response.

Strangely enough, it's working now. I made no changes - seriously - other than to verify the forumid, my Admin user permissions, and the mod settings, all of which were good and none of which were changed.

I don't know what to say ... /shrug

Thanks.

[Edit / Update]: Okay, so I don't know if I accidentally used the Ranks mod instead of the Awards mod earlier, or if there's something else going on. However, the Ranks mod works fine but the Awards mod is not working ... still/again(?). Both mods have the exact same configs, including forum and usergroup posting permissions. I have uninstalled and re-installed the Awards mod.

From the AdminCP, it's all good. In fact, while it fails to post in the forums I see the request in the AdminCP.

If ranks and awards have the same config then there's something else going on, since the relevant code is identical between them except for variable names.

[MaxLiao]

Again, thank you for the response ...

Further testing reveals the following:

• If I use "Submission: Award Submissions Forum ID," but I turn off "Submission: Create a poll in the new created thread" I do not get an error. On the other hand, I don't get a post either.
• If I use "Submission: Award Submissions Forum ID," and I turn on "Submission: Create a poll in the new created thread" This is when I get the Fatal Error.

I know HTML and CSS, but I don't know PHP, so when I look at the variations between the Rank and the Awards code and I see the following:

Awards code ... not working ... (partial) ...

{vb:stylevar htmldoctype}
<html xmlns="http://www.w3.org/1999/xhtml" dir="{vb:stylevar textdirection}" lang="{vb:stylevar languagecode}">
<head>

<title>{vb:raw vboptions.bbtitle} - {vb:rawphrase awards}</title>
{vb:raw headinclude}

{vb:raw headinclude_bottom}
</head>
<body>

{vb:raw header}
{vb:raw navbar}

Ranks code ... works fine ... (partial) ...

$stylevar[htmldoctype]
<html id="form" dir="$stylevar[textdirection]" lang="$stylevar[languagecode]">
<head>
<title>$vboptions[bbtitle] - $vbphrase[rank_recommendformtitle]</title>
$headinclude
</head>
<body>
$header
$navbar

Should I be concerned?

Mostly I'm noting the {vb:xxxxxxx} versus $xxxxxx differences.

Switching my language to UTF-8 wouldn't cause any problems, would it?

Lastly, I have no problems agreeing with you that there is most likely something else going on, but if you can tell me what to look for - since it is your mod that is having trouble sending the information - I research this further.

The people for whom I'm building this site are very adamant that this mod works, so I really appreciate your time in answering my posts and helping me resolve this issue.

[Edit / Update]: I just checked, and the PM function works perfectly, so it seems the only issue is posting on the forums.

[squidsk]

Originally Posted by MaxLiao

Again, thank you for the response ...

Further testing reveals the following:

• If I use "Submission: Award Submissions Forum ID," but I turn off "Submission: Create a poll in the new created thread" I do not get an error. On the other hand, I don't get a post either.
• If I use "Submission: Award Submissions Forum ID," and I turn on "Submission: Create a poll in the new created thread" This is when I get the Fatal Error.

This is telling, if when you aren't trying to create the poll you still aren't getting a new thread then there's a problem with the forum id. Either the forum id bad, or the user creating the new thread does not have permissions to do so or who knows perhaps something else entirely, otherwise you should get a new thread in the specified forum.

You can try to make the following changes to see if it helps track down the problem:

Change line 122 as follows:

$foruminfo = verify_id('forum', $vbulletin->options[award_request_formforumid], 0, 1);

to

$foruminfo = verify_id('forum', $vbulletin->options[award_request_formforumid], 1, 1);

and add the following between lines 138 and 139 (the red is the new code)

build_new_post('thread', $foruminfo, array(), array(), $newpost, $errors);
if (!empty($errors))
{
	$error = construct_errors($errors); // this will take the preview's place
	eval(standard_error($error));
}
$award_send += 1;

I know HTML and CSS, but I don't know PHP, so when I look at the variations between the Rank and the Awards code and I see the following:

Awards code ... not working ... (partial) ...

{vb:stylevar htmldoctype}
<html xmlns="http://www.w3.org/1999/xhtml" dir="{vb:stylevar textdirection}" lang="{vb:stylevar languagecode}">
<head>

<title>{vb:raw vboptions.bbtitle} - {vb:rawphrase awards}</title>
{vb:raw headinclude}

{vb:raw headinclude_bottom}
</head>
<body>

{vb:raw header}
{vb:raw navbar}

Ranks code ... works fine ... (partial) ...

$stylevar[htmldoctype]
<html id="form" dir="$stylevar[textdirection]" lang="$stylevar[languagecode]">
<head>
<title>$vboptions[bbtitle] - $vbphrase[rank_recommendformtitle]</title>
$headinclude
</head>
<body>
$header
$navbar

Should I be concerned?

Mostly I'm noting the {vb:xxxxxxx} versus $xxxxxx differences.

No concern necessary, the changes are a result of my updating the templates to use the vb4 style for templates as opposed to the old vb3 style.

Switching my language to UTF-8 wouldn't cause any problems, would it?

Are you talking about the encoding of the file or something else?

Lastly, I have no problems agreeing with you that there is most likely something else going on, but if you can tell me what to look for - since it is your mod that is having trouble sending the information - I research this further.

I'm not able to reproduce it, so its hard for me to determine the root cause.

The people for whom I'm building this site are very adamant that this mod works, so I really appreciate your time in answering my posts and helping me resolve this issue.

I try to help where I can.

[MaxLiao]

Just as a follow up, I have not applied your fix yet; however, I also have not had a single error (and no one has reported any errors to me). I'm going to keep things as-is, for now and I'll apply your fix when/if the issue arises again.

[Edit] Removed misinformation.

Thanks a ton!