Prevent Doubleposting

When a User posts into a thread where he already has the lastpost, no new post will be added. The lastpost of him will be edited and the new text is put after his first message.
This will be done until the old post is older than 24 hours (you can change this timespan yourself)

Nothing more to say about that, it's the quite same as my vb3.0 version.

This Mod should run with 3.6 as well


** Please make sure you ENABLE this product after you install it - it is disabled by default. **

For vb 3.8 there are two alternative updates ;

https://vborg.vbsupport.ru/showthread.php?t=203705
https://vborg.vbsupport.ru/showthread.php?t=204177

[Boofo]

Originally Posted by Paul M

All I did was answer it.

This is the part I was referring to:

If it bothers you then simply don't do step 1

[Paul M]

Originally Posted by moonclamp

Why did you call that a 'nasty' hack if it works?

Is there potential for problems?

There are no problems with it, it's just a phrase.

The 'fix' is really just a workaround to bypass ajax rather than a proper fix using ajax.

[Boofo]

Originally Posted by Paul M

Hmm, well I installed this on my test forum last night, and yes, it has (had) two problems ;

1. The post dateline is not updated on a merge, so it doesn't get seen as unread.

2. The one everyone complains about - no ajax refresh (unless you alter the time stamp, then you get two versions of the same post).


So, since I wanted this on our forum I have fixed both locally - this is what I have done.


1. To fix the timestamp ;

Find ;

PHP Code:

// set info 


Add below it ;

PHP Code:

$dataman2->set('dateline', TIMENOW); 


2. To fix the ajax issue, use this nasty hack ;

Find ;

PHP Code:

    if ($isdoublepost)
    {
        $id = $doublepost['postid'];
        $dataman->save();
 
        //now add edited by
        if ($dp_settings['editedbymsg'] != '')
        {
            $vbulletin->db->query_write("
                REPLACE INTO " . TABLE_PREFIX . "editlog (postid, userid, username, dateline, reason)
                VALUES ($id, " . $vbulletin->userinfo['userid'] . ", '" . addslashes($vbulletin->userinfo['username']) . "', " . TIMENOW . ", '" . addslashes($dp_settings['editedbymsg']) . "')
            ");
        }
    } 


Replace with ;

PHP Code:

    if ($isdoublepost)
    {
        // Ugly hack added by Paul M to fix ajax merge //
        if (!$vbulletin->GPC['ajax'])
        {
            $id = $doublepost['postid'];
            $dataman->save();
 
            if ($dp_settings['editedbymsg'] != '')
            {
                $vbulletin->db->query_write("
                REPLACE INTO " . TABLE_PREFIX . "editlog (postid, userid, username, dateline, reason)
                VALUES ($id, " . $vbulletin->userinfo['userid'] . ", '" . addslashes($vbulletin->userinfo['username']) . "', " . TIMENOW . ", '" . addslashes($dp_settings['editedbymsg']) . "')
                ");
            }
        }
        $vbulletin->url = 'showthread.php?' . $vbulletin->session->vars['sessionurl'] . "p=$post[postid]#post$post[postid]";
        eval(print_standard_redirect('redirect_postthanks', true, false));
    } 


Seems to work okay for me, feel free to try it.

Shouldn't that be:

PHP Code:

 $dataman2->set_info('dateline', TIMENOW);[/ 


[Paul M]

I don't believe so.

The line probably should't be with the other set_info lines, that just happens to be where I stuck it.

[Boofo]

Originally Posted by Paul M

I don't believe so.

The line probably should't be with the other set_info lines, that just happens to be where I stuck it.

Ok, good enough for me. Installed.

[Snake]

So Paul, this should fix the AJAX issue that we all are having, right?

[Xenon]

@Paul: the first thing is not a problem, it's designed that way

the change of the dateline was optional in the 3.0 version, but not in the original version, as it allows bumping...

[Paul M]

Originally Posted by Xenon

@Paul: the first thing is not a problem, it's designed that way

It's a problem to me, and a few others from reading the thread. We don't use it for "anti bumping", we just hate it when people double/treble post in quick sucession. The 'fix' is optional of course.

@Aftermath - Yes, it gets round it.

[moonclamp]

Originally Posted by Paul M

There are no problems with it, it's just a phrase.

The 'fix' is really just a workaround to bypass ajax rather than a proper fix using ajax.

But will ajax still work on the initial post?

[Paul M]

Yes.