Adding Template Conditionals to vB.

[neocorteqz]

Trying to add the following to functions.php

PHP Code:

// #################### Start is os ##########################
// os detection script
function is_os($os)
{
    global $_SERVER;
    static $is;
    if (!is_array($is))
    {
        $useragent = strtolower($_SERVER['HTTP_USER_AGENT']);
        $is = array(
            'linux' => 0,
            'mac' => 0,
            'windows' => 0,
            'webtv' => 0
        );

        // detect windows
        if (strpos($useragent, 'winnt,win32,windows,32bit') !== false)
        {
            $is['windows'] = 1;
        }
        
        // detect macintosh
        if (strpos($useragent, 'mac') !== false)
        {
            $is['mac'] = 1;
        }

        
        // detect linux
        if (strpos($useragent, 'linux,x11,u,i686') !== false)
        {
            $is['linux'] = 1;
        }

        
        // detect web tv
        if (strpos($useragent, 'webtv') !== false)
        {
            preg_match('#webtv/([0-9\.]+)#', $useragent, $regs);
            $is['webtv'] = $regs[1];
        }

    }

    // sanitize the incoming os name
    $os = strtolower($os);
    if (substr($os, 0, 3) == 'is_')
    {
        $os = substr($os, 3);
    }

}
// #################### End is os ########################## 


But when i try to use it i get this error



Are there other files I need to edit to add template conditionals?

And a second question.

is the 'if' in the code above correct?
This:

PHP Code:

if (strpos($useragent, 'winnt,win32,windows,32bit') !== false) 


[Marco van Herwaarden]

Normally you can not use any other then the default conditionals in template.

[neocorteqz]

Originally Posted by MarcoH64

Normally you can not use any other then the default conditionals in template.

I know. which makes what I want to do, kinda hard. So i was trying to add something to where i can use a custom conditional in a template.

Is there way I can add what i'm trying to do to say is_browser?

it's basically an os specific conditional, so i can use some plugin that require certain operating systems.

[Revan]

You have to add the function to an array defined somewhere in adminfunctions_template.php
Give me 1 min and I will edit this post with the exact name and place

In adminfunctions_template.php find:

PHP Code:

// vBulletin-defined functions
            'can_moderate',          // obvious one
            'can_moderate_calendar', // another obvious one
            'exec_switch_bg',        // harmless function that we use sometimes
            'is_browser',            // function to detect browser and versions
            'is_member_of',          // function to check if $user is member of $usergroupid 


under, add:

PHP Code:

'is_os',          // function to check the OS of the member 


Original Thread
Kall wrote the thread, but I was the one to put him on the right track to find this code

[neocorteqz]

Originally Posted by Revan

You have to add the function to an array defined somewhere in adminfunctions_template.php
Give me 1 min and I will edit this post with the exact name and place

In adminfunctions_template.php find:

PHP Code:

// vBulletin-defined functions
            'can_moderate',          // obvious one
            'can_moderate_calendar', // another obvious one
            'exec_switch_bg',        // harmless function that we use sometimes
            'is_browser',            // function to detect browser and versions
            'is_member_of',          // function to check if $user is member of $usergroupid 


under, add:

PHP Code:

'is_os',          // function to check the OS of the member 


Original Thread
Kall wrote the thread, but I was the one to put him on the right track to find this code

Now i can see if my code works. which I believe it should. I knew there was another file i needed to add somethning.

thanks!

Alright, that allows me to use the template conditional, now All i need to do is figure out why it's not working. well kinda working, but it's not showing for any os listed in the code.

[kall]

Originally Posted by Revan

Kall wrote the thread, but I was the one to put him on the right track to find this code

And I am eternally grateful.

That's what makes this place great, the fact that people are prepared to help others get their heads around the code.

[neocorteqz]

kall, i know hat ya mean, it's great.

Looking for a little help now.

Here is the revised code.

PHP Code:

// #################### Start is os ##########################
// os detection script
function is_os($os)
{
    global $_SERVER;
    static $is;
    if (!is_array($is))
    {
        $useragent = strtolower($_SERVER['HTTP_USER_AGENT']);
        $is = array(
            'linux' => 0,
            'mac' => 0,
            'windows' => 0,
            'webtv' => 0
        );

        // detect windows
        if ((strpos($useragent, 'winnt') !== false) AND (strpos($useragent, 'win32') !== false))
        {
            $is['windows'] = 1;
        }
        
        // detect macintosh
        if (strpos($useragent, 'mac') !== false)
        {
            $is['mac'] = 1;
        }

        
        // detect linux
        if ((strpos($useragent, 'linux') !== false) AND (strpos($useragent, 'x11') !== false) AND (strpos($useragent, 'i686') !== false)))
        {
            $is['linux'] = 1;
        }

        
        // detect web tv
        if (strpos($useragent, 'webtv') !== false)
        {
            preg_match('#webtv/([0-9\.]+)#', $useragent, $regs);
            $is['webtv'] = $regs[1];
        }

    }

    // sanitize the incoming os name
    $os = strtolower($os);
    if (substr($os, 0, 3) == 'is_')
    {
        $os = substr($os, 3);
    }

}
// #################### End is os ########################## 


Is there anything wrong in that?
Because i use the conditional

<if condition="is_os('windows')">
code here
</if>

And nothing shows up.

Now I know I'm in windows. and I know is_browser('ie') works.

did i miss something in the code?? I used exosting vB code as a model (specifically is_browser)

do i need to add the user agent strings to the code as they have in is_browser?

[Marco van Herwaarden]

Hmm maybe i am missing something, but i can't see where the incoming string 'windows' ($os) is being tested against the detected os. The function should return a TRUE or FALSE.

Just try your function first with a test script, without templates, just call it from a plain php testfile. Much easier to debaug.

[neocorteqz]

Originally Posted by MarcoH64

Hmm maybe i am missing something, but i can't see where the incoming string 'windows' ($os) is being tested against the detected os. The function should return a TRUE or FALSE.

Just try your function first with a test script, without templates, just call it from a plain php testfile. Much easier to debaug.

how would I do that?

I'm still very much a noobie when it comes to this stuff.

[Marco van Herwaarden]

PHP Code:

<?php
require_once('./includes/yourincludefile.php');

if (is_os('windows'))
{
   echo "<br />Yes windows";
}
else
{
   echo "<br />No windows";
}

?>